[PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[Krzysztof Kozlowski]

minItems does not impose any limit on actual maximum number of items in
a list, thus it needs maxItems.  maxItems on the other hand does imply
minItems.  Add missing upper bound on 'reg' and 'mboxes'.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
index 25a2b42105e5..052e23966a8f 100644
--- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
+++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
@@ -48,7 +48,7 @@ properties:
     const: debug_messages
 
   reg:
-    minItems: 1
+    maxItems: 1
 
   mbox-names:
     description: |
@@ -59,7 +59,7 @@ properties:
       - const: tx
 
   mboxes:
-    minItems: 2
+    maxItems: 2
 
   ti,host-id:
     $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.53.0

Re: [PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing minItems allows incomplete mboxes array
--

commit 344119f20b7b40eacf80223cff1d1579d7303039
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

This commit replaces minItems constraints with maxItems constraints for the
reg and mboxes properties. It intends to enforce an upper bound on these
lists while assuming the lower bound remains intact.

>     minItems does not impose any limit on actual maximum number of items in
>     a list, thus it needs maxItems.  maxItems on the other hand does imply
>     minItems.  Add missing upper bound on 'reg' and 'mboxes'.

[Severity: Medium]
Is the statement that maxItems implies minItems accurate for values greater
than 1?

In JSON Schema and dt-schema, omitting minItems on an array defaults to
minItems: 1, regardless of the maxItems value.

> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e54..052e23966a8f1 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
[ ... ]
> @@ -59,7 +59,7 @@ properties:
>        - const: tx
>  
>    mboxes:
> -    minItems: 2
> +    maxItems: 2

[Severity: Medium]
Does removing minItems: 2 here incorrectly allow partial configurations?

A device tree providing only a single mailbox will pass schema validation
since the default minItems is 1, even though exactly two mailboxes (rx and
tx) are required by the hardware and the mbox-names constraint.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002063011.38972-2-krzysztof.kozlowski@oss.qualcomm.com?part=1

Re: [PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[Krzysztof Kozlowski]

On 02/10/2026 11:14, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dt-bindings: missing minItems allows incomplete mboxes array

Complete bollocks.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: arm: keystone: ti,sci: Correct reg and mboxes constraints

[Rob Herring (Arm)]

On Fri, 02 Oct 2026 08:30:12 +0200, Krzysztof Kozlowski wrote:
> minItems does not impose any limit on actual maximum number of items in
> a list, thus it needs maxItems.  maxItems on the other hand does imply
> minItems.  Add missing upper bound on 'reg' and 'mboxes'.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!