From: sashiko-bot@kernel.org
To: "Roman Smrž" <roman@amarulasolutions.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] ASoC: pcm179x: Add pcm1796 as compatible with pcm1792a
Date: Fri, 02 Oct 2026 09:57:37 +0000 [thread overview]
Message-ID: <20261002095737.C80941F0089D@smtp.kernel.org> (raw)
In-Reply-To: <20261002-work-v1-4-f0e53bc7331f@amarulasolutions.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] spi: missing pcm1796 spi_device_id breaks module autoloading
--
commit 8959b1de4bb8c22b7a8a0f59806c5a6f767c0c82
Author: Roman Smrž <roman@amarulasolutions.com>
ASoC: pcm179x: Add pcm1796 as compatible with pcm1792a
The PCM1796 is fully compatible with the PCM1792A.
> diff --git a/sound/soc/codecs/pcm179x-spi.c b/sound/soc/codecs/pcm179x-spi.c
> index 192fee90c9714..e5e4b942acfc5 100644
> --- a/sound/soc/codecs/pcm179x-spi.c
> +++ b/sound/soc/codecs/pcm179x-spi.c
> @@ -31,6 +31,7 @@ static int pcm179x_spi_probe(struct spi_device *spi)
>
> static const struct of_device_id pcm179x_of_match[] __maybe_unused = {
> { .compatible = "ti,pcm1792a", },
> + { .compatible = "ti,pcm1796" },
> { }
> };
> MODULE_DEVICE_TABLE(of, pcm179x_of_match);
[Severity: High]
Should pcm179x_spi_ids[] also include an entry for "pcm1796"?
Without a "pcm1796" entry in pcm179x_spi_ids[], SPI module autoloading fails
for DT-instantiated devices and legacy board-file matching fails.
The SPI core (__spi_register_driver()) explicitly enforces OF-to-SPI ID
parity and will emit a warning during driver registration.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-work-v1-0-f0e53bc7331f@amarulasolutions.com?part=4
next prev parent reply other threads:[~2026-10-02 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 9:49 [PATCH 0/5] ASoC: pcm179x: Add support for pcm1795 and pcm1796 Roman Smrž
2026-10-02 9:49 ` [PATCH 1/5] ASoC: dt-bindings: Add ti,pcm1795 and ti,pcm1796 Roman Smrž
2026-10-03 14:34 ` Krzysztof Kozlowski
2026-10-02 9:49 ` [PATCH 2/5] ASoC: pcm179x: Refactor regmap value lookup Roman Smrž
2026-10-02 9:49 ` [PATCH 3/5] ASoC: pcm179x: Add left-justified formats for pcm1792a Roman Smrž
2026-10-02 9:57 ` sashiko-bot
2026-10-02 9:49 ` [PATCH 4/5] ASoC: pcm179x: Add pcm1796 as compatible with pcm1792a Roman Smrž
2026-10-02 9:57 ` sashiko-bot [this message]
2026-10-03 14:35 ` Krzysztof Kozlowski
2026-10-02 9:49 ` [PATCH 5/5] ASoC: pcm179x: Add support for pcm1975 Roman Smrž
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002095737.C80941F0089D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=roman@amarulasolutions.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox