Re: [PATCH 3/5] ASoC: pcm179x: Add left-justified formats for pcm1792a

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ASoC: pcm179x: missing LEFT_J in auto_selectable_formats
--

commit f6579131e2b6aaf5049aa6728620f5e3a4687837
Author: Roman Smrž <roman@amarulasolutions.com>

ASoC: pcm179x: Add left-justified formats for pcm1792a

This commit adds left-justified format support for 24 and 32 bits to
the pcm1792a format table to match the datasheet.

> diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c
> index 61b87dab32667..c059e410cbbe4 100644
> --- a/sound/soc/codecs/pcm179x.c
> +++ b/sound/soc/codecs/pcm179x.c
> @@ -75,6 +75,8 @@ static const struct pcm179x_fmt_table pcm1792a_fmt[] = {
>  	{ SND_SOC_DAIFMT_RIGHT_J, 16, 0 },
>  	{ SND_SOC_DAIFMT_RIGHT_J, 24, 2 },
>  	{ SND_SOC_DAIFMT_RIGHT_J, 32, 2 },
> +	{ SND_SOC_DAIFMT_LEFT_J,  24, 3 },
> +	{ SND_SOC_DAIFMT_LEFT_J,  32, 3 },

[Severity: Medium]
Should the new left-justified format also be added to the auto-negotiation
bitmask in this file?

When the ASoC core attempts to find a matching DAI format between the CPU
and codec components, it intersects their supported auto-selectable formats.
Because SND_SOC_POSSIBLE_DAIFMT_LEFT_J is omitted from the bitmask, it
appears this format will be skipped and remain unavailable to generic
machine drivers unless manually configured in the device tree.

For context, the current bitmask only includes I2S and right-justified
formats:

sound/soc/codecs/pcm179x.c:pcm179x_selectable_formats
static const u64 pcm179x_selectable_formats =
	SND_SOC_POSSIBLE_DAIFMT_I2S	|
	SND_SOC_POSSIBLE_DAIFMT_RIGHT_J;

>  	{ SND_SOC_DAIFMT_I2S,     16, 4 },
>  	{ SND_SOC_DAIFMT_I2S,     24, 5 },
>  	{ SND_SOC_DAIFMT_I2S,     32, 5 },
> };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-work-v1-0-f0e53bc7331f@amarulasolutions.com?part=3