Re: [PATCH v2 04/11] dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: schema bypass due to compatible string in standalone enum
--

commit fe965abba1a50ee3f23c3149e9b465705dc13459
Author: Richard Acayan <mailingradian@gmail.com>

dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible

The commit adds the SDM670 ADSP compatible string to the qcom,adsp binding.
It splits the compatible property into a oneOf block to allow the SDM670
compatible to fallback to SDM845.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 7e8ecae8e6cb6..6cf1f11efe041 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -15,19 +15,26 @@ description:
>  
>  properties:
>    compatible:
[ ... ]
> +    oneOf:
> +      - enum:
> +          - qcom,msm8226-adsp-pil
[ ... ]
> +          - qcom,sdm660-cdsp-pas
> +          - qcom,sdm670-adsp-pas

[Severity: Medium]
Does adding qcom,sdm670-adsp-pas to this standalone enum branch bypass the
fallback requirement?

Because oneOf only requires a single branch to match, a device tree node
specifying only "qcom,sdm670-adsp-pas" matches this enum branch and passes
schema validation.

This bypasses the fallback enforcement in the items branch below, allowing
DTS nodes to be introduced without the required fallback string. Without
the fallback string, older kernels may fail to probe the device.

> +          - qcom,sdm845-adsp-pas
> +          - qcom,sdm845-cdsp-pas
> +          - qcom,sdm845-slpi-pas
> +
> +      - items:
> +          - enum:
> +              - qcom,sdm670-adsp-pas
> +          - const: qcom,sdm845-adsp-pas
>  
>    reg:
>      maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003175659.23536-1-mailingradian@gmail.com?part=4