Re: [PATCH v2 09/11] arm64: dts: qcom: pm660l: add analog audio codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dts: pm660l: board-specific hardware properties hardcoded in generic PMIC dtsi
- [Low] dts: pm660l: undeclared sound-name-prefix causes dtbs_check warning
--

commit cfcd4e3e10aad19a5a6d69fee31b064e8108d24a
Author: Richard Acayan <mailingradian@gmail.com>

arm64: dts: qcom: pm660l: add analog audio codec

The PM660L analog audio codec (PMIC revision 4) controls the headphone
jack, and optionally the earpiece and speaker, at the vendor's decision.
This commit adds the analog audio codec to the generic PMIC device tree.

> diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> index 3f8b9eafe1641..5b406b83043c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> @@ -87,6 +87,46 @@ pm660l_wled: leds@d800 {
>  			status = "disabled";
>  		};
>  
> +		pm660l_codec: audio-codec@f000 {
> +			compatible = "qcom,pm660l-wcd-analog-codec",
> +				     "qcom,pm8953-wcd-analog-codec";
> +			reg = <0xf000>;
[ ... ]
> +			interrupt-names = "cdc_spk_cnp_int",
> +					  "cdc_spk_clip_int",
> +					  "cdc_spk_ocp_int",
> +					  "mbhc_ins_rem_det1",
> +					  "mbhc_but_rel_det",
> +					  "mbhc_but_press_det",
> +					  "mbhc_ins_rem_det",
> +					  "mbhc_switch_int",
> +					  "cdc_ear_ocp_int",
> +					  "cdc_hphr_ocp_int",
> +					  "cdc_hphl_ocp_det",
> +					  "cdc_ear_cnp_int",
> +					  "cdc_hphr_cnp_int",
> +					  "cdc_hphl_cnp_int";
> +			qcom,hphl-jack-type-normally-open;
> +			qcom,gnd-jack-type-normally-open;
> +			qcom,micbias2-ext-cap;

[Severity: Medium]
Will this cause problems for other boards that include this generic PMIC
file but have different hardware wiring?

These physical wiring properties (qcom,hphl-jack-type-normally-open,
qcom,gnd-jack-type-normally-open, qcom,micbias2-ext-cap) seem like they
should be placed in board-specific .dts files rather than a generic common
.dtsi.

Other boards with differently wired jacks (e.g., normally-closed) or lacking
an external capacitor will inherit these settings, which could lead to
inverted headphone detection or broken microphones.

> +			sound-name-prefix = "Analog";

[Severity: Low]
Is this sound-name-prefix property supported by the dt-binding schema?

It appears that the dt-binding schema for this codec
(Documentation/devicetree/bindings/sound/qcom,pm8916-wcd-analog-codec.yaml)
enforces additionalProperties: false and does not define sound-name-prefix.
Adding it here will likely cause a dtbs_check validation failure.

> +			#sound-dai-cells = <1>;
> +			status = "disabled";
> +		};
> +
>  		pm660l_spmi_regulators: regulators {
>  			compatible = "qcom,pm660l-regulators";
>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003175659.23536-1-mailingradian@gmail.com?part=9