Re: [PATCH 1/2] dt-bindings: connector: Add time property for tSenderResponse

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing schema constraints for sender-response-time-ms
--

commit eb9d81bbfb13df2dbe09db76aefbc40c815abe01
Author: Amit Sunil Dhamne <amitsd@google.com>

dt-bindings: connector: Add time property for tSenderResponse

Add the sender-response-time-ms property to allow platforms to specify
the tSenderResponse timer value, i.e. the max time a port waits for the
port partner to respond to a message that requires a response.

> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 8ca0292490a2c..52dbdd738db64 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -283,6 +283,15 @@ properties:
>      maximum: 200
>      default: 200
>  
> +  sender-response-time-ms:
> +    description: Represents the max time in ms that a Type-C port waits for

[Severity: Low]
Is this new property missing minimum, maximum, or default constraints?

Unlike other timers in this schema (such as sink-wait-cap-time-ms), the lack
of boundaries means offline schema validation (dt_binding_check) will silently
accept arbitrary values. Should this have explicit numerical limits to prevent
accidentally violating USB PD timing requirements?

> +      the port partner to respond to a message that requires a response. This
> +      timer starts when the port's PHY layer receives the last bit of the
> +      GoodCRC EOP corresponding to the message requiring a response. This timer
> +      stops when the last bit of the EOP of the expected response message is
> +      received by the PHY layer. A timeout leads to a soft or hard reset by the
> +      port.
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-tcpm-sender-response-time-v1-0-3f8b43084acc@google.com?part=1