* [PATCH 01/17] ARM: dts: samsung: exynos4: add or remove empty lines
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
@ 2026-10-04 20:15 ` Henrik Grimler
2026-10-04 20:15 ` [PATCH 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
` (15 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
For better readability it is preferred to have an empty line before
the status property, as well as before every child node. Empty lines
do not really help at start of children nodes though. Add or remove
empty lines where applicable.
dt-check-style when run in strict mode reports the issues like:
samsung/exynos4.dtsi:90: [required-blank-lines] "status" must be preceded by a blank line
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4.dtsi | 58 ++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
index ed47d0ce04e1..c38489a05e15 100644
--- a/arch/arm/boot/dts/samsung/exynos4.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
@@ -54,6 +54,7 @@ aliases {
pmu: pmu {
compatible = "arm,cortex-a9-pmu";
interrupt-parent = <&combiner>;
+
status = "disabled";
};
@@ -87,6 +88,7 @@ i2s0: i2s@3830000 {
dma-names = "tx", "rx", "tx-sec";
samsung,idma-addr = <0x03000000>;
#sound-dai-cells = <1>;
+
status = "disabled";
};
@@ -196,6 +198,7 @@ dsi_0: dsi@11c80000 {
phy-names = "dsim";
clocks = <&clock CLK_DSIM0>, <&clock CLK_SCLK_MIPI0>;
clock-names = "bus_clk", "sclk_mipi";
+
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
@@ -204,6 +207,7 @@ dsi_0: dsi@11c80000 {
camera: camera@11800000 {
compatible = "samsung,fimc";
ranges = <0x0 0x11800000 0xa0000>;
+
status = "disabled";
#address-cells = <1>;
#size-cells = <1>;
@@ -220,6 +224,7 @@ fimc_0: fimc@0 {
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
iommus = <&sysmmu_fimc0>;
+
status = "disabled";
};
@@ -233,6 +238,7 @@ fimc_1: fimc@10000 {
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
iommus = <&sysmmu_fimc1>;
+
status = "disabled";
};
@@ -246,6 +252,7 @@ fimc_2: fimc@20000 {
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
iommus = <&sysmmu_fimc2>;
+
status = "disabled";
};
@@ -259,6 +266,7 @@ fimc_3: fimc@30000 {
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
iommus = <&sysmmu_fimc3>;
+
status = "disabled";
};
@@ -273,6 +281,7 @@ csis_0: csis@80000 {
power-domains = <&pd_cam>;
phys = <&mipi_phy 0>;
phy-names = "csis";
+
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
@@ -289,6 +298,7 @@ csis_1: csis@90000 {
power-domains = <&pd_cam>;
phys = <&mipi_phy 2>;
phy-names = "csis";
+
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
@@ -303,6 +313,7 @@ rtc: rtc@10070000 {
<GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_RTC>;
clock-names = "rtc";
+
status = "disabled";
};
@@ -312,6 +323,7 @@ keypad: keypad@100a0000 {
interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_KEYIF>;
clock-names = "keypad";
+
status = "disabled";
};
@@ -321,6 +333,7 @@ sdhci_0: mmc@12510000 {
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_SDMMC0>, <&clock CLK_SCLK_MMC0>;
clock-names = "hsmmc", "mmc_busclk.2";
+
status = "disabled";
};
@@ -330,6 +343,7 @@ sdhci_1: mmc@12520000 {
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_SDMMC1>, <&clock CLK_SCLK_MMC1>;
clock-names = "hsmmc", "mmc_busclk.2";
+
status = "disabled";
};
@@ -339,6 +353,7 @@ sdhci_2: mmc@12530000 {
interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_SDMMC2>, <&clock CLK_SCLK_MMC2>;
clock-names = "hsmmc", "mmc_busclk.2";
+
status = "disabled";
};
@@ -348,6 +363,7 @@ sdhci_3: mmc@12540000 {
interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_SDMMC3>, <&clock CLK_SCLK_MMC3>;
clock-names = "hsmmc", "mmc_busclk.2";
+
status = "disabled";
};
@@ -358,6 +374,7 @@ exynos_usbphy: usb-phy@125b0000 {
clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>;
clock-names = "phy", "ref";
#phy-cells = <1>;
+
status = "disabled";
};
@@ -369,6 +386,7 @@ hsotg: usb@12480000 {
clock-names = "otg";
phys = <&exynos_usbphy 0>;
phy-names = "usb2-phy";
+
status = "disabled";
};
@@ -378,6 +396,7 @@ ehci: usb@12580000 {
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
+
status = "disabled";
phys = <&exynos_usbphy 1>, <&exynos_usbphy 2>, <&exynos_usbphy 3>;
phy-names = "host", "hsic0", "hsic1";
@@ -389,6 +408,7 @@ ohci: usb@12590000 {
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
+
status = "disabled";
phys = <&exynos_usbphy 1>;
phy-names = "host";
@@ -405,6 +425,7 @@ gpu: gpu@13000000 {
<&clock CLK_SCLK_G3D>;
clock-names = "bus", "core";
power-domains = <&pd_g3d>;
+
status = "disabled";
};
@@ -418,6 +439,7 @@ i2s1: i2s@13960000 {
dmas = <&pdma1 12>, <&pdma1 11>;
dma-names = "tx", "rx";
#sound-dai-cells = <1>;
+
status = "disabled";
};
@@ -431,6 +453,7 @@ i2s2: i2s@13970000 {
dmas = <&pdma0 14>, <&pdma0 13>;
dma-names = "tx", "rx";
#sound-dai-cells = <1>;
+
status = "disabled";
};
@@ -453,6 +476,7 @@ serial_0: serial@13800000 {
clock-names = "uart", "clk_uart_baud0";
dmas = <&pdma0 15>, <&pdma0 16>;
dma-names = "rx", "tx";
+
status = "disabled";
};
@@ -464,6 +488,7 @@ serial_1: serial@13810000 {
clock-names = "uart", "clk_uart_baud0";
dmas = <&pdma1 15>, <&pdma1 16>;
dma-names = "rx", "tx";
+
status = "disabled";
};
@@ -475,6 +500,7 @@ serial_2: serial@13820000 {
clock-names = "uart", "clk_uart_baud0";
dmas = <&pdma0 17>, <&pdma0 18>;
dma-names = "rx", "tx";
+
status = "disabled";
};
@@ -486,6 +512,7 @@ serial_3: serial@13830000 {
clock-names = "uart", "clk_uart_baud0";
dmas = <&pdma1 17>, <&pdma1 18>;
dma-names = "rx", "tx";
+
status = "disabled";
};
@@ -499,6 +526,7 @@ i2c_0: i2c@13860000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c0_bus>;
+
status = "disabled";
};
@@ -512,6 +540,7 @@ i2c_1: i2c@13870000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c1_bus>;
+
status = "disabled";
};
@@ -525,6 +554,7 @@ i2c_2: i2c@13880000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c2_bus>;
+
status = "disabled";
};
@@ -538,6 +568,7 @@ i2c_3: i2c@13890000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c3_bus>;
+
status = "disabled";
};
@@ -551,6 +582,7 @@ i2c_4: i2c@138a0000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c4_bus>;
+
status = "disabled";
};
@@ -564,6 +596,7 @@ i2c_5: i2c@138b0000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c5_bus>;
+
status = "disabled";
};
@@ -577,6 +610,7 @@ i2c_6: i2c@138c0000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c6_bus>;
+
status = "disabled";
};
@@ -590,6 +624,7 @@ i2c_7: i2c@138d0000 {
clock-names = "i2c";
pinctrl-names = "default";
pinctrl-0 = <&i2c7_bus>;
+
status = "disabled";
};
@@ -601,6 +636,7 @@ i2c_8: i2c@138e0000 {
interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C_HDMI>;
clock-names = "i2c";
+
status = "disabled";
hdmi_i2c_phy: hdmi-phy@38 {
@@ -622,6 +658,7 @@ spi_0: spi@13920000 {
pinctrl-names = "default";
pinctrl-0 = <&spi0_bus>;
fifo-depth = <256>;
+
status = "disabled";
};
@@ -638,6 +675,7 @@ spi_1: spi@13930000 {
pinctrl-names = "default";
pinctrl-0 = <&spi1_bus>;
fifo-depth = <64>;
+
status = "disabled";
};
@@ -654,6 +692,7 @@ spi_2: spi@13940000 {
pinctrl-names = "default";
pinctrl-0 = <&spi2_bus>;
fifo-depth = <64>;
+
status = "disabled";
};
@@ -668,6 +707,7 @@ pwm: pwm@139d0000 {
clocks = <&clock CLK_PWM>;
clock-names = "timers";
#pwm-cells = <3>;
+
status = "disabled";
};
@@ -709,6 +749,7 @@ fimd: fimd@11c00000 {
power-domains = <&pd_lcd0>;
iommus = <&sysmmu_fimd0>;
samsung,sysreg = <&sys_reg>;
+
status = "disabled";
};
@@ -716,6 +757,7 @@ tmu: tmu@100c0000 {
interrupt-parent = <&combiner>;
reg = <0x100c0000 0x100>;
interrupts = <2 4>;
+
status = "disabled";
#thermal-sensor-cells = <0>;
};
@@ -753,6 +795,7 @@ hdmi: hdmi@12d00000 {
power-domains = <&pd_tv>;
samsung,syscon-phandle = <&pmu_system_controller>;
#sound-dai-cells = <0>;
+
status = "disabled";
};
@@ -766,6 +809,7 @@ hdmicec: cec@100b0000 {
hdmi-phandle = <&hdmi>;
pinctrl-names = "default";
pinctrl-0 = <&hdmi_cec>;
+
status = "disabled";
};
@@ -775,6 +819,7 @@ mixer: mixer@12c10000 {
reg = <0x12c10000 0x2100>, <0x12c00000 0x300>;
power-domains = <&pd_tv>;
iommus = <&sysmmu_tv>;
+
status = "disabled";
};
@@ -783,6 +828,7 @@ ppmu_dmc0: ppmu@106a0000 {
reg = <0x106a0000 0x2000>;
clocks = <&clock CLK_PPMUDMC0>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -791,6 +837,7 @@ ppmu_dmc1: ppmu@106b0000 {
reg = <0x106b0000 0x2000>;
clocks = <&clock CLK_PPMUDMC1>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -799,6 +846,7 @@ ppmu_cpu: ppmu@106c0000 {
reg = <0x106c0000 0x2000>;
clocks = <&clock CLK_PPMUCPU>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -807,6 +855,7 @@ ppmu_rightbus: ppmu@112a0000 {
reg = <0x112a0000 0x2000>;
clocks = <&clock CLK_PPMURIGHT>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -815,6 +864,7 @@ ppmu_leftbus: ppmu@116a0000 {
reg = <0x116a0000 0x2000>;
clocks = <&clock CLK_PPMULEFT>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -823,6 +873,7 @@ ppmu_camif: ppmu@11ac0000 {
reg = <0x11ac0000 0x2000>;
clocks = <&clock CLK_PPMUCAMIF>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -831,12 +882,14 @@ ppmu_lcd0: ppmu@11e40000 {
reg = <0x11e40000 0x2000>;
clocks = <&clock CLK_PPMULCD0>;
clock-names = "ppmu";
+
status = "disabled";
};
ppmu_fsys: ppmu@12630000 {
compatible = "samsung,exynos-ppmu";
reg = <0x12630000 0x2000>;
+
status = "disabled";
};
@@ -845,6 +898,7 @@ ppmu_image: ppmu@12aa0000 {
reg = <0x12aa0000 0x2000>;
clocks = <&clock CLK_PPMUIMAGE>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -853,6 +907,7 @@ ppmu_tv: ppmu@12e40000 {
reg = <0x12e40000 0x2000>;
clocks = <&clock CLK_PPMUTV>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -861,6 +916,7 @@ ppmu_g3d: ppmu@13220000 {
reg = <0x13220000 0x2000>;
clocks = <&clock CLK_PPMUG3D>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -869,6 +925,7 @@ ppmu_mfc_left: ppmu@13660000 {
reg = <0x13660000 0x2000>;
clocks = <&clock CLK_PPMUMFC_L>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -877,6 +934,7 @@ ppmu_mfc_right: ppmu@13670000 {
reg = <0x13670000 0x2000>;
clocks = <&clock CLK_PPMUMFC_R>;
clock-names = "ppmu";
+
status = "disabled";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 02/17] ARM: dts: samsung: exynos4: order *-names properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-04 20:15 ` [PATCH 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
@ 2026-10-04 20:15 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
` (14 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
pinctrl-names, clock-names and interrupt-names should be after
pinctrl-*, clocks and interrupts respectively. Re-order all of them to
make the files consistent.
dt-check-style in strict mode reports the issues like:
samsung/exynos4.dtsi:745: [property-order] property 'interrupt-names' must be placed after 'interrupts'
samsung/exynos4.dtsi:788: [property-order] property 'clock-names' must be placed after 'clocks'
samsung/exynos4.dtsi:810: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4.dtsi | 50 +++++++++++++++++-----------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
index c38489a05e15..f69b01423ae0 100644
--- a/arch/arm/boot/dts/samsung/exynos4.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
@@ -524,8 +524,8 @@ i2c_0: i2c@13860000 {
interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C0>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c0_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -538,8 +538,8 @@ i2c_1: i2c@13870000 {
interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C1>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c1_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -552,8 +552,8 @@ i2c_2: i2c@13880000 {
interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C2>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c2_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -566,8 +566,8 @@ i2c_3: i2c@13890000 {
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C3>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c3_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -580,8 +580,8 @@ i2c_4: i2c@138a0000 {
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C4>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c4_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -594,8 +594,8 @@ i2c_5: i2c@138b0000 {
interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C5>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c5_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -608,8 +608,8 @@ i2c_6: i2c@138c0000 {
interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C6>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c6_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -622,8 +622,8 @@ i2c_7: i2c@138d0000 {
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C7>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c7_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -655,8 +655,8 @@ spi_0: spi@13920000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI0>, <&clock CLK_SCLK_SPI0>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi0_bus>;
+ pinctrl-names = "default";
fifo-depth = <256>;
status = "disabled";
@@ -672,8 +672,8 @@ spi_1: spi@13930000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI1>, <&clock CLK_SCLK_SPI1>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi1_bus>;
+ pinctrl-names = "default";
fifo-depth = <64>;
status = "disabled";
@@ -689,8 +689,8 @@ spi_2: spi@13940000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI2>, <&clock CLK_SCLK_SPI2>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi2_bus>;
+ pinctrl-names = "default";
fifo-depth = <64>;
status = "disabled";
@@ -742,8 +742,8 @@ fimd: fimd@11c00000 {
compatible = "samsung,exynos4210-fimd";
interrupt-parent = <&combiner>;
reg = <0x11c00000 0x20000>;
- interrupt-names = "fifo", "vsync", "lcd_sys";
interrupts = <11 0>, <11 1>, <11 2>;
+ interrupt-names = "fifo", "vsync", "lcd_sys";
clocks = <&clock CLK_SCLK_FIMD0>, <&clock CLK_FIMD0>;
clock-names = "sclk_fimd", "fimd";
power-domains = <&pd_lcd0>;
@@ -785,12 +785,12 @@ hdmi: hdmi@12d00000 {
compatible = "samsung,exynos4210-hdmi";
reg = <0x12d00000 0x70000>;
interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
- clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
- "sclk_hdmiphy", "mout_hdmi";
clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,
<&clock CLK_SCLK_PIXEL>,
<&clock CLK_SCLK_HDMIPHY>,
<&clock CLK_MOUT_HDMI>;
+ clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
+ "sclk_hdmiphy", "mout_hdmi";
phy = <&hdmi_i2c_phy>;
power-domains = <&pd_tv>;
samsung,syscon-phandle = <&pmu_system_controller>;
@@ -807,8 +807,8 @@ hdmicec: cec@100b0000 {
clock-names = "hdmicec";
samsung,syscon-phandle = <&pmu_system_controller>;
hdmi-phandle = <&hdmi>;
- pinctrl-names = "default";
pinctrl-0 = <&hdmi_cec>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -943,8 +943,8 @@ sysmmu_mfc_l: sysmmu@13620000 {
reg = <0x13620000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 5>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_MFCL>, <&clock CLK_MFC>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_mfc>;
#iommu-cells = <0>;
};
@@ -954,8 +954,8 @@ sysmmu_mfc_r: sysmmu@13630000 {
reg = <0x13630000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 6>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_MFCR>, <&clock CLK_MFC>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_mfc>;
#iommu-cells = <0>;
};
@@ -965,8 +965,8 @@ sysmmu_tv: sysmmu@12e20000 {
reg = <0x12e20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 4>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_TV>, <&clock CLK_MIXER>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_tv>;
#iommu-cells = <0>;
};
@@ -976,8 +976,8 @@ sysmmu_fimc0: sysmmu@11a20000 {
reg = <0x11a20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 2>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC0>, <&clock CLK_FIMC0>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -987,8 +987,8 @@ sysmmu_fimc1: sysmmu@11a30000 {
reg = <0x11a30000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 3>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC1>, <&clock CLK_FIMC1>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -998,8 +998,8 @@ sysmmu_fimc2: sysmmu@11a40000 {
reg = <0x11a40000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 4>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC2>, <&clock CLK_FIMC2>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1009,8 +1009,8 @@ sysmmu_fimc3: sysmmu@11a50000 {
reg = <0x11a50000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 5>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC3>, <&clock CLK_FIMC3>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1020,8 +1020,8 @@ sysmmu_jpeg: sysmmu@11a60000 {
reg = <0x11a60000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 6>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_JPEG>, <&clock CLK_JPEG>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1031,9 +1031,9 @@ sysmmu_rotator: sysmmu@12a30000 {
reg = <0x12a30000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 0>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_ROTATOR>,
<&clock CLK_ROTATOR>;
+ clock-names = "sysmmu", "master";
#iommu-cells = <0>;
};
@@ -1042,8 +1042,8 @@ sysmmu_fimd0: sysmmu@11e20000 {
reg = <0x11e20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 2>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMD0>, <&clock CLK_FIMD0>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_lcd0>;
#iommu-cells = <0>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 03/17] ARM: dts: samsung: exynos4: sort all properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-04 20:15 ` [PATCH 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-04 20:15 ` [PATCH 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
` (13 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Fixes dt-check-style in strict mode property-order warnings like:
samsung/exynos4.dtsi:226: [property-order] property 'iommus' out of canonical order (should sort before 'samsung,sysreg')
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4.dtsi | 89 +++++++++++++++++-----------------
1 file changed, 45 insertions(+), 44 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
index f69b01423ae0..43cbbedbfe41 100644
--- a/arch/arm/boot/dts/samsung/exynos4.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
@@ -60,9 +60,9 @@ pmu: pmu {
soc: soc {
compatible = "simple-bus";
+ ranges;
#address-cells = <1>;
#size-cells = <1>;
- ranges;
clock_audss: clock-controller@3810000 {
compatible = "samsung,exynos4210-audss-clock";
@@ -86,8 +86,8 @@ i2s0: i2s@3830000 {
clock-output-names = "i2s_cdclk0";
dmas = <&pdma0 12>, <&pdma0 11>, <&pdma0 10>;
dma-names = "tx", "rx", "tx-sec";
- samsung,idma-addr = <0x03000000>;
#sound-dai-cells = <1>;
+ samsung,idma-addr = <0x03000000>;
status = "disabled";
};
@@ -159,16 +159,16 @@ pd_gps_alive: power-domain@10023d00 {
gic: interrupt-controller@10490000 {
compatible = "arm,cortex-a9-gic";
+ reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
#interrupt-cells = <3>;
interrupt-controller;
- reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
};
combiner: interrupt-controller@10440000 {
compatible = "samsung,exynos4210-combiner";
+ reg = <0x10440000 0x1000>;
#interrupt-cells = <2>;
interrupt-controller;
- reg = <0x10440000 0x1000>;
};
sys_reg: syscon@10010000 {
@@ -198,22 +198,23 @@ dsi_0: dsi@11c80000 {
phy-names = "dsim";
clocks = <&clock CLK_DSIM0>, <&clock CLK_SCLK_MIPI0>;
clock-names = "bus_clk", "sclk_mipi";
-
- status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+
+ status = "disabled";
};
camera: camera@11800000 {
compatible = "samsung,fimc";
ranges = <0x0 0x11800000 0xa0000>;
- status = "disabled";
#address-cells = <1>;
#size-cells = <1>;
#clock-cells = <1>;
clock-output-names = "cam_a_clkout", "cam_b_clkout";
+ status = "disabled";
+
fimc_0: fimc@0 {
compatible = "samsung,exynos4210-fimc";
reg = <0x0 0x1000>;
@@ -221,9 +222,9 @@ fimc_0: fimc@0 {
clocks = <&clock CLK_FIMC0>,
<&clock CLK_SCLK_FIMC0>;
clock-names = "fimc", "sclk_fimc";
+ iommus = <&sysmmu_fimc0>;
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
- iommus = <&sysmmu_fimc0>;
status = "disabled";
};
@@ -235,9 +236,9 @@ fimc_1: fimc@10000 {
clocks = <&clock CLK_FIMC1>,
<&clock CLK_SCLK_FIMC1>;
clock-names = "fimc", "sclk_fimc";
+ iommus = <&sysmmu_fimc1>;
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
- iommus = <&sysmmu_fimc1>;
status = "disabled";
};
@@ -249,9 +250,9 @@ fimc_2: fimc@20000 {
clocks = <&clock CLK_FIMC2>,
<&clock CLK_SCLK_FIMC2>;
clock-names = "fimc", "sclk_fimc";
+ iommus = <&sysmmu_fimc2>;
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
- iommus = <&sysmmu_fimc2>;
status = "disabled";
};
@@ -263,9 +264,9 @@ fimc_3: fimc@30000 {
clocks = <&clock CLK_FIMC3>,
<&clock CLK_SCLK_FIMC3>;
clock-names = "fimc", "sclk_fimc";
+ iommus = <&sysmmu_fimc3>;
power-domains = <&pd_cam>;
samsung,sysreg = <&sys_reg>;
- iommus = <&sysmmu_fimc3>;
status = "disabled";
};
@@ -281,10 +282,10 @@ csis_0: csis@80000 {
power-domains = <&pd_cam>;
phys = <&mipi_phy 0>;
phy-names = "csis";
-
- status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+
+ status = "disabled";
};
csis_1: csis@90000 {
@@ -298,10 +299,10 @@ csis_1: csis@90000 {
power-domains = <&pd_cam>;
phys = <&mipi_phy 2>;
phy-names = "csis";
-
- status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+
+ status = "disabled";
};
};
@@ -370,10 +371,10 @@ sdhci_3: mmc@12540000 {
exynos_usbphy: usb-phy@125b0000 {
compatible = "samsung,exynos4210-usb2-phy";
reg = <0x125b0000 0x100>;
- samsung,pmureg-phandle = <&pmu_system_controller>;
clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>;
clock-names = "phy", "ref";
#phy-cells = <1>;
+ samsung,pmureg-phandle = <&pmu_system_controller>;
status = "disabled";
};
@@ -396,10 +397,10 @@ ehci: usb@12580000 {
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
-
- status = "disabled";
phys = <&exynos_usbphy 1>, <&exynos_usbphy 2>, <&exynos_usbphy 3>;
phy-names = "host", "hsic0", "hsic1";
+
+ status = "disabled";
};
ohci: usb@12590000 {
@@ -408,10 +409,10 @@ ohci: usb@12590000 {
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
-
- status = "disabled";
phys = <&exynos_usbphy 1>;
phy-names = "host";
+
+ status = "disabled";
};
gpu: gpu@13000000 {
@@ -517,10 +518,10 @@ serial_3: serial@13830000 {
};
i2c_0: i2c@13860000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x13860000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C0>;
clock-names = "i2c";
@@ -531,10 +532,10 @@ i2c_0: i2c@13860000 {
};
i2c_1: i2c@13870000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x13870000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C1>;
clock-names = "i2c";
@@ -545,10 +546,10 @@ i2c_1: i2c@13870000 {
};
i2c_2: i2c@13880000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x13880000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C2>;
clock-names = "i2c";
@@ -559,10 +560,10 @@ i2c_2: i2c@13880000 {
};
i2c_3: i2c@13890000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x13890000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C3>;
clock-names = "i2c";
@@ -573,10 +574,10 @@ i2c_3: i2c@13890000 {
};
i2c_4: i2c@138a0000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x138a0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C4>;
clock-names = "i2c";
@@ -587,10 +588,10 @@ i2c_4: i2c@138a0000 {
};
i2c_5: i2c@138b0000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x138b0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C5>;
clock-names = "i2c";
@@ -601,10 +602,10 @@ i2c_5: i2c@138b0000 {
};
i2c_6: i2c@138c0000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x138c0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C6>;
clock-names = "i2c";
@@ -615,10 +616,10 @@ i2c_6: i2c@138c0000 {
};
i2c_7: i2c@138d0000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-i2c";
reg = <0x138d0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C7>;
clock-names = "i2c";
@@ -629,10 +630,10 @@ i2c_7: i2c@138d0000 {
};
i2c_8: i2c@138e0000 {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "samsung,s3c2440-hdmiphy-i2c";
reg = <0x138e0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C_HDMI>;
clock-names = "i2c";
@@ -740,8 +741,8 @@ mdma1: dma-controller@12850000 {
fimd: fimd@11c00000 {
compatible = "samsung,exynos4210-fimd";
- interrupt-parent = <&combiner>;
reg = <0x11c00000 0x20000>;
+ interrupt-parent = <&combiner>;
interrupts = <11 0>, <11 1>, <11 2>;
interrupt-names = "fifo", "vsync", "lcd_sys";
clocks = <&clock CLK_SCLK_FIMD0>, <&clock CLK_FIMD0>;
@@ -754,12 +755,12 @@ fimd: fimd@11c00000 {
};
tmu: tmu@100c0000 {
- interrupt-parent = <&combiner>;
reg = <0x100c0000 0x100>;
+ interrupt-parent = <&combiner>;
interrupts = <2 4>;
+ #thermal-sensor-cells = <0>;
status = "disabled";
- #thermal-sensor-cells = <0>;
};
jpeg_codec: jpeg-codec@11840000 {
@@ -793,8 +794,8 @@ hdmi: hdmi@12d00000 {
"sclk_hdmiphy", "mout_hdmi";
phy = <&hdmi_i2c_phy>;
power-domains = <&pd_tv>;
- samsung,syscon-phandle = <&pmu_system_controller>;
#sound-dai-cells = <0>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
status = "disabled";
};
@@ -805,18 +806,18 @@ hdmicec: cec@100b0000 {
interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_HDMI_CEC>;
clock-names = "hdmicec";
- samsung,syscon-phandle = <&pmu_system_controller>;
hdmi-phandle = <&hdmi>;
pinctrl-0 = <&hdmi_cec>;
pinctrl-names = "default";
+ samsung,syscon-phandle = <&pmu_system_controller>;
status = "disabled";
};
mixer: mixer@12c10000 {
compatible = "samsung,exynos4210-mixer";
- interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
reg = <0x12c10000 0x2100>, <0x12c00000 0x300>;
+ interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd_tv>;
iommus = <&sysmmu_tv>;
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (2 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
` (12 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Add missing indentation level, sort child nodes alphabetically and add
newlines before every child. Fixed partially with the help of
dtfmt (Devicetree Source formatter).
Fixes warnings from dt-check-style in strict mode like:
samsung/exynos4-cpu-thermal.dtsi:32: [required-blank-lines] child node must be preceded by a blank line
samsung/exynos4-cpu-thermal.dtsi:38: [child-name-order] child node 'cooling-maps' out of name order
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4-cpu-thermal.dtsi | 72 ++++++++++++----------
1 file changed, 39 insertions(+), 33 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4-cpu-thermal.dtsi b/arch/arm/boot/dts/samsung/exynos4-cpu-thermal.dtsi
index 27a1a8952665..48bac2fe6172 100644
--- a/arch/arm/boot/dts/samsung/exynos4-cpu-thermal.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4-cpu-thermal.dtsi
@@ -8,41 +8,47 @@
#include <dt-bindings/thermal/thermal.h>
/ {
-thermal-zones {
- cpu_thermal: cpu-thermal {
- thermal-sensors = <&tmu>;
- polling-delay-passive = <0>;
- polling-delay = <0>;
- trips {
- cpu_alert0: cpu-alert-0 {
- temperature = <70000>; /* millicelsius */
- hysteresis = <10000>; /* millicelsius */
- type = "active";
- };
- cpu_alert1: cpu-alert-1 {
- temperature = <95000>; /* millicelsius */
- hysteresis = <10000>; /* millicelsius */
- type = "active";
- };
- cpu_alert2: cpu-alert-2 {
- temperature = <110000>; /* millicelsius */
- hysteresis = <10000>; /* millicelsius */
- type = "active";
- };
- cpu_crit0: cpu-crit-0 {
- temperature = <120000>; /* millicelsius */
- hysteresis = <0>; /* millicelsius */
- type = "critical";
- };
- };
- cooling-maps {
- map0 {
- trip = <&cpu_alert0>;
+ thermal-zones {
+ cpu_thermal: cpu-thermal {
+ thermal-sensors = <&tmu>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert0>;
+ };
+
+ map1 {
+ trip = <&cpu_alert1>;
+ };
};
- map1 {
- trip = <&cpu_alert1>;
+
+ trips {
+ cpu_alert0: cpu-alert-0 {
+ temperature = <70000>; /* millicelsius */
+ hysteresis = <10000>; /* millicelsius */
+ type = "active";
+ };
+
+ cpu_alert1: cpu-alert-1 {
+ temperature = <95000>; /* millicelsius */
+ hysteresis = <10000>; /* millicelsius */
+ type = "active";
+ };
+
+ cpu_alert2: cpu-alert-2 {
+ temperature = <110000>; /* millicelsius */
+ hysteresis = <10000>; /* millicelsius */
+ type = "active";
+ };
+
+ cpu_crit0: cpu-crit-0 {
+ temperature = <120000>; /* millicelsius */
+ hysteresis = <0>; /* millicelsius */
+ type = "critical";
+ };
};
};
};
};
-};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 05/17] ARM: dts: samsung: exynos4210: sort nodes by address
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (3 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
` (11 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Nodes should be sorted by address, or in the absence of an address,
alphabetically. Sort all nodes except the pinctrl ones, to keep them
grouped and in order by alias numbering.
Fixes child-address-order warnings from dt-check-style in strict mode
like:
samsung/exynos4210.dtsi:369: [child-address-order] child node @12220000 out of address order
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 77 ++++++++++++++++---------------
1 file changed, 39 insertions(+), 38 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 510e8665d1a2..66b1a55f703d 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -269,15 +269,10 @@ pd_lcd1: power-domain@10023ca0 {
label = "LCD1";
};
- l2c: cache-controller@10502000 {
- compatible = "arm,pl310-cache";
- reg = <0x10502000 0x1000>;
- cache-unified;
- cache-level = <2>;
- prefetch-data = <1>;
- prefetch-instr = <1>;
- arm,tag-latency = <2 2 1>;
- arm,data-latency = <2 2 1>;
+ clock: clock-controller@10030000 {
+ compatible = "samsung,exynos4210-clock";
+ reg = <0x10030000 0x20000>;
+ #clock-cells = <1>;
};
mct: timer@10050000 {
@@ -301,10 +296,22 @@ watchdog: watchdog@10060000 {
clock-names = "watchdog";
};
- clock: clock-controller@10030000 {
- compatible = "samsung,exynos4210-clock";
- reg = <0x10030000 0x20000>;
- #clock-cells = <1>;
+ l2c: cache-controller@10502000 {
+ compatible = "arm,pl310-cache";
+ reg = <0x10502000 0x1000>;
+ cache-unified;
+ cache-level = <2>;
+ prefetch-data = <1>;
+ prefetch-instr = <1>;
+ arm,tag-latency = <2 2 1>;
+ arm,data-latency = <2 2 1>;
+ };
+
+ ppmu_acp: ppmu@10ae0000 {
+ compatible = "samsung,exynos-ppmu";
+ reg = <0x10ae0000 0x2000>;
+
+ status = "disabled";
};
pinctrl_0: pinctrl@11400000 {
@@ -330,20 +337,15 @@ pinctrl_2: pinctrl@3860000 {
reg = <0x03860000 0x1000>;
};
- g2d: g2d@12800000 {
- compatible = "samsung,s5pv210-g2d";
- reg = <0x12800000 0x1000>;
- interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clock CLK_SCLK_FIMG2D>, <&clock CLK_G2D>;
- clock-names = "sclk_fimg2d", "fimg2d";
- power-domains = <&pd_lcd0>;
- iommus = <&sysmmu_g2d>;
- };
-
- ppmu_acp: ppmu@10ae0000 {
- compatible = "samsung,exynos-ppmu";
- reg = <0x10ae0000 0x2000>;
- status = "disabled";
+ sysmmu_fimd1: sysmmu@12220000 {
+ compatible = "samsung,exynos-sysmmu";
+ interrupt-parent = <&combiner>;
+ reg = <0x12220000 0x1000>;
+ interrupts = <5 3>;
+ clock-names = "sysmmu", "master";
+ clocks = <&clock CLK_SMMU_FIMD1>, <&clock CLK_FIMD1>;
+ power-domains = <&pd_lcd1>;
+ #iommu-cells = <0>;
};
ppmu_lcd1: ppmu@12240000 {
@@ -354,6 +356,16 @@ ppmu_lcd1: ppmu@12240000 {
status = "disabled";
};
+ g2d: g2d@12800000 {
+ compatible = "samsung,s5pv210-g2d";
+ reg = <0x12800000 0x1000>;
+ interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clock CLK_SCLK_FIMG2D>, <&clock CLK_G2D>;
+ clock-names = "sclk_fimg2d", "fimg2d";
+ power-domains = <&pd_lcd0>;
+ iommus = <&sysmmu_g2d>;
+ };
+
sysmmu_g2d: sysmmu@12a20000 {
compatible = "samsung,exynos-sysmmu";
reg = <0x12a20000 0x1000>;
@@ -364,17 +376,6 @@ sysmmu_g2d: sysmmu@12a20000 {
power-domains = <&pd_lcd0>;
#iommu-cells = <0>;
};
-
- sysmmu_fimd1: sysmmu@12220000 {
- compatible = "samsung,exynos-sysmmu";
- interrupt-parent = <&combiner>;
- reg = <0x12220000 0x1000>;
- interrupts = <5 3>;
- clock-names = "sysmmu", "master";
- clocks = <&clock CLK_SMMU_FIMD1>, <&clock CLK_FIMD1>;
- power-domains = <&pd_lcd1>;
- #iommu-cells = <0>;
- };
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (4 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
` (10 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
For better readability it is preferred to have an empty line before
the status property, as well as before every child node. Empty lines
do not really help at start of children nodes though. Add or remove
empty lines where applicable.
dt-check-style in strict mode reports the issues like:
samsung/exynos4210.dtsi:36: [required-blank-lines] "status" must be preceded by a blank line
samsung/exynos4210.dtsi:45: [required-blank-lines] child node must be preceded by a blank line
Fixed partially with the help of dtfmt (Devicetree Source formatter).
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 66b1a55f703d..66f35c4ae6b1 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -33,6 +33,7 @@ bus_acp: bus-acp {
clocks = <&clock CLK_DIV_ACP>;
clock-names = "bus";
operating-points-v2 = <&bus_acp_opp_table>;
+
status = "disabled";
bus_acp_opp_table: opp-table {
@@ -42,9 +43,11 @@ bus_acp_opp_table: opp-table {
opp-134000000 {
opp-hz = /bits/ 64 <134000000>;
};
+
opp-160000000 {
opp-hz = /bits/ 64 <160000000>;
};
+
opp-200000000 {
opp-hz = /bits/ 64 <200000000>;
};
@@ -56,6 +59,7 @@ bus_display: bus-display {
clocks = <&clock CLK_ACLK160>;
clock-names = "bus";
operating-points-v2 = <&bus_display_opp_table>;
+
status = "disabled";
bus_display_opp_table: opp-table {
@@ -65,9 +69,11 @@ bus_display_opp_table: opp-table {
opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
};
+
opp-134000000 {
opp-hz = /bits/ 64 <134000000>;
};
+
opp-160000000 {
opp-hz = /bits/ 64 <160000000>;
};
@@ -79,6 +85,7 @@ bus_dmc: bus-dmc {
clocks = <&clock CLK_DIV_DMC>;
clock-names = "bus";
operating-points-v2 = <&bus_dmc_opp_table>;
+
status = "disabled";
bus_dmc_opp_table: opp-table {
@@ -89,10 +96,12 @@ opp-134000000 {
opp-hz = /bits/ 64 <134000000>;
opp-microvolt = <1025000>;
};
+
opp-267000000 {
opp-hz = /bits/ 64 <267000000>;
opp-microvolt = <1050000>;
};
+
opp-400000000 {
opp-hz = /bits/ 64 <400000000>;
opp-microvolt = <1150000>;
@@ -106,6 +115,7 @@ bus_fsys: bus-fsys {
clocks = <&clock CLK_ACLK133>;
clock-names = "bus";
operating-points-v2 = <&bus_fsys_opp_table>;
+
status = "disabled";
bus_fsys_opp_table: opp-table {
@@ -115,6 +125,7 @@ bus_fsys_opp_table: opp-table {
opp-10000000 {
opp-hz = /bits/ 64 <10000000>;
};
+
opp-134000000 {
opp-hz = /bits/ 64 <134000000>;
};
@@ -126,6 +137,7 @@ bus_lcd0: bus-lcd0 {
clocks = <&clock CLK_ACLK200>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
+
status = "disabled";
};
@@ -134,6 +146,7 @@ bus_leftbus: bus-leftbus {
clocks = <&clock CLK_DIV_GDL>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
+
status = "disabled";
};
@@ -142,6 +155,7 @@ bus_mfc: bus-mfc {
clocks = <&clock CLK_SCLK_MFC>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
+
status = "disabled";
};
@@ -150,6 +164,7 @@ bus_peri: bus-peri {
clocks = <&clock CLK_ACLK100>;
clock-names = "bus";
operating-points-v2 = <&bus_peri_opp_table>;
+
status = "disabled";
bus_peri_opp_table: opp-table {
@@ -159,6 +174,7 @@ bus_peri_opp_table: opp-table {
opp-5000000 {
opp-hz = /bits/ 64 <5000000>;
};
+
opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
};
@@ -170,6 +186,7 @@ bus_rightbus: bus-rightbus {
clocks = <&clock CLK_DIV_GDR>;
clock-names = "bus";
operating-points-v2 = <&bus_leftbus_opp_table>;
+
status = "disabled";
};
@@ -182,6 +199,7 @@ cluster0 {
core0 {
cpu = <&cpu0>;
};
+
core1 {
cpu = <&cpu1>;
};
@@ -234,9 +252,11 @@ bus_leftbus_opp_table: opp-table-0 {
opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
};
+
opp-160000000 {
opp-hz = /bits/ 64 <160000000>;
};
+
opp-200000000 {
opp-hz = /bits/ 64 <200000000>;
opp-suspend;
@@ -353,6 +373,7 @@ ppmu_lcd1: ppmu@12240000 {
reg = <0x12240000 0x2000>;
clocks = <&clock CLK_PPMULCD1>;
clock-names = "ppmu";
+
status = "disabled";
};
@@ -489,6 +510,7 @@ opp-160000000 {
opp-hz = /bits/ 64 <160000000>;
opp-microvolt = <950000>;
};
+
opp-267000000 {
opp-hz = /bits/ 64 <267000000>;
opp-microvolt = <1050000>;
@@ -511,6 +533,7 @@ &mixer {
&pmu {
interrupts = <2 2>, <3 2>;
interrupt-affinity = <&cpu0>, <&cpu1>;
+
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 07/17] ARM: dts: samsung: exynos4210: sort all properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (5 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
` (9 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Sort properties according to the preferred style for increased
readability.
Fixes dt-check-style property-order warnings in strict mode like:
samsung/exynos4210.dtsi:393: [property-order] property 'reg' out of canonical order (should sort before 'interrupt-parent')
samsung/exynos4210.dtsi:440: [property-order] property 'interrupts' out of canonical order (should sort before 'samsung,combiner-nr')
samsung/exynos4.dtsi:745: [property-order] property 'interrupt-names' must be placed after 'interrupts'
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 66f35c4ae6b1..d37ac0c97dbc 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -267,9 +267,9 @@ soc: soc {
sysram: sram@2020000 {
compatible = "mmio-sram";
reg = <0x02020000 0x20000>;
+ ranges = <0 0x02020000 0x20000>;
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0 0x02020000 0x20000>;
smp-sram@0 {
compatible = "samsung,exynos4210-sysram";
@@ -359,11 +359,11 @@ pinctrl_2: pinctrl@3860000 {
sysmmu_fimd1: sysmmu@12220000 {
compatible = "samsung,exynos-sysmmu";
- interrupt-parent = <&combiner>;
reg = <0x12220000 0x1000>;
+ interrupt-parent = <&combiner>;
interrupts = <5 3>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMD1>, <&clock CLK_FIMD1>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_lcd1>;
#iommu-cells = <0>;
};
@@ -392,8 +392,8 @@ sysmmu_g2d: sysmmu@12a20000 {
reg = <0x12a20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 7>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_G2D>, <&clock CLK_G2D>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_lcd0>;
#iommu-cells = <0>;
};
@@ -436,7 +436,6 @@ &camera {
};
&combiner {
- samsung,combiner-nr = <16>;
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
@@ -453,6 +452,7 @@ &combiner {
<GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ samsung,combiner-nr = <16>;
};
&fimc_0 {
@@ -523,11 +523,11 @@ &mdma1 {
};
&mixer {
- clock-names = "mixer", "hdmi", "sclk_hdmi", "vp", "mout_mixer",
- "sclk_mixer";
clocks = <&clock CLK_MIXER>, <&clock CLK_HDMI>,
<&clock CLK_SCLK_HDMI>, <&clock CLK_VP>,
<&clock CLK_MOUT_MIXER>, <&clock CLK_SCLK_MIXER>;
+ clock-names = "mixer", "hdmi", "sclk_hdmi", "vp", "mout_mixer",
+ "sclk_mixer";
};
&pmu {
@@ -538,11 +538,11 @@ &pmu {
};
&pmu_system_controller {
- clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
- "clkout4", "clkout8", "clkout9";
clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
<&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
<&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, <&clock CLK_XUSBXTI>;
+ clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
+ "clkout4", "clkout8", "clkout9";
#clock-cells = <1>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (6 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:25 ` sashiko-bot
2026-10-04 20:16 ` [PATCH 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
` (8 subsequent siblings)
16 siblings, 1 reply; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
operating-points (v1) is deprecated, switch to v2 instead. This fixes
continuation-lines warnings from dt-check-style at the same time,
i.e. warnings like:
samsung/exynos4210.dtsi:218: [continuation-alignment] continuation should align to column 45 (to the value under <)
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 64 +++++++++++++++++++++----------
1 file changed, 44 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index d37ac0c97dbc..4981bbb7cf31 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -212,16 +212,8 @@ cpu0: cpu@900 {
reg = <0x900>;
clocks = <&clock CLK_ARM_CLK>;
clock-names = "cpu";
- clock-latency = <160000>;
-
- operating-points = <
- 1200000 1250000
- 1000000 1150000
- 800000 1075000
- 500000 975000
- 400000 975000
- 200000 950000
- >;
+
+ operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>; /* min followed by max */
};
@@ -231,16 +223,8 @@ cpu1: cpu@901 {
reg = <0x901>;
clocks = <&clock CLK_ARM_CLK>;
clock-names = "cpu";
- clock-latency = <160000>;
-
- operating-points = <
- 1200000 1250000
- 1000000 1150000
- 800000 1075000
- 500000 975000
- 400000 975000
- 200000 950000
- >;
+
+ operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>; /* min followed by max */
};
};
@@ -263,6 +247,46 @@ opp-200000000 {
};
};
+ cpu_opp_table: opp-table-1 {
+ compatible = "operating-points-v2";
+
+ opp-200000000 {
+ opp-hz = /bits/ 64 <200000000>;
+ opp-microvolt = <950000>;
+ clock-latency-ns = <160000>;
+ };
+
+ opp-400000000 {
+ opp-hz = /bits/ 64 <400000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <160000>;
+ };
+
+ opp-500000000 {
+ opp-hz = /bits/ 64 <500000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <160000>;
+ };
+
+ opp-800000000 {
+ opp-hz = /bits/ 64 <800000000>;
+ opp-microvolt = <1075000>;
+ clock-latency-ns = <160000>;
+ };
+
+ opp-1000000000 {
+ opp-hz = /bits/ 64 <1000000000>;
+ opp-microvolt = <1150000>;
+ clock-latency-ns = <160000>;
+ };
+
+ opp-1200000000 {
+ opp-hz = /bits/ 64 <1200000000>;
+ opp-microvolt = <1250000>;
+ clock-latency-ns = <160000>;
+ };
+ };
+
soc: soc {
sysram: sram@2020000 {
compatible = "mmio-sram";
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2
2026-10-04 20:16 ` [PATCH 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
@ 2026-10-04 20:25 ` sashiko-bot
0 siblings, 0 replies; 19+ messages in thread
From: sashiko-bot @ 2026-10-04 20:25 UTC (permalink / raw)
To: Henrik Grimler; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: missing opp-shared property causes conflicting cpufreq policies
--
commit fcba4068b9646df5bfbec161d06e3521379f32ed
Author: Henrik Grimler <henrik.grimler@axis.com>
ARM: dts: samsung: exynos4210: use operating-points-v2
This commit updates the exynos4210 device tree to use operating-points-v2
instead of the deprecated operating-points (v1) format. This resolves dt-check
style warnings about continuation-alignment.
> diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
> index d37ac0c97dbcf..4981bbb7cf311 100644
> --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
[ ... ]
> @@ -263,6 +247,46 @@ opp-200000000 {
> };
> };
>
> + cpu_opp_table: opp-table-1 {
> + compatible = "operating-points-v2";
> +
[Severity: High]
Does this new node need the opp-shared property?
CPU0 and CPU1 on this device share the CLK_ARM_CLK clock. When migrating to
operating-points-v2, the OPP framework relies on the opp-shared property to
know whether CPUs share the same clock line and therefore need a unified
cpufreq policy.
Without this property, the framework assumes the CPUs do not share the table:
drivers/opp/of.c:dev_pm_opp_of_get_sharing_cpus() {
...
/* OPPs are shared ? */
if (!of_property_read_bool(np, "opp-shared"))
return 0;
...
}
Because the legacy v1 fallback logic is bypassed for v2 nodes, the cpufreq
driver will create independent policies and governors for CPU0 and CPU1.
Since the cores share the same physical clock line, will this lead to the
independent governors issuing conflicting clk_set_rate requests, potentially
causing chaotic frequency switching and instability?
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-microvolt = <950000>;
> + clock-latency-ns = <160000>;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-exynos-arm-cleanup-v1-0-45e435353c56@axis.com?part=8
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 09/17] ARM: dts: samsung: exynos4210: align all multiline properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (7 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
` (7 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Properties that span multiple lines should be aligned with " or
<. Update the nodes where applicable.
Fixes warnings from dt-check-style when running in strict mode, like:
samsung/exynos4210.dtsi:543: [continuation-alignment] continuation should align to column 18 (to < or ")
samsung/exynos4210.dtsi:545: [continuation-alignment] continuation should align to column 23 (to < or ")
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 4981bbb7cf31..acb84e34732f 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -563,10 +563,10 @@ &pmu {
&pmu_system_controller {
clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
- <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
- <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, <&clock CLK_XUSBXTI>;
+ <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
+ <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, <&clock CLK_XUSBXTI>;
clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
- "clkout4", "clkout8", "clkout9";
+ "clkout4", "clkout8", "clkout9";
#clock-cells = <1>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (8 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
` (6 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
A combination of tabs and spaces should be used to ensure elements are
aligned. Fix all properties where applicable.
Fixes warnings from dt-style-checker in strict mode, like:
samsung/exynos4210-pinctrl.dtsi:252: [continuation-alignment] continuation should align to column 32 (to < or ")
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-pinctrl.dtsi | 42 +++++++++++------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/samsung/exynos4210-pinctrl.dtsi
index 70d268f9fcb1..01d30141d9bf 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-pinctrl.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210-pinctrl.dtsi
@@ -249,7 +249,7 @@ i2c5_bus: i2c5-bus-pins {
i2s1_bus: i2s1-bus-pins {
samsung,pins = "gpc0-0", "gpc0-1", "gpc0-2", "gpc0-3",
- "gpc0-4";
+ "gpc0-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -257,7 +257,7 @@ i2s1_bus: i2s1-bus-pins {
pcm1_bus: pcm1-bus-pins {
samsung,pins = "gpc0-0", "gpc0-1", "gpc0-2", "gpc0-3",
- "gpc0-4";
+ "gpc0-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -265,7 +265,7 @@ pcm1_bus: pcm1-bus-pins {
ac97_bus: ac97-bus-pins {
samsung,pins = "gpc0-0", "gpc0-1", "gpc0-2", "gpc0-3",
- "gpc0-4";
+ "gpc0-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_4>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -273,7 +273,7 @@ ac97_bus: ac97-bus-pins {
i2s2_bus: i2s2-bus-pins {
samsung,pins = "gpc1-0", "gpc1-1", "gpc1-2", "gpc1-3",
- "gpc1-4";
+ "gpc1-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -281,7 +281,7 @@ i2s2_bus: i2s2-bus-pins {
pcm2_bus: pcm2-bus-pins {
samsung,pins = "gpc1-0", "gpc1-1", "gpc1-2", "gpc1-3",
- "gpc1-4";
+ "gpc1-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -387,9 +387,9 @@ lcd_clk: lcd-clk-pins {
lcd_data16: lcd-data-width16-pins {
samsung,pins = "gpf0-7", "gpf1-0", "gpf1-1", "gpf1-2",
- "gpf1-3", "gpf1-6", "gpf1-7", "gpf2-0",
- "gpf2-1", "gpf2-2", "gpf2-3", "gpf2-7",
- "gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
+ "gpf1-3", "gpf1-6", "gpf1-7", "gpf2-0",
+ "gpf2-1", "gpf2-2", "gpf2-3", "gpf2-7",
+ "gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -397,10 +397,10 @@ lcd_data16: lcd-data-width16-pins {
lcd_data18: lcd-data-width18-pins {
samsung,pins = "gpf0-6", "gpf0-7", "gpf1-0", "gpf1-1",
- "gpf1-2", "gpf1-3", "gpf1-6", "gpf1-7",
- "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
- "gpf2-6", "gpf2-7", "gpf3-0", "gpf3-1",
- "gpf3-2", "gpf3-3";
+ "gpf1-2", "gpf1-3", "gpf1-6", "gpf1-7",
+ "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
+ "gpf2-6", "gpf2-7", "gpf3-0", "gpf3-1",
+ "gpf3-2", "gpf3-3";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -408,11 +408,11 @@ lcd_data18: lcd-data-width18-pins {
lcd_data24: lcd-data-width24-pins {
samsung,pins = "gpf0-4", "gpf0-5", "gpf0-6", "gpf0-7",
- "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3",
- "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7",
- "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
- "gpf2-4", "gpf2-5", "gpf2-6", "gpf2-7",
- "gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
+ "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3",
+ "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7",
+ "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3",
+ "gpf2-4", "gpf2-5", "gpf2-6", "gpf2-7",
+ "gpf3-0", "gpf3-1", "gpf3-2", "gpf3-3";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -810,8 +810,8 @@ eint31: ext-int31-pins {
cam_port_a_io: cam-port-a-io-pins {
samsung,pins = "gpj0-0", "gpj0-1", "gpj0-2", "gpj0-3",
- "gpj0-4", "gpj0-5", "gpj0-6", "gpj0-7",
- "gpj1-0", "gpj1-1", "gpj1-2", "gpj1-4";
+ "gpj0-4", "gpj0-5", "gpj0-6", "gpj0-7",
+ "gpj1-0", "gpj1-1", "gpj1-2", "gpj1-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -847,7 +847,7 @@ gpz: gpz-gpio-bank {
i2s0_bus: i2s0-bus-pins {
samsung,pins = "gpz-0", "gpz-1", "gpz-2", "gpz-3",
- "gpz-4", "gpz-5", "gpz-6";
+ "gpz-4", "gpz-5", "gpz-6";
samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
@@ -855,7 +855,7 @@ i2s0_bus: i2s0-bus-pins {
pcm0_bus: pcm0-bus-pins {
samsung,pins = "gpz-0", "gpz-1", "gpz-2", "gpz-3",
- "gpz-4";
+ "gpz-4";
samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (9 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
` (5 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
like:
samsung/exynos4210-i9100.dts:275: [child-name-order] child node 'pmic-ap-clk' out of name order
samsung/exynos4210-i9100.dts:287: [required-blank-lines] "status" must be preceded by a blank line
samsung/exynos4210-i9100.dts:288: [property-order] property 'assigned-clocks' out of canonical order (should sort before 'status')
Also remove double spaces in max8997 buck dvs voltages list.
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 125 +++++++++++++------------
1 file changed, 65 insertions(+), 60 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
index b9a31714381c..85e4d334a5e6 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
@@ -97,31 +97,31 @@ gpio-keys {
key-vol-down {
gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_VOLUMEDOWN>;
label = "volume down";
debounce-interval = <10>;
+ linux,code = <KEY_VOLUMEDOWN>;
};
key-vol-up {
gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_VOLUMEUP>;
label = "volume up";
debounce-interval = <10>;
+ linux,code = <KEY_VOLUMEUP>;
};
key-power {
gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_POWER>;
label = "power";
debounce-interval = <10>;
wakeup-source;
+ linux,code = <KEY_POWER>;
};
key-ok {
gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_OK>;
label = "ok";
debounce-interval = <10>;
+ linux,code = <KEY_OK>;
};
};
@@ -141,6 +141,7 @@ i2c_max17042_fuel: i2c-9 {
battery@36 {
compatible = "maxim,max17042";
+ reg = <0x36>;
interrupt-parent = <&gpx2>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
@@ -148,7 +149,6 @@ battery@36 {
pinctrl-0 = <&max17042_fuel_irq>;
pinctrl-names = "default";
- reg = <0x36>;
maxim,over-heat-temp = <700>;
maxim,over-volt = <4500>;
};
@@ -284,21 +284,24 @@ pmic_ap_clk: pmic-ap-clk {
&camera {
pinctrl-0 = <&cam_port_a_clk_active>;
pinctrl-names = "default";
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_CAM0>, <&clock CLK_MOUT_CAM1>;
assigned-clock-parents = <&clock CLK_XUSBXTI>, <&clock CLK_XUSBXTI>;
+
+ status = "okay";
};
&csis_1 {
- status = "okay";
vddcore-supply = <&vusb_reg>;
vddio-supply = <&vmipi_reg>;
clock-frequency = <160000000>;
#address-cells = <1>;
#size-cells = <0>;
+ status = "okay";
+
port@4 {
reg = <4>;
+
csis1_ep: endpoint {
remote-endpoint = <&s5k5bafx_ep>;
data-lanes = <1>;
@@ -317,6 +320,7 @@ map0 {
/* Corresponds to 800MHz */
cooling-device = <&cpu0 2 2>;
};
+
map1 {
/* Corresponds to 200MHz */
cooling-device = <&cpu0 4 4>;
@@ -325,62 +329,63 @@ map1 {
};
&ehci {
- status = "okay";
-
phys = <&exynos_usbphy 1>;
phy-names = "host";
-};
-&exynos_usbphy {
status = "okay";
+};
+&exynos_usbphy {
vbus-supply = <&safe1_sreg>;
-};
-&fimc_0 {
status = "okay";
+};
+&fimc_0 {
assigned-clocks = <&clock CLK_MOUT_FIMC0>, <&clock CLK_SCLK_FIMC0>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_1 {
- /* Back camera not implemented */
- status = "disabled";
-
assigned-clocks = <&clock CLK_MOUT_FIMC1>, <&clock CLK_SCLK_FIMC1>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ /* Back camera not implemented */
+ status = "disabled";
};
&fimc_2 {
- status = "okay";
-
assigned-clocks = <&clock CLK_MOUT_FIMC2>, <&clock CLK_SCLK_FIMC2>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_3 {
- /* Back camera not implemented */
- status = "disabled";
-
assigned-clocks = <&clock CLK_MOUT_FIMC3>, <&clock CLK_SCLK_FIMC3>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ /* Back camera not implemented */
+ status = "disabled";
};
&fimd {
- status = "okay";
#address-cells = <1>;
#size-cells = <0>;
+ pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
+ pinctrl-names = "default";
+
samsung,invert-vden;
samsung,invert-vclk;
- pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
- pinctrl-names = "default";
+ status = "okay";
port@3 {
reg = <3>;
@@ -392,26 +397,26 @@ fimd_dpi_ep: endpoint {
};
&gpu {
- status = "okay";
-
mali-supply = <&vg3d_breg>;
-};
-&hsotg {
status = "okay";
+};
+&hsotg {
dr_mode = "otg";
vusb_d-supply = <&vusb_reg>;
vusb_a-supply = <&vusbdac_reg>;
-};
-&i2c_1 {
status = "okay";
+};
+&i2c_1 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
+ status = "okay";
+
lis3dh: accelerometer@19 {
compatible = "st,lis3dh-accel";
reg = <0x19>;
@@ -423,14 +428,14 @@ lis3dh: accelerometer@19 {
};
&i2c_3 {
- status = "okay";
+ pinctrl-0 = <&i2c3_bus>;
+ pinctrl-names = "default";
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
- pinctrl-0 = <&i2c3_bus>;
- pinctrl-names = "default";
+ status = "okay";
touchscreen@4a {
compatible = "atmel,maxtouch";
@@ -442,14 +447,14 @@ touchscreen@4a {
};
&i2c_5 {
- status = "okay";
+ pinctrl-0 = <&i2c5_bus>;
+ pinctrl-names = "default";
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
- pinctrl-0 = <&i2c5_bus>;
- pinctrl-names = "default";
+ status = "okay";
pmic@66 {
compatible = "maxim,max8997-pmic";
@@ -458,6 +463,11 @@ pmic@66 {
interrupts-extended = <&gpx0 7 IRQ_TYPE_NONE>,
<&gpx2 3 IRQ_TYPE_EDGE_FALLING>;
+ pinctrl-0 = <&max8997_irq>, <&otg_gp>, <&usb_sel>;
+ pinctrl-names = "default";
+
+ charger-supply = <&charger_reg>;
+
max8997,pmic-buck1-uses-gpio-dvs;
max8997,pmic-buck2-uses-gpio-dvs;
max8997,pmic-buck5-uses-gpio-dvs;
@@ -475,34 +485,28 @@ pmic@66 {
<1000000>, <950000>;
max8997,pmic-buck2-dvs-voltage = <1100000>, <1000000>,
- <950000>, <900000>,
+ <950000>, <900000>,
<1100000>, <1000000>,
- <950000>, <900000>;
+ <950000>, <900000>;
max8997,pmic-buck5-dvs-voltage = <1200000>, <1200000>,
<1200000>, <1200000>,
<1200000>, <1200000>,
<1200000>, <1200000>;
- pinctrl-0 = <&max8997_irq>, <&otg_gp>, <&usb_sel>;
- pinctrl-names = "default";
-
- charger-supply = <&charger_reg>;
-
regulators {
vadc_reg: LDO1 {
regulator-name = "VADC_3.3V_C210";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-always-on;
-
};
+
valive_reg: LDO2 {
regulator-name = "VALIVE_1.1V_C210";
regulator-min-microvolt = <1100000>;
regulator-max-microvolt = <1100000>;
regulator-always-on;
-
};
vusb_reg: LDO3 {
@@ -706,14 +710,14 @@ CHARGER_TOPOFF {
};
&i2c_7 {
- status = "okay";
+ pinctrl-0 = <&i2c7_bus>;
+ pinctrl-names = "default";
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <400000>;
- pinctrl-0 = <&i2c7_bus>;
- pinctrl-names = "default";
+ status = "okay";
magnetometer@c {
compatible = "asahi-kasei,ak8975";
@@ -724,8 +728,8 @@ magnetometer@c {
};
&pinctrl_0 {
- pinctrl-names = "default";
pinctrl-0 = <&sleep0>;
+ pinctrl-names = "default";
sleep0: sleep-state {
gpa0-0-pin {
@@ -822,36 +826,35 @@ tsp224_irq: tsp224-irq-pins {
};
&rtc {
- status = "okay";
clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
clock-names = "rtc", "rtc_src";
-};
-&sdhci_0 {
status = "okay";
+};
+&sdhci_0 {
bus-width = <8>;
non-removable;
vmmc-supply = <&vemmc_reg>;
pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_bus8>;
pinctrl-names = "default";
-};
-&sdhci_2 {
status = "okay";
+};
+&sdhci_2 {
bus-width = <4>;
cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
vmmc-supply = <&vtf_reg>;
pinctrl-0 = <&sd2_clk>, <&sd2_cmd>, <&sd2_bus4>;
pinctrl-names = "default";
-};
-&sdhci_3 {
status = "okay";
+};
+&sdhci_3 {
#address-cells = <1>;
#size-cells = <0>;
@@ -861,8 +864,10 @@ &sdhci_3 {
mmc-pwrseq = <&wlan_pwrseq>;
vmmc-supply = <&vtf_reg>;
- pinctrl-names = "default";
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
+ pinctrl-names = "default";
+
+ status = "okay";
brcmf: wifi@1 {
compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
@@ -875,13 +880,13 @@ brcmf: wifi@1 {
};
&serial_0 {
- status = "okay";
-
- pinctrl-names = "default";
pinctrl-0 = <&bt_en>, <&bt_res>, <&uart0_data>, <&uart0_fctl>;
+ pinctrl-names = "default";
uart-has-rtscts;
+ status = "okay";
+
bluetooth {
compatible = "brcm,bcm4330-bt";
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 12/17] ARM: dts: samsung: exynos4210-trats: sort properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (10 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
` (4 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
like:
samsung/exynos4210-trats.dts:122: [property-order] property 'label' out of canonical order (should sort before 'linux,code')
samsung/exynos4210-trats.dts:179: [required-blank-lines] "status" must be preceded by a blank line
samsung/exynos4210-trats.dts:183: [property-order] property 'compatible' out of canonical order (should sort before 'reg')
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-trats.dts | 60 ++++++++++++++++----------
1 file changed, 38 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-trats.dts b/arch/arm/boot/dts/samsung/exynos4210-trats.dts
index 20fe148387fc..8d4ebcf86775 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-trats.dts
@@ -96,31 +96,31 @@ gpio-keys {
vol-down-key {
gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
- linux,code = <114>;
label = "volume down";
debounce-interval = <10>;
+ linux,code = <114>;
};
vol-up-key {
gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
- linux,code = <115>;
label = "volume up";
debounce-interval = <10>;
+ linux,code = <115>;
};
power-key {
gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
- linux,code = <116>;
label = "power";
debounce-interval = <10>;
wakeup-source;
+ linux,code = <116>;
};
ok-key {
gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
- linux,code = <352>;
label = "ok";
debounce-interval = <10>;
+ linux,code = <352>;
};
};
@@ -163,6 +163,7 @@ map0 {
/* Corresponds to 800MHz at freq_table */
cooling-device = <&cpu0 2 2>, <&cpu1 2 2>;
};
+
map1 {
/* Corresponds to 200MHz at freq_table */
cooling-device = <&cpu0 4 4>, <&cpu1 4 4>;
@@ -176,11 +177,12 @@ &dsi_0 {
samsung,burst-clock-frequency = <500000000>;
samsung,esc-clock-frequency = <20000000>;
samsung,pll-clock-frequency = <24000000>;
+
status = "okay";
panel@0 {
- reg = <0>;
compatible = "samsung,s6e8aa0";
+ reg = <0>;
vdd3-supply = <&vcclcd_reg>;
vci-supply = <&vlcd_reg>;
reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>;
@@ -209,40 +211,45 @@ timing-0 {
};
&exynos_usbphy {
- status = "okay";
vbus-supply = <&safe1_sreg>;
+
+ status = "okay";
};
&fimc_0 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC0>,
<&clock CLK_SCLK_FIMC0>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_1 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC1>,
<&clock CLK_SCLK_FIMC1>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_2 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC2>,
<&clock CLK_SCLK_FIMC2>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
- assigned-clock-rates = <0>, <160000000>;
+ assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_3 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC3>,
<&clock CLK_SCLK_FIMC3>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimd {
@@ -257,15 +264,18 @@ &hsotg {
vusb_d-supply = <&vusb_reg>;
vusb_a-supply = <&vusbdac_reg>;
dr_mode = "peripheral";
+
status = "okay";
};
&i2c_3 {
+ pinctrl-0 = <&i2c3_bus>;
+ pinctrl-names = "default";
+
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <400000>;
- pinctrl-0 = <&i2c3_bus>;
- pinctrl-names = "default";
+
status = "okay";
touchscreen@48 {
@@ -281,11 +291,13 @@ touchscreen@48 {
};
&i2c_5 {
+ pinctrl-0 = <&i2c5_bus>;
+ pinctrl-names = "default";
+
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
- pinctrl-0 = <&i2c5_bus>;
- pinctrl-names = "default";
+
status = "okay";
pmic@66 {
@@ -312,9 +324,9 @@ pmic@66 {
<1000000>, <950000>;
max8997,pmic-buck2-dvs-voltage = <1100000>, <1000000>,
- <950000>, <900000>,
+ <950000>, <900000>,
<1100000>, <1000000>,
- <950000>, <900000>;
+ <950000>, <900000>;
max8997,pmic-buck5-dvs-voltage = <1200000>, <1200000>,
<1200000>, <1200000>,
@@ -488,9 +500,10 @@ bt_device_wakeup: bt-device-wakeup-pins {
};
&rtc {
- status = "okay";
clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
clock-names = "rtc", "rtc_src";
+
+ status = "okay";
};
&sdhci_0 {
@@ -499,6 +512,7 @@ &sdhci_0 {
pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus8>;
pinctrl-names = "default";
vmmc-supply = <&vemmc_reg>;
+
status = "okay";
};
@@ -508,12 +522,11 @@ &sdhci_2 {
pinctrl-names = "default";
vmmc-supply = <&tflash_reg>;
cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
+
status = "okay";
};
&sdhci_3 {
- status = "okay";
-
#address-cells = <1>;
#size-cells = <0>;
@@ -523,8 +536,10 @@ &sdhci_3 {
mmc-pwrseq = <&wlan_pwrseq>;
vmmc-supply = <&tflash_reg>;
- pinctrl-names = "default";
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
+ pinctrl-names = "default";
+
+ status = "okay";
brcmf: wifi@1 {
compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
@@ -537,12 +552,13 @@ brcmf: wifi@1 {
};
&serial_0 {
- status = "okay";
pinctrl-0 = <&uart0_data &uart0_fctl>;
pinctrl-names = "default";
uart-has-rtscts;
+ status = "okay";
+
bluetooth {
compatible = "brcm,bcm4330-bt";
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 13/17] ARM: dts: samsung: exynos4210-origen: sort properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (11 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
` (3 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
like:
samsung/exynos4210-origen.dts:171: [required-blank-lines] "status" must be preceded by a blank line
samsung/exynos4210-origen.dts:176: [property-order] property 'samsung,i2c-sda-delay' out of canonical order (should sort before 'status')
samsung/exynos4210-origen.dts:178: [property-order] property 'pinctrl-0' out of canonical order (should sort before 'samsung,i2c-max-bus-freq')
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-origen.dts | 30 ++++++++++++++++---------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-origen.dts b/arch/arm/boot/dts/samsung/exynos4210-origen.dts
index f1927ca15e08..78c77d00d138 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-origen.dts
@@ -55,41 +55,42 @@ gpio-keys {
key-up {
label = "Up";
gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_UP>;
wakeup-source;
+ linux,code = <KEY_UP>;
};
key-down {
label = "Down";
gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_DOWN>;
wakeup-source;
+ linux,code = <KEY_DOWN>;
};
key-back {
label = "Back";
gpios = <&gpx1 7 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_BACK>;
wakeup-source;
+ linux,code = <KEY_BACK>;
};
key-home {
label = "Home";
gpios = <&gpx1 6 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_HOME>;
wakeup-source;
+ linux,code = <KEY_HOME>;
};
key-menu {
label = "Menu";
gpios = <&gpx1 5 GPIO_ACTIVE_LOW>;
- linux,code = <KEY_MENU>;
wakeup-source;
+ linux,code = <KEY_MENU>;
};
};
leds {
compatible = "gpio-leds";
+
led-status {
gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
function = LED_FUNCTION_HEARTBEAT;
@@ -118,6 +119,7 @@ pmic_ap_clk: pmic-ap-clk {
display-timings {
native-mode = <&timing0>;
+
timing0: timing {
clock-frequency = <47500000>;
hactive = <1024>;
@@ -142,6 +144,7 @@ map0 {
/* Corresponds to 800MHz */
cooling-device = <&cpu0 2 2>;
};
+
map1 {
/* Corresponds to 200MHz */
cooling-device = <&cpu0 4 4>;
@@ -156,11 +159,13 @@ &exynos_usbphy {
&fimd {
pinctrl-0 = <&lcd_en &lcd_clk &lcd_data24 &pwm0_out>;
pinctrl-names = "default";
+
status = "okay";
};
&gpu {
mali-supply = <&buck3_reg>;
+
status = "okay";
};
@@ -168,23 +173,25 @@ &hsotg {
vusb_d-supply = <&ldo3_reg>;
vusb_a-supply = <&ldo8_reg>;
dr_mode = "peripheral";
+
status = "okay";
};
&i2c_0 {
- status = "okay";
- samsung,i2c-sda-delay = <100>;
- samsung,i2c-max-bus-freq = <20000>;
pinctrl-0 = <&i2c0_bus>;
pinctrl-names = "default";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <20000>;
+
+ status = "okay";
pmic@66 {
compatible = "maxim,max8997-pmic";
reg = <0x66>;
interrupt-parent = <&gpx0>;
interrupts = <4 IRQ_TYPE_NONE>, <3 IRQ_TYPE_NONE>;
- pinctrl-names = "default";
pinctrl-0 = <&max8997_irq>;
+ pinctrl-names = "default";
max8997,pmic-buck1-dvs-voltage = <1350000>;
max8997,pmic-buck2-dvs-voltage = <1100000>;
@@ -334,6 +341,7 @@ &sdhci_0 {
pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_cd>;
pinctrl-names = "default";
vmmc-supply = <&mmc_reg>;
+
status = "okay";
};
@@ -342,6 +350,7 @@ &sdhci_2 {
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
pinctrl-names = "default";
vmmc-supply = <&mmc_reg>;
+
status = "okay";
};
@@ -362,9 +371,10 @@ &serial_3 {
};
&rtc {
- status = "okay";
clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
clock-names = "rtc", "rtc_src";
+
+ status = "okay";
};
&tmu {
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 14/17] ARM: dts: samsung: exynos4210-universal_c210: sort properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (12 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
` (2 subsequent siblings)
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
in strict mode like:
samsung/exynos4210-universal_c210.dts:338: [property-order] property 'pinctrl-0' out of canonical order (should sort before 'samsung,i2c-max-bus-freq')
samsung/exynos4210-universal_c210.dts:340: [required-blank-lines] "status" must be preceded by a blank line
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
.../boot/dts/samsung/exynos4210-universal_c210.dts | 91 ++++++++++++++--------
1 file changed, 57 insertions(+), 34 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
index 744039068e8f..bcc636adba91 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
@@ -74,46 +74,46 @@ gpio-keys {
vol-up-key {
gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
- linux,code = <115>;
label = "volume up";
debounce-interval = <1>;
+ linux,code = <115>;
};
vol-down-key {
gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
- linux,code = <114>;
label = "volume down";
debounce-interval = <1>;
+ linux,code = <114>;
};
config-key {
gpios = <&gpx2 2 GPIO_ACTIVE_LOW>;
- linux,code = <171>;
label = "config";
debounce-interval = <1>;
wakeup-source;
+ linux,code = <171>;
};
camera-key {
gpios = <&gpx2 3 GPIO_ACTIVE_LOW>;
- linux,code = <212>;
label = "camera";
debounce-interval = <1>;
+ linux,code = <212>;
};
power-key {
gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
- linux,code = <116>;
label = "power";
debounce-interval = <1>;
wakeup-source;
+ linux,code = <116>;
};
ok-key {
gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
- linux,code = <352>;
label = "ok";
debounce-interval = <1>;
+ linux,code = <352>;
};
};
@@ -147,6 +147,7 @@ lcd@0 {
reset-delay = <10>;
panel-width-mm = <90>;
panel-height-mm = <154>;
+
display-timings {
timing {
clock-frequency = <23492370>;
@@ -164,6 +165,7 @@ timing {
pixelclk-active = <0>;
};
};
+
port {
lcd_ep: endpoint {
remote-endpoint = <&fimd_dpi_ep>;
@@ -185,12 +187,13 @@ hdmi_ddc: i2c-ddc {
compatible = "i2c-gpio";
sda-gpios = <&gpe4 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
scl-gpios = <&gpe4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
- i2c-gpio,delay-us = <100>;
#address-cells = <1>;
#size-cells = <0>;
pinctrl-0 = <&i2c_ddc_bus>;
pinctrl-names = "default";
+ i2c-gpio,delay-us = <100>;
+
status = "okay";
};
};
@@ -209,6 +212,7 @@ map0 {
/* Corresponds to 800MHz */
cooling-device = <&cpu0 2 2>;
};
+
map1 {
/* Corresponds to 200MHz */
cooling-device = <&cpu0 4 4>;
@@ -217,58 +221,67 @@ map1 {
};
&ehci {
- status = "okay";
phys = <&exynos_usbphy 1>;
phy-names = "host";
+
+ status = "okay";
};
&exynos_usbphy {
- status = "okay";
vbus-supply = <&safeout1_reg>;
+
+ status = "okay";
};
&fimc_0 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC0>,
<&clock CLK_SCLK_FIMC0>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_1 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC1>,
<&clock CLK_SCLK_FIMC1>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_2 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC2>,
<&clock CLK_SCLK_FIMC2>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimc_3 {
- status = "okay";
assigned-clocks = <&clock CLK_MOUT_FIMC3>,
<&clock CLK_SCLK_FIMC3>;
assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
assigned-clock-rates = <0>, <160000000>;
+
+ status = "okay";
};
&fimd {
pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
pinctrl-names = "default";
- status = "okay";
- samsung,invert-vden;
- samsung,invert-vclk;
#address-cells = <1>;
#size-cells = <0>;
+ samsung,invert-vden;
+ samsung,invert-vclk;
+
+ status = "okay";
+
port@3 {
reg = <3>;
+
fimd_dpi_ep: endpoint {
remote-endpoint = <&lcd_ep>;
};
@@ -277,18 +290,20 @@ fimd_dpi_ep: endpoint {
&gpu {
mali-supply = <&buck2_reg>;
+
status = "okay";
};
&hdmi {
hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
- pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd>;
+ pinctrl-names = "default";
hdmi-en-supply = <&hdmi_en>;
vdd-supply = <&ldo3_reg>;
vdd_osc-supply = <&ldo4_reg>;
vdd_pll-supply = <&ldo3_reg>;
ddc = <&hdmi_ddc>;
+
status = "okay";
};
@@ -296,15 +311,17 @@ &hsotg {
vusb_d-supply = <&ldo3_reg>;
vusb_a-supply = <&ldo8_reg>;
dr_mode = "peripheral";
+
status = "okay";
};
&i2c_3 {
+ pinctrl-0 = <&i2c3_bus>;
+ pinctrl-names = "default";
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
- pinctrl-0 = <&i2c3_bus>;
- pinctrl-names = "default";
+
status = "okay";
tsp@4a {
@@ -314,17 +331,24 @@ tsp@4a {
};
&i2c_5 {
+ pinctrl-0 = <&i2c5_bus>;
+ pinctrl-names = "default";
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
- pinctrl-0 = <&i2c5_bus>;
- pinctrl-names = "default";
+
status = "okay";
vdd_arm_reg: pmic@60 {
compatible = "maxim,max8952";
reg = <0x60>;
+ regulator-name = "VARM_1.2V_C210";
+ regulator-min-microvolt = <770000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-always-on;
+ regulator-boot-on;
+
max8952,vid-gpios = <&gpx0 3 GPIO_ACTIVE_HIGH>,
<&gpx0 4 GPIO_ACTIVE_HIGH>;
max8952,default-mode = <0>;
@@ -332,20 +356,14 @@ vdd_arm_reg: pmic@60 {
<1050000>, <950000>;
max8952,sync-freq = <0>;
max8952,ramp-speed = <0>;
-
- regulator-name = "VARM_1.2V_C210";
- regulator-min-microvolt = <770000>;
- regulator-max-microvolt = <1400000>;
- regulator-always-on;
- regulator-boot-on;
};
pmic@66 {
compatible = "national,lp3974";
+ reg = <0x66>;
interrupts-extended = <&gpx0 7 0>, <&gpx2 7 0>;
- pinctrl-names = "default";
pinctrl-0 = <&lp3974_irq>;
- reg = <0x66>;
+ pinctrl-names = "default";
max8998,pmic-buck1-default-dvs-idx = <0>;
max8998,pmic-buck1-dvs-gpios = <&gpx0 5 GPIO_ACTIVE_HIGH>,
@@ -576,13 +594,15 @@ i2c_ddc_bus: i2c-ddc-bus-pins {
&pwm {
compatible = "samsung,s5p6440-pwm";
+
status = "okay";
};
&rtc {
- status = "okay";
clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
clock-names = "rtc", "rtc_src";
+
+ status = "okay";
};
&sdhci_0 {
@@ -591,6 +611,7 @@ &sdhci_0 {
pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus8>;
pinctrl-names = "default";
vmmc-supply = <&vemmc_reg>;
+
status = "okay";
};
@@ -600,12 +621,11 @@ &sdhci_2 {
pinctrl-names = "default";
vmmc-supply = <&ldo5_reg>;
cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
+
status = "okay";
};
&sdhci_3 {
- status = "okay";
-
#address-cells = <1>;
#size-cells = <0>;
@@ -615,8 +635,10 @@ &sdhci_3 {
mmc-pwrseq = <&wlan_pwrseq>;
vmmc-supply = <&ldo5_reg>;
- pinctrl-names = "default";
pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
+ pinctrl-names = "default";
+
+ status = "okay";
brcmf: wifi@1 {
compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
@@ -628,7 +650,6 @@ brcmf: wifi@1 {
};
&serial_0 {
- status = "okay";
/delete-property/dmas;
/delete-property/dma-names;
pinctrl-0 = <&uart0_data &uart0_fctl>;
@@ -636,6 +657,8 @@ &serial_0 {
uart-has-rtscts;
+ status = "okay";
+
bluetooth {
compatible = "brcm,bcm4330-bt";
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 15/17] ARM: dts: samsung: exynos4210-smdkv310: sort properties
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (13 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-04 20:16 ` [PATCH 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
like:
samsung/exynos4210-smdkv310.dts:90: [property-order] property 'wakeup-source' out of canonical order (should sort before 'linux,input-no-autorepeat')
samsung/exynos4210-smdkv310.dts:91: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
samsung/exynos4210-smdkv310.dts:93: [required-blank-lines] "status" must be preceded by a blank line
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
index a6b73a8967c6..609853bb840a 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
@@ -60,6 +60,7 @@ map0 {
/* Corresponds to 800MHz */
cooling-device = <&cpu0 2 2>;
};
+
map1 {
/* Corresponds to 200MHz */
cooling-device = <&cpu0 4 4>;
@@ -70,6 +71,7 @@ map1 {
&i2c_0 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <100000>;
+
status = "okay";
eeprom@50 {
@@ -84,12 +86,13 @@ eeprom@52 {
};
&keypad {
+ wakeup-source;
+ pinctrl-0 = <&keypad_rows &keypad_cols>;
+ pinctrl-names = "default";
samsung,keypad-num-rows = <2>;
samsung,keypad-num-columns = <8>;
linux,input-no-autorepeat;
- wakeup-source;
- pinctrl-names = "default";
- pinctrl-0 = <&keypad_rows &keypad_cols>;
+
status = "okay";
key-1 {
@@ -177,8 +180,9 @@ &rtc {
&sdhci_2 {
bus-width = <4>;
- pinctrl-names = "default";
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
+ pinctrl-names = "default";
+
status = "okay";
};
@@ -200,13 +204,14 @@ &serial_3 {
&spi_2 {
cs-gpios = <&gpc1 2 GPIO_ACTIVE_HIGH>;
+
status = "okay";
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "winbond,w25x80", "jedec,spi-nor";
reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <1>;
spi-max-frequency = <1000000>;
controller-data {
@@ -214,14 +219,14 @@ controller-data {
};
partition@0 {
- label = "U-Boot";
reg = <0x0 0x40000>;
+ label = "U-Boot";
read-only;
};
partition@40000 {
- label = "Kernel";
reg = <0x40000 0xc0000>;
+ label = "Kernel";
};
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (14 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
2026-10-04 20:16 ` [PATCH 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Nodes should be sorted alphabetically by name. Move a few of the nodes
and child nodes to achieve alphabetical order.
Fixes dt-check-style in strict mode warnings:
samsung/exynos4210-smdkv310.dts:28: [child-name-order] child node 'aliases' out of name order
samsung/exynos4210-smdkv310.dts:43: [child-name-order] child node 'xusbxti' out of name order
samsung/exynos4210-smdkv310.dts:48: [child-name-order] child node 'pmic-ap-clk' out of name order
samsung/exynos4210-smdkv310.dts:168: [child-name-order] child node 'keypad-cols-pins' out of name order
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts | 40 +++++++++++------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
index 609853bb840a..5c703efacc87 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
@@ -20,11 +20,6 @@ / {
model = "Samsung smdkv310 evaluation board based on Exynos4210";
compatible = "samsung,smdkv310", "samsung,exynos4210", "samsung,exynos4";
- memory@40000000 {
- device_type = "memory";
- reg = <0x40000000 0x80000000>;
- };
-
aliases {
mmc0 = &sdhci_2;
};
@@ -35,9 +30,11 @@ chosen {
};
fixed-rate-clocks {
- xxti {
- compatible = "samsung,clock-xxti";
- clock-frequency = <12000000>;
+ pmic_ap_clk: pmic-ap-clk {
+ /* Workaround for missing clock on PMIC */
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <32768>;
};
xusbxti {
@@ -45,13 +42,16 @@ xusbxti {
clock-frequency = <24000000>;
};
- pmic_ap_clk: pmic-ap-clk {
- /* Workaround for missing clock on PMIC */
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <32768>;
+ xxti {
+ compatible = "samsung,clock-xxti";
+ clock-frequency = <12000000>;
};
};
+
+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x40000000 0x80000000>;
+ };
};
&cpu_thermal {
@@ -157,13 +157,6 @@ key-e {
};
&pinctrl_1 {
- keypad_rows: keypad-rows-pins {
- samsung,pins = "gpx2-0", "gpx2-1";
- samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
- samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
- samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
- };
-
keypad_cols: keypad-cols-pins {
samsung,pins = "gpx1-0", "gpx1-1", "gpx1-2", "gpx1-3",
"gpx1-4", "gpx1-5", "gpx1-6", "gpx1-7";
@@ -171,6 +164,13 @@ keypad_cols: keypad-cols-pins {
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
};
+
+ keypad_rows: keypad-rows-pins {
+ samsung,pins = "gpx2-0", "gpx2-1";
+ samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+ samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+ samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+ };
};
&rtc {
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments
2026-10-04 20:15 [PATCH 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
` (15 preceding siblings ...)
2026-10-04 20:16 ` [PATCH 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
@ 2026-10-04 20:16 ` Henrik Grimler
16 siblings, 0 replies; 19+ messages in thread
From: Henrik Grimler @ 2026-10-04 20:16 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Peter Griffin,
Alim Akhtar
Cc: devicetree, waqar.hameed, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Henrik Grimler
Remove extra empty line, align multiline properties and add space
after /delete-property/. Fixed with dtfmt (Devicetree Source
formatter).
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
.../boot/dts/samsung/exynos4210-universal_c210.dts | 23 +++++++++++-----------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
index bcc636adba91..2e8d48315390 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
@@ -35,7 +35,6 @@ chosen {
stdout-path = "serial2:115200n8";
};
-
fixed-rate-clocks {
xxti {
compatible = "samsung,clock-xxti";
@@ -353,7 +352,7 @@ vdd_arm_reg: pmic@60 {
<&gpx0 4 GPIO_ACTIVE_HIGH>;
max8952,default-mode = <0>;
max8952,dvs-mode-microvolt = <1250000>, <1200000>,
- <1050000>, <950000>;
+ <1050000>, <950000>;
max8952,sync-freq = <0>;
max8952,ramp-speed = <0>;
};
@@ -367,9 +366,9 @@ pmic@66 {
max8998,pmic-buck1-default-dvs-idx = <0>;
max8998,pmic-buck1-dvs-gpios = <&gpx0 5 GPIO_ACTIVE_HIGH>,
- <&gpx0 6 GPIO_ACTIVE_HIGH>;
+ <&gpx0 6 GPIO_ACTIVE_HIGH>;
max8998,pmic-buck1-dvs-voltage = <1100000>, <1000000>,
- <1100000>, <1000000>;
+ <1100000>, <1000000>;
max8998,pmic-buck2-default-dvs-idx = <0>;
max8998,pmic-buck2-dvs-gpio = <&gpe2 0 GPIO_ACTIVE_HIGH>;
@@ -650,8 +649,8 @@ brcmf: wifi@1 {
};
&serial_0 {
- /delete-property/dmas;
- /delete-property/dma-names;
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
pinctrl-0 = <&uart0_data &uart0_fctl>;
pinctrl-names = "default";
@@ -674,20 +673,20 @@ bluetooth {
&serial_1 {
status = "okay";
- /delete-property/dmas;
- /delete-property/dma-names;
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&serial_2 {
status = "okay";
- /delete-property/dmas;
- /delete-property/dma-names;
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&serial_3 {
status = "okay";
- /delete-property/dmas;
- /delete-property/dma-names;
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&soc {
--
2.43.0
^ permalink raw reply related [flat|nested] 19+ messages in thread