Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing minItems: 2 constraint for syna,sl2610-uart resets
--

commit d2c2a625dcf17e541f9ec792d85888075ee11605
Author: Jisheng Zhang <jszhang@kernel.org>

dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

Add the compatible for the UARTs of the Synaptics SL2610, which are
compatible with the Synopsys DesignWare APB UART.

> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 664305de4986f..a40f2737e71b5 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -34,7 +34,16 @@ allOf:
>        properties:
>          resets:
>            minItems: 2
> -    else:
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - starfive,jh7110-uart
> +                - syna,sl2610-uart

[Severity: Low]
Does this compatible string also need to be added to the if-then block
enforcing the minItems: 2 constraint?

This block explicitly exempts syna,sl2610-uart from the maxItems: 1 
single-reset constraint, indicating it requires 2 resets. However, the 
block immediately above this (which enforces minItems: 2 for 
starfive,jh7110-uart) was not updated to include syna,sl2610-uart.

As a result, device trees for syna,sl2610-uart with only 1 reset will
silently pass schema validation.

> +    then:
>        properties:
>          resets:
>            maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005151918.25259-1-jszhang@kernel.org?part=1