* [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart @ 2026-10-05 15:19 Jisheng Zhang 2026-10-05 15:49 ` sashiko-bot 2026-10-07 13:04 ` Conor Dooley 0 siblings, 2 replies; 5+ messages in thread From: Jisheng Zhang @ 2026-10-05 15:19 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-kernel, linux-serial, devicetree Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART. Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- since v1: - use sl2610 instead of sl261x - send as a separate patch .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml index 664305de4986..a40f2737e71b 100644 --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml @@ -34,7 +34,16 @@ allOf: properties: resets: minItems: 2 - else: + + - if: + not: + properties: + compatible: + contains: + enum: + - starfive,jh7110-uart + - syna,sl2610-uart + then: properties: resets: maxItems: 1 @@ -80,6 +89,7 @@ properties: - starfive,jh7100-hsuart - starfive,jh7100-uart - starfive,jh7110-uart + - syna,sl2610-uart - ultrarisc,dp1000-uart - const: snps,dw-apb-uart - const: snps,dw-apb-uart -- 2.53.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart 2026-10-05 15:19 [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart Jisheng Zhang @ 2026-10-05 15:49 ` sashiko-bot 2026-10-07 13:04 ` Conor Dooley 1 sibling, 0 replies; 5+ messages in thread From: sashiko-bot @ 2026-10-05 15:49 UTC (permalink / raw) To: Jisheng Zhang; +Cc: conor+dt, robh, devicetree, linux-serial Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: missing minItems: 2 constraint for syna,sl2610-uart resets -- commit d2c2a625dcf17e541f9ec792d85888075ee11605 Author: Jisheng Zhang <jszhang@kernel.org> dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart Add the compatible for the UARTs of the Synaptics SL2610, which are compatible with the Synopsys DesignWare APB UART. > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > index 664305de4986f..a40f2737e71b5 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > @@ -34,7 +34,16 @@ allOf: > properties: > resets: > minItems: 2 > - else: > + > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - starfive,jh7110-uart > + - syna,sl2610-uart [Severity: Low] Does this compatible string also need to be added to the if-then block enforcing the minItems: 2 constraint? This block explicitly exempts syna,sl2610-uart from the maxItems: 1 single-reset constraint, indicating it requires 2 resets. However, the block immediately above this (which enforces minItems: 2 for starfive,jh7110-uart) was not updated to include syna,sl2610-uart. As a result, device trees for syna,sl2610-uart with only 1 reset will silently pass schema validation. > + then: > properties: > resets: > maxItems: 1 -- Sashiko AI review · https://sashiko.dev/#/patchset/20261005151918.25259-1-jszhang@kernel.org?part=1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart 2026-10-05 15:19 [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart Jisheng Zhang 2026-10-05 15:49 ` sashiko-bot @ 2026-10-07 13:04 ` Conor Dooley 2026-10-08 13:49 ` Jisheng Zhang 1 sibling, 1 reply; 5+ messages in thread From: Conor Dooley @ 2026-10-07 13:04 UTC (permalink / raw) To: Jisheng Zhang Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-serial, devicetree [-- Attachment #1: Type: text/plain, Size: 1601 bytes --] On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote: > Add the compatible for the UARTs of the Synaptics SL2610, which are > compatible with the Synopsys DesignWare APB UART. > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > --- > > since v1: > - use sl2610 instead of sl261x > - send as a separate patch > > .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > index 664305de4986..a40f2737e71b 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > @@ -34,7 +34,16 @@ allOf: > properties: > resets: > minItems: 2 > - else: > + > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - starfive,jh7110-uart > + - syna,sl2610-uart Is the number of uart resets on this device variable? > + then: > properties: > resets: > maxItems: 1 > @@ -80,6 +89,7 @@ properties: > - starfive,jh7100-hsuart > - starfive,jh7100-uart > - starfive,jh7110-uart > + - syna,sl2610-uart > - ultrarisc,dp1000-uart > - const: snps,dw-apb-uart > - const: snps,dw-apb-uart > -- > 2.53.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart 2026-10-07 13:04 ` Conor Dooley @ 2026-10-08 13:49 ` Jisheng Zhang 2026-10-09 15:44 ` Conor Dooley 0 siblings, 1 reply; 5+ messages in thread From: Jisheng Zhang @ 2026-10-08 13:49 UTC (permalink / raw) To: Conor Dooley Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-serial, devicetree On Wed, Oct 07, 2026 at 02:04:05PM +0100, Conor Dooley wrote: > On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote: > > Add the compatible for the UARTs of the Synaptics SL2610, which are > > compatible with the Synopsys DesignWare APB UART. > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > --- > > > > since v1: > > - use sl2610 instead of sl261x > > - send as a separate patch > > > > .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > index 664305de4986..a40f2737e71b 100644 > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > @@ -34,7 +34,16 @@ allOf: > > properties: > > resets: > > minItems: 2 > > - else: > > + > > + - if: > > + not: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - starfive,jh7110-uart > > + - syna,sl2610-uart > > Is the number of uart resets on this device variable? Yes, some uarts have only 1 reset, while others have two resets. > > > + then: > > properties: > > resets: > > maxItems: 1 > > @@ -80,6 +89,7 @@ properties: > > - starfive,jh7100-hsuart > > - starfive,jh7100-uart > > - starfive,jh7110-uart > > + - syna,sl2610-uart > > - ultrarisc,dp1000-uart > > - const: snps,dw-apb-uart > > - const: snps,dw-apb-uart > > -- > > 2.53.0 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart 2026-10-08 13:49 ` Jisheng Zhang @ 2026-10-09 15:44 ` Conor Dooley 0 siblings, 0 replies; 5+ messages in thread From: Conor Dooley @ 2026-10-09 15:44 UTC (permalink / raw) To: Jisheng Zhang Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-serial, devicetree [-- Attachment #1: Type: text/plain, Size: 2188 bytes --] On Thu, Oct 08, 2026 at 09:49:07PM +0800, Jisheng Zhang wrote: > On Wed, Oct 07, 2026 at 02:04:05PM +0100, Conor Dooley wrote: > > On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote: > > > Add the compatible for the UARTs of the Synaptics SL2610, which are > > > compatible with the Synopsys DesignWare APB UART. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > --- > > > > > > since v1: > > > - use sl2610 instead of sl261x > > > - send as a separate patch > > > > > > .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++- > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > > index 664305de4986..a40f2737e71b 100644 > > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > > @@ -34,7 +34,16 @@ allOf: > > > properties: > > > resets: > > > minItems: 2 > > > - else: > > > + > > > + - if: > > > + not: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - starfive,jh7110-uart > > > + - syna,sl2610-uart > > > > Is the number of uart resets on this device variable? > > Yes, some uarts have only 1 reset, while others have two resets. In the future, please mention this so it doesn't look like an oversight. Acked-by: Conor Dooley <conor.dooley@microchip.com> pw-bot: not-applicable Thanks, Conor. > > > > > > + then: > > > properties: > > > resets: > > > maxItems: 1 > > > @@ -80,6 +89,7 @@ properties: > > > - starfive,jh7100-hsuart > > > - starfive,jh7100-uart > > > - starfive,jh7110-uart > > > + - syna,sl2610-uart > > > - ultrarisc,dp1000-uart > > > - const: snps,dw-apb-uart > > > - const: snps,dw-apb-uart > > > -- > > > 2.53.0 > > > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-10-09 15:45 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-10-05 15:19 [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart Jisheng Zhang 2026-10-05 15:49 ` sashiko-bot 2026-10-07 13:04 ` Conor Dooley 2026-10-08 13:49 ` Jisheng Zhang 2026-10-09 15:44 ` Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox