Re: [PATCH] dt-bindings: bus: Add HiSilicon local bus

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing `required` block allows nodes without `reg` to pass
--

commit 31cf8e8c992601dbcd36de1b649ef5c513febf6f
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: bus: Add HiSilicon local bus

This commit introduces a new device tree binding schema for the HiSilicon local
bus. It sets up validation constraints for the compatible string and registers.

> diff --git a/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
> new file mode 100644
> index 0000000000000..cd9ecea88269f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - const: hisilicon,hisi-localbus
> +      - const: simple-bus
> +
> +  reg:
> +    maxItems: 1
> +
> +unevaluatedProperties: false

[Severity: Low]
Should this schema include a required array to enforce the presence of the
compatible and reg properties?

Because properties are optional by default, omitting an explicit required
block here means that incomplete device tree nodes missing either the reg
property or the compatible string will silently pass dtbs_check validation
without enforcing the constraints defined above.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005205310.2079198-1-robh@kernel.org?part=1