* [PATCH] dt-bindings: bus: Add HiSilicon local bus
@ 2026-10-05 20:53 Rob Herring (Arm)
2026-10-05 21:00 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-10-05 20:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Wei Xu; +Cc: devicetree, linux-kernel
Add a schema for hisilicon,hisi-localbus which is already in use for a
long time.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/bus/hisilicon,hisi-localbus.yaml | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
diff --git a/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
new file mode 100644
index 000000000000..cd9ecea88269
--- /dev/null
+++ b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/hisilicon,hisi-localbus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HiSilicon local bus
+
+maintainers:
+ - Wei Xu <xuwei5@hisilicon.com>
+
+allOf:
+ - $ref: /schemas/simple-bus.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: hisilicon,hisi-localbus
+ - const: simple-bus
+
+ reg:
+ maxItems: 1
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ local-bus@80380000 {
+ compatible = "hisilicon,hisi-localbus", "simple-bus";
+ reg = <0x0 0x80380000 0x0 0x10000>;
+ #address-cells = <2>;
+ #size-cells = <1>;
+ ranges = <0 0 0x0 0x90000000 0x08000000>,
+ <1 0 0x0 0x98000000 0x08000000>;
+ };
+ };
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: bus: Add HiSilicon local bus
2026-10-05 20:53 [PATCH] dt-bindings: bus: Add HiSilicon local bus Rob Herring (Arm)
@ 2026-10-05 21:00 ` sashiko-bot
2026-10-06 14:46 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-10-05 21:00 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing `required` block allows nodes without `reg` to pass
--
commit 31cf8e8c992601dbcd36de1b649ef5c513febf6f
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: bus: Add HiSilicon local bus
This commit introduces a new device tree binding schema for the HiSilicon local
bus. It sets up validation constraints for the compatible string and registers.
> diff --git a/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
> new file mode 100644
> index 0000000000000..cd9ecea88269f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
[ ... ]
> +properties:
> + compatible:
> + items:
> + - const: hisilicon,hisi-localbus
> + - const: simple-bus
> +
> + reg:
> + maxItems: 1
> +
> +unevaluatedProperties: false
[Severity: Low]
Should this schema include a required array to enforce the presence of the
compatible and reg properties?
Because properties are optional by default, omitting an explicit required
block here means that incomplete device tree nodes missing either the reg
property or the compatible string will silently pass dtbs_check validation
without enforcing the constraints defined above.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005205310.2079198-1-robh@kernel.org?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: bus: Add HiSilicon local bus
2026-10-05 21:00 ` sashiko-bot
@ 2026-10-06 14:46 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2026-10-06 14:46 UTC (permalink / raw)
To: sashiko-reviews; +Cc: conor+dt, devicetree
On Mon, Oct 05, 2026 at 09:00:34PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: missing `required` block allows nodes without `reg` to pass
> --
>
> commit 31cf8e8c992601dbcd36de1b649ef5c513febf6f
> Author: Rob Herring (Arm) <robh@kernel.org>
>
> dt-bindings: bus: Add HiSilicon local bus
>
> This commit introduces a new device tree binding schema for the HiSilicon local
> bus. It sets up validation constraints for the compatible string and registers.
>
> > diff --git a/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
> > new file mode 100644
> > index 0000000000000..cd9ecea88269f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/bus/hisilicon,hisi-localbus.yaml
>
> [ ... ]
>
> > +properties:
> > + compatible:
> > + items:
> > + - const: hisilicon,hisi-localbus
> > + - const: simple-bus
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +unevaluatedProperties: false
>
> [Severity: Low]
> Should this schema include a required array to enforce the presence of the
> compatible and reg properties?
compatible is implied, but will add 'reg' when applying.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-06 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-05 20:53 [PATCH] dt-bindings: bus: Add HiSilicon local bus Rob Herring (Arm)
2026-10-05 21:00 ` sashiko-bot
2026-10-06 14:46 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox