[PATCH] dt-bindings: rtc: rzn1: add resets property

[PATCH] dt-bindings: rtc: rzn1: add resets property

[Wolfram Sang]

The RTC on R-Car X5H does have a reset unlike the other versions.

Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Passes both DT checks. Kind of fixes 3b3fdc9fd40d ("dt-bindings: rtc:
rzn1: add R-Car X5H support") in -next, but we don't use Fixes: for
bindings, or?

 .../devicetree/bindings/rtc/renesas,rzn1-rtc.yaml          | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
index b448725671ec..5a869e6c0ae7 100644
--- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
@@ -51,6 +51,9 @@ properties:
   power-domains:
     maxItems: 1
 
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -85,7 +88,11 @@ allOf:
       properties:
         interrupts: false
         interrupt-names: false
+      required:
+        - resets
     else:
+      properties:
+        resets: false
       required:
         - interrupts
         - interrupt-names
-- 
2.53.0

Re: [PATCH] dt-bindings: rtc: rzn1: add resets property

[sashiko-bot]

> The RTC on R-Car X5H does have a reset unlike the other versions.
> 
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008201953.34307-2-wsa+renesas@sang-engineering.com?part=1

Re: [PATCH] dt-bindings: rtc: rzn1: add resets property

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

On Thu, Oct 08, 2026 at 10:16:53PM +0200, Wolfram Sang wrote:
> The RTC on R-Car X5H does have a reset unlike the other versions.
> 
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Passes both DT checks. Kind of fixes 3b3fdc9fd40d ("dt-bindings: rtc:
> rzn1: add R-Car X5H support") in -next, but we don't use Fixes: for
> bindings, or?

If you want, make it more obvious IMO that this is a correction.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

> 
>  .../devicetree/bindings/rtc/renesas,rzn1-rtc.yaml          | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> index b448725671ec..5a869e6c0ae7 100644
> --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> @@ -51,6 +51,9 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -85,7 +88,11 @@ allOf:
>        properties:
>          interrupts: false
>          interrupt-names: false
> +      required:
> +        - resets
>      else:
> +      properties:
> +        resets: false
>        required:
>          - interrupts
>          - interrupt-names
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]