From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Quchaosheng <quchaosheng000406@163.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema
Date: Fri, 9 Oct 2026 12:34:33 -0500 [thread overview]
Message-ID: <20261009173433.GA2862960-robh@kernel.org> (raw)
In-Reply-To: <20261009-db35f1d74028d0d0a34f1106@squawk>
On Fri, Oct 09, 2026 at 04:42:01PM +0100, Conor Dooley wrote:
> On Fri, Oct 09, 2026 at 04:44:34PM +0200, Laurent Pinchart wrote:
> > On Fri, Oct 09, 2026 at 03:25:49PM +0100, Conor Dooley wrote:
> > > On Fri, Oct 09, 2026 at 06:55:59PM +0800, Quchaosheng wrote:
> > > > From: Chaosheng Qu <quchaosheng000406@163.com>
> > > >
> > > > Convert the TPD12S015 HDMI level shifter binding to DT schema.
> > > >
> > > > The TI TPD12S015 is an HDMI companion chip that combines a level shifter
> > > > and ESD protection circuitry. Document the two ports it exposes between
> > > > the HDMI transmitter and the connector.
> > > >
> > > > The tpd12s016 is software compatible with the tpd12s015 and is listed as
> > > > a fallback compatible by am57xx-idk-common.dtsi, so accept it as a
> > > > fallback of "ti,tpd12s015". The driver matches on "ti,tpd12s015" only, so
> > > > a board using the tpd12s016 must list both compatibles.
> > > >
> > > > Assisted-by: LLM
> > > > Signed-off-by: Chaosheng Qu <quchaosheng000406@163.com>
> > >
> > > No idea if the sashiko reply is valid, because I have no clue if
> > > providing a subset of the gpios is functional. Really this should have
> > > multiple different gpios properties,
The minItems one is not valid. sashiko struggles on our quirks against
normal json-schema. Generally, if either minItems or maxItems is not
specified, we make them equal. I think I documented that, so we need to
get sashiko to read it...
> >
> > Definitely.
> >
> > > but this binding is really old and
> > > not worth changing IMO.
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > pw-bot: not-applicable
> >
> > I'm getting annoyed be the LLM-assisted individual conversions. Can we
> > start requiring people who convert text bindings to YAML to at least
> > handle whole groups in one go ? If they're going to do a bad job, I'd
> > rather have to review it once only.
I have a branch of ~600 questionable patches. :) It does make arm64
warning free (and some of the warning fixes are valid).
What's left is really stuff that's old, not getting new platforms and no
one cares about. I don't think we need perfection. We should probably
just ignore sashiko.
>
> Or do one, and take the learnings into all the remaining patches - but
> with LLM conversions I don't think there's really much learning going on
> at all.
>
> I guess bunching them is fine, provided it is for one subsystem. I
> definitely don't want to see a set of 15 patches across 9 subsystems,
> at least with one subsystem it's likely to be the same common problems
> across the bunch.
I've tried expressing my preferences in priority, but it hasn't worked.
It was mainly GSoC or other programs, but now it's?
My priority is:
- Fix arm64 warnings
- Fix arm warnings
- Convert subsystem bindings
- Fix other $arch warnings (no one cares AFAICT)
We're actually pretty close to arm64 being warning free. krzk's LPC
slides inflate the numbers as N boards for a SoC give N copies of
warnings. next is currently sitting at 218 warnings in my deduped count.
About half of those are HiSilicon and Mediatek. The rest of the
platforms (by subdir) are around ~20 or less.
arm32 is still a long way off. The recent platform removals should help
though.
Rob
next prev parent reply other threads:[~2026-10-09 17:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 10:55 [PATCH 0/3] dt-bindings: display: ti,tpd12s015: convert, and fix what the conversion exposed Quchaosheng
2026-10-09 10:55 ` [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-10-09 11:14 ` sashiko-bot
2026-10-09 14:25 ` Conor Dooley
2026-10-09 14:44 ` Laurent Pinchart
2026-10-09 15:42 ` Conor Dooley
2026-10-09 17:34 ` Rob Herring [this message]
2026-10-10 0:48 ` Quchaosheng
2026-10-09 15:38 ` Rob Herring
2026-10-09 10:56 ` [PATCH 2/3] ARM: dts: ti/omap: drop the two unused gpios from the igep0050 hdmi encoder Quchaosheng
2026-10-09 10:56 ` [PATCH 3/3] ARM: dts: ti/omap: drop unit-address from tpd12s015 endpoints Quchaosheng
2026-10-09 11:03 ` [PATCH 0/3] dt-bindings: display: ti,tpd12s015: convert, and fix what the conversion exposed Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2026-10-09 10:54 Quchaosheng
2026-10-09 10:54 ` [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-10-09 11:05 ` sashiko-bot
2026-10-09 10:53 [PATCH 0/3] dt-bindings: display: ti,tpd12s015: convert, and fix what the conversion exposed Quchaosheng
2026-10-09 10:53 ` [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-10-09 11:03 ` sashiko-bot
2026-10-09 10:53 [PATCH 0/3] dt-bindings: display: ti,tpd12s015: convert, and fix what the conversion exposed Quchaosheng
2026-10-09 10:53 ` [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema Quchaosheng
2026-10-09 11:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009173433.GA2862960-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=quchaosheng000406@163.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox