Re: [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: ti,tpd12s015: missing minItems: 3 constraint for gpios property
--

commit 93e133f1119a3271ab3e48f347188c3580055f0b
Author: Chaosheng Qu <quchaosheng000406@163.com>

dt-bindings: display: ti,tpd12s015: Convert to DT schema

Convert the TPD12S015 HDMI level shifter binding to DT schema. Document the
two ports it exposes between the HDMI transmitter and the connector, and
add the tpd12s016 as a fallback compatible.

> diff --git a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
> new file mode 100644
> index 0000000000000..1927da3bd7361
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---

[ ... ]

> +properties:
> +  compatible:
> +    oneOf:
> +      - const: ti,tpd12s015
> +      - items:
> +          - const: ti,tpd12s016
> +          - const: ti,tpd12s015
> +
> +  gpios:
> +    description:
> +      The CT CP HPD, LS OE and HPD GPIOs, in that order. The first controls
> +      the level shifter, the second enables the level shifter outputs and
> +      the third reads the hot-plug detect line.
> +    maxItems: 3

[Severity: Low]
Does this gpios property also need a minItems: 3 constraint to prevent
incomplete device trees from passing schema validation?

Since maxItems is 3 and minItems is omitted, the schema compiler defaults
minItems to 1.

The driver ti-tpd12s015.c unconditionally attempts to retrieve the third
pin by its explicit index:

    devm_gpiod_get_index(&pdev->dev, NULL, 2, GPIOD_IN)

If a device tree provides 1 or 2 GPIOs, it will pass schema validation but
the driver probe will fail at runtime with -ENOENT.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009105412.300338-1-quchaosheng000406@163.com?part=1