Re: [PATCH 2/2] riscv: dts: spacemit: mark K1 board boot devices bootph-pre-ram

[Hung-Chun Tseng <alan.tseng.cs@gmail.com>]

Hi Yixun,

Thanks for the review.

On Thu, Oct 15, 2026 at 07:46:21AM +0000, Yixun Lan wrote:
> > &i2c8 {
> > +	bootph-pre-ram;
> We could move this to dtsi file, since all board share
> same design which use i2c8 for connecting to pmic, the
> reward would be that we no longer need to carry this
> property all over board dts file.. similar we could do
> for "i2c2", but I noticed k1-orangepi-rv2/r2s have no
> eeprom enabled..

Agreed, v2 will tag i2c8 in k1.dtsi. I'll keep i2c2 in the board
files, as the OrangePi RV2 and R2S have no EEPROM.

> > 			buck1 {
> > +				bootph-pre-ram;
> U-Boot also carry "regulator-name" for this node, we
> probably could also merge it here, but could do it in
> another patch if want to limit this patch to "pre-ram"
> change only

I'd prefer a separate patch for that, to keep this one about the
bootph tags. The U-Boot K1 SPL looks the rails up by name ("vdd_core",
"vdd_1v8", "vdd_1v8_mmc"), so once the names are upstream, U-Boot can
drop the overrides in its -u-boot.dtsi files.

Thanks,
Hung-Chun