From: Ray Strode <halfline@gmail.com>
To: rshouriesh@gmail.com
Cc: bod@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
hverkuil+cisco@kernel.org, j@metarealtyinc.ca,
krzk+dt@kernel.org, kulikeduard89@gmail.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
mchehab@kernel.org, robh@kernel.org,
sakari.ailus@linux.intel.com, vladimir.zapolskiy@linaro.org
Subject: Re: [PATCH v7 3/3] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration
Date: Thu, 15 Oct 2026 15:26:24 -0400 [thread overview]
Message-ID: <20261015192632.283185-1-halfline@gmail.com> (raw)
In-Reply-To: <20261013-hm1092-driver-v7-3-d81a9b152ffd@gmail.com>
Hi,
Regarding the crop-bounds question: the 19.2 MHz mode reports a 1294x734
crop at (0,0), which extends outside the advertised 1280x720 bounds at
(8,8).
Reporting the native array as CROP_BOUNDS accommodates that readout window
while keeping CROP_DEFAULT as the active area:
diff --git a/drivers/media/i2c/hm1092.c b/drivers/media/i2c/hm1092.c
--- a/drivers/media/i2c/hm1092.c
+++ b/drivers/media/i2c/hm1092.c
@@ -836,12 +836,12 @@
sel->r = to_hm1092(sd)->mode->crop;
return 0;
case V4L2_SEL_TGT_CROP_DEFAULT:
- case V4L2_SEL_TGT_CROP_BOUNDS:
sel->r.left = HM1092_ACTIVE_LEFT;
sel->r.top = HM1092_ACTIVE_TOP;
sel->r.width = HM1092_ACTIVE_WIDTH;
sel->r.height = HM1092_ACTIVE_HEIGHT;
return 0;
+ case V4L2_SEL_TGT_CROP_BOUNDS:
case V4L2_SEL_TGT_NATIVE_SIZE:
sel->r.left = 0;
sel->r.top = 0;
This changes only the reported bounds; the mode's crop and register
configuration stay the same.
prev parent reply other threads:[~2026-10-15 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 3:28 [PATCH v7 0/3] media: Add Himax HM1092 mono NIR sensor driver Ramshouriesh R
2026-10-13 3:28 ` [PATCH v7 1/3] media: dt-bindings: Add Himax HM1092 NIR sensor Ramshouriesh R
2026-10-13 3:28 ` [PATCH v7 2/3] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh R
2026-10-13 3:28 ` [PATCH v7 3/3] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration Ramshouriesh R
2026-10-13 3:36 ` sashiko-bot
2026-10-15 19:26 ` Ray Strode [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015192632.283185-1-halfline@gmail.com \
--to=halfline@gmail.com \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=j@metarealtyinc.ca \
--cc=krzk+dt@kernel.org \
--cc=kulikeduard89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=rshouriesh@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox