From: Rob Herring <robh@kernel.org>
To: Biju <biju.das.au@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
Date: Tue, 20 Oct 2026 11:48:40 -0500 [thread overview]
Message-ID: <20261020164840.GA4094037-robh@kernel.org> (raw)
In-Reply-To: <20261019120220.166163-2-biju.das.jz@bp.renesas.com>
On Mon, Oct 19, 2026 at 01:02:13PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> The description of the property that selects Classical CAN mode implies
> that every supported SoC can operate in that mode. This is not true for
> RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
>
> Update the description to say that Classical CAN mode is not available on
> RZ/G3S, so the property is not mistakenly used for that SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v5:
> * New patch.
> ---
> .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 1a7a9ce45e97..7d3330f8fc1a 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -146,8 +146,8 @@ properties:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> The controller can operate in either CAN-FD mode (default) or FD-Only
> - mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
> - property to put the controller in Classical CAN mode.
> + mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
> + Specify this property to put the controller in Classical CAN mode.
Can't this be expressed as a schema?
>
> renesas,fd-only:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-10-20 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 12:02 [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Biju
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
2026-10-20 16:48 ` Rob Herring [this message]
2026-10-20 17:17 ` Biju Das
2026-10-19 12:02 ` [PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC Biju
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
2026-10-20 8:20 ` Biju Das
2026-10-20 8:21 ` Marc Kleine-Budde
2026-10-20 8:30 ` Biju Das
2026-10-20 12:33 ` Biju Das
2026-10-20 14:58 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020164840.GA4094037-robh@kernel.org \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox