* [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
@ 2026-10-19 12:02 Biju
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Biju @ 2026-10-19 12:02 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Magnus Damm
Cc: Biju Das, Fabrizio Castro, linux-can, devicetree,
linux-renesas-soc, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
From: Biju Das <biju.das.jz@bp.renesas.com>
Add support for Renesas RZ/G3L CANFD.
The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
buffers on RZ/G3S SoC.
This patch series depend upon [1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
v4->v5:
* Added patches for Documenting RZ/G3{L,S} SoC has no Classical CAN mode.
* Dropped the patch "can: rcar_canfd: Derive max_channels from the device
tree"
* Dropped the tags as there are new changes.
* Restored maxItems on interrupts and interrupt-names.
* Added resets/reset-names required property for RZ/G3L.
* Added r9a08g046_hw_info to device data.
v3->v4:
* Dropped maxItems from interrupts,interrupt-names and resets.
* Collected tags.
v2->v3:
* Collected tags.
* Added check against RCANFD_NUM_CHANNELS, to avoid overrunning the
fixed-size rcar_canfd_global.ch[] and transceivers[] arrays.
* Fixed typo 198->192 buffers in commit description.
v1->v2:
* Added support for deriving max_channels from the device tree.
* Dropped clock patch as it is accepted.
* Dropped devicetree patches, will send it later.
* Updated commit description
* Dropped RZ/G3S fallback as there are lot of differences.
Biju Das (4):
dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical
CAN mode
can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode
dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC
can: rcar_canfd: Add support for Renesas RZ/G3L
.../bindings/net/can/renesas,rcar-canfd.yaml | 32 +++++++++++++++++--
drivers/net/can/rcar/rcar_canfd.c | 31 +++++++++++++++---
2 files changed, 55 insertions(+), 8 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
2026-10-19 12:02 [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Biju
@ 2026-10-19 12:02 ` Biju
2026-10-20 16:48 ` Rob Herring
2026-10-19 12:02 ` [PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC Biju
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
2 siblings, 1 reply; 11+ messages in thread
From: Biju @ 2026-10-19 12:02 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Magnus Damm
Cc: Biju Das, Fabrizio Castro, linux-can, devicetree,
linux-renesas-soc, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
From: Biju Das <biju.das.jz@bp.renesas.com>
The description of the property that selects Classical CAN mode implies
that every supported SoC can operate in that mode. This is not true for
RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
Update the description to say that Classical CAN mode is not available on
RZ/G3S, so the property is not mistakenly used for that SoC.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v5:
* New patch.
---
.../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 1a7a9ce45e97..7d3330f8fc1a 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -146,8 +146,8 @@ properties:
$ref: /schemas/types.yaml#/definitions/flag
description:
The controller can operate in either CAN-FD mode (default) or FD-Only
- mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
- property to put the controller in Classical CAN mode.
+ mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
+ Specify this property to put the controller in Classical CAN mode.
renesas,fd-only:
$ref: /schemas/types.yaml#/definitions/flag
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC
2026-10-19 12:02 [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Biju
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
@ 2026-10-19 12:02 ` Biju
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
2 siblings, 0 replies; 11+ messages in thread
From: Biju @ 2026-10-19 12:02 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Magnus Damm
Cc: Biju Das, Fabrizio Castro, linux-can, devicetree,
linux-renesas-soc, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
From: Biju Das <biju.das.jz@bp.renesas.com>
Document the RZ/G3L (R9A08G046) SoC support.
RZ/G3L has 11 interrupts and 3 CANFD channels compared to 8 interrupts
and 2 CANFD channels on RZ/G3S. RZ/G3L has 288 buffers in total
compared to 192 buffers in RZ/G3S.
Like RZ/G3S, RZ/G3L supports only CAN-FD mode, so renesas,no-can-fd is
disallowed for it, and the description of that property is updated to
exclude RZ/G3L.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v4->v5:
* Dropped the tags as there are new changes.
* Updated the description for renesas,no-can-fd to document RZ/G3L has no
Classical CAN mode.
* Restored maxItems on interrupts and interrupt-names.
* Added resets/reset-names required property for RZ/G3L.
v3->v4:
* Dropped maxItems from interrupts,interrupt-names and resets.
* Collected tag.
v2->v3:
* Collected tag.
v1->v2:
* Updated commit description
* Dropped RZ/G3S fallback as there are lot of differences.
---
.../bindings/net/can/renesas,rcar-canfd.yaml | 32 +++++++++++++++++--
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 7d3330f8fc1a..22980ee1e898 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -14,6 +14,7 @@ properties:
oneOf:
- enum:
- renesas,r9a08g045-canfd # RZ/G3S
+ - renesas,r9a08g046-canfd # RZ/G3L
- renesas,r9a09g047-canfd # RZ/G3E
- renesas,r9a09g077-canfd # RZ/T2H
@@ -146,8 +147,9 @@ properties:
$ref: /schemas/types.yaml#/definitions/flag
description:
The controller can operate in either CAN-FD mode (default) or FD-Only
- mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
- Specify this property to put the controller in Classical CAN mode.
+ mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3L
+ and RZ/G3S). Specify this property to put the controller in Classical CAN
+ mode.
renesas,fd-only:
$ref: /schemas/types.yaml#/definitions/flag
@@ -294,6 +296,27 @@ allOf:
patternProperties:
"^channel[6-7]$": false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: renesas,r9a08g046-canfd
+ then:
+ properties:
+ interrupts:
+ minItems: 11
+ maxItems: 11
+
+ interrupt-names:
+ minItems: 11
+ maxItems: 11
+
+ resets:
+ minItems: 2
+
+ patternProperties:
+ "^channel[3-7]$": false
+
- if:
properties:
compatible:
@@ -334,6 +357,7 @@ allOf:
contains:
enum:
- renesas,r9a08g045-canfd
+ - renesas,r9a08g046-canfd
- renesas,r9a09g047-canfd
- renesas,rzg2l-canfd
then:
@@ -358,7 +382,9 @@ allOf:
properties:
compatible:
contains:
- const: renesas,r9a08g045-canfd
+ enum:
+ - renesas,r9a08g045-canfd
+ - renesas,r9a08g046-canfd
then:
properties:
renesas,no-can-fd: false
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-19 12:02 [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Biju
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
2026-10-19 12:02 ` [PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC Biju
@ 2026-10-20 8:13 ` Krzysztof Kozlowski
2026-10-20 8:20 ` Biju Das
2026-10-20 8:21 ` Marc Kleine-Budde
2 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-20 8:13 UTC (permalink / raw)
To: Biju
Cc: Marc Kleine-Budde, Vincent Mailhol, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Magnus Damm, Biju Das, Fabrizio Castro, linux-can, devicetree,
linux-renesas-soc, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad
On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Add support for Renesas RZ/G3L CANFD.
> The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
> and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
> buffers on RZ/G3S SoC.
>
> This patch series depend upon [1]
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
>
> v4->v5:
b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 5 messages in the thread
Could not find lower series to compare against.
I do not get why you keep making things difficult for review, but it's
your right. I'll skip the patch for some time.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
@ 2026-10-20 8:20 ` Biju Das
2026-10-20 8:21 ` Marc Kleine-Budde
1 sibling, 0 replies; 11+ messages in thread
From: Biju Das @ 2026-10-20 8:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, biju.das.au
Cc: Marc Kleine-Budde, Vincent Mailhol, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
magnus.damm, Fabrizio Castro, linux-can@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Chris Paterson, Prabhakar Mahadev Lad
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 20 October 2026 09:13
> Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
>
> On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Add support for Renesas RZ/G3L CANFD.
> > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > compared to 192 buffers on RZ/G3S SoC.
> >
> > This patch series depend upon [1]
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
> > /commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> >
> > v4->v5:
>
> b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> ---
> Analyzing 5 messages in the thread
> Could not find lower series to compare against.
>
> I do not get why you keep making things difficult for review, but it's your right. I'll skip the patch
> for some time.
Sorry for that, I was not aware switching the mail ID will impact the b4.
Here is previous version[1], please let me know if you want me to resend the
same series with previous mail ID. I am happy to resend.
[1]
https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/
Cheers,
Biju
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
2026-10-20 8:20 ` Biju Das
@ 2026-10-20 8:21 ` Marc Kleine-Budde
2026-10-20 8:30 ` Biju Das
1 sibling, 1 reply; 11+ messages in thread
From: Marc Kleine-Budde @ 2026-10-20 8:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Biju, Vincent Mailhol, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm, Biju Das,
Fabrizio Castro, linux-can, devicetree, linux-renesas-soc,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Add support for Renesas RZ/G3L CANFD.
> > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2 channels
> > and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers compared to 192
> > buffers on RZ/G3S SoC.
> >
> > This patch series depend upon [1]
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> >
> > v4->v5:
>
> b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> ---
> Analyzing 5 messages in the thread
> Could not find lower series to compare against.
>
> I do not get why you keep making things difficult for review, but it's
> your right. I'll skip the patch for some time.
If you use b4 [1] for sending patches, you make things a lot easier for
the reviewers (and yourself).
regards,
Marc
[1] https://b4.docs.kernel.org/en/latest/
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-20 8:21 ` Marc Kleine-Budde
@ 2026-10-20 8:30 ` Biju Das
2026-10-20 12:33 ` Biju Das
0 siblings, 1 reply; 11+ messages in thread
From: Biju Das @ 2026-10-20 8:30 UTC (permalink / raw)
To: Marc Kleine-Budde, Krzysztof Kozlowski
Cc: biju.das.au, Vincent Mailhol, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, magnus.damm, Fabrizio Castro,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, Chris Paterson,
Prabhakar Mahadev Lad
Hi Marc/Krzysztof,
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 20 October 2026 09:21
> Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
>
> On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > Add support for Renesas RZ/G3L CANFD.
> > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > > compared to 192 buffers on RZ/G3S SoC.
> > >
> > > This patch series depend upon [1]
> > > [1]
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.g
> > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > >
> > > v4->v5:
> >
> > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > Checking for older revisions
> > Grabbing search results from lore.kernel.org
> > ---
> > Analyzing 5 messages in the thread
> > Could not find lower series to compare against.
> >
> > I do not get why you keep making things difficult for review, but it's
> > your right. I'll skip the patch for some time.
>
> If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).
Thanks for the pointer. So far, I use "git send-email --annotate *.patch" to send the patches. I need to explore
how to send the patches using b4.
Cheers,
Biju
>
> [1] https://b4.docs.kernel.org/en/latest/
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-20 8:30 ` Biju Das
@ 2026-10-20 12:33 ` Biju Das
2026-10-20 14:58 ` Biju Das
0 siblings, 1 reply; 11+ messages in thread
From: Biju Das @ 2026-10-20 12:33 UTC (permalink / raw)
To: Marc Kleine-Budde, Krzysztof Kozlowski
Cc: biju.das.au, Vincent Mailhol, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, magnus.damm, Fabrizio Castro,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, Chris Paterson,
Prabhakar Mahadev Lad
Hi Marc/Krzysztof,
> -----Original Message-----
> From: Biju Das
> Sent: 20 October 2026 09:31
> Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
>
> Hi Marc/Krzysztof,
>
> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl@pengutronix.de>
> > Sent: 20 October 2026 09:21
> > Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> >
> > On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > >
> > > > Add support for Renesas RZ/G3L CANFD.
> > > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to 2
> > > > channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288 buffers
> > > > compared to 192 buffers on RZ/G3S SoC.
> > > >
> > > > This patch series depend upon [1]
> > > > [1]
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next
> > > > .g
> > > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > > >
> > > > v4->v5:
> > >
> > > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > > Checking for older revisions
> > > Grabbing search results from lore.kernel.org
> > > ---
> > > Analyzing 5 messages in the thread
> > > Could not find lower series to compare against.
> > >
> > > I do not get why you keep making things difficult for review, but
> > > it's your right. I'll skip the patch for some time.
> >
> > If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).
>
> Thanks for the pointer. So far, I use "git send-email --annotate *.patch" to send the patches. I need to
> explore how to send the patches using b4.
I have explored b4. Maybe I can resend the series with b4. But unfortunately, since it is forced version v5,
b4 diff <msg id v5> won't work like whatever Krzysztof tried.
Please let me know.
V5: https://lore.kernel.org/all/20261019120220.166163-1-biju.das.jz@bp.renesas.com/
V4: https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/T/#t
Cheers,
Biju
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
2026-10-20 12:33 ` Biju Das
@ 2026-10-20 14:58 ` Biju Das
0 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2026-10-20 14:58 UTC (permalink / raw)
To: Marc Kleine-Budde, Krzysztof Kozlowski
Cc: biju.das.au, Vincent Mailhol, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, magnus.damm, Fabrizio Castro,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, Chris Paterson,
Prabhakar Mahadev Lad
Hi Krzysztof,
> -----Original Message-----
> From: Biju Das
> Sent: 20 October 2026 13:33
> Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
>
> Hi Marc/Krzysztof,
>
> > -----Original Message-----
> > From: Biju Das
> > Sent: 20 October 2026 09:31
> > Subject: RE: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> >
> > Hi Marc/Krzysztof,
> >
> > > -----Original Message-----
> > > From: Marc Kleine-Budde <mkl@pengutronix.de>
> > > Sent: 20 October 2026 09:21
> > > Subject: Re: [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD
> > >
> > > On 20.10.2026 10:13:13, Krzysztof Kozlowski wrote:
> > > > On Mon, Oct 19, 2026 at 01:02:12PM +0100, Biju wrote:
> > > > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > > >
> > > > > Add support for Renesas RZ/G3L CANFD.
> > > > > The RZ/G3L CANFD IP has 3 channels and 11 interrupts compared to
> > > > > 2 channels and 8 interrupts that of RZ/G3S. RZ/G3L has 288
> > > > > buffers compared to 192 buffers on RZ/G3S SoC.
> > > > >
> > > > > This patch series depend upon [1] [1]
> > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-ne
> > > > > xt
> > > > > .g
> > > > > it/commit/?id=2b4a5055d517b11bf4a5671cef32e4d77bc45626
> > > > >
> > > > > v4->v5:
> > > >
> > > > b4 diff '20261019120220.166163-1-biju.das.jz@bp.renesas.com'
> > > > Looking up 20261019120220.166163-1-biju.das.jz@bp.renesas.com
> > > > Checking for older revisions
> > > > Grabbing search results from lore.kernel.org
> > > > ---
> > > > Analyzing 5 messages in the thread Could not find lower series to
> > > > compare against.
> > > >
> > > > I do not get why you keep making things difficult for review, but
> > > > it's your right. I'll skip the patch for some time.
> > >
> > > If you use b4 [1] for sending patches, you make things a lot easier for the reviewers (and yourself).
> >
> > Thanks for the pointer. So far, I use "git send-email --annotate
> > *.patch" to send the patches. I need to explore how to send the patches using b4.
>
> I have explored b4. Maybe I can resend the series with b4. But unfortunately, since it is forced version
> v5,
> b4 diff <msg id v5> won't work like whatever Krzysztof tried.
>
> Please let me know.
>
> V5: https://lore.kernel.org/all/20261019120220.166163-1-biju.das.jz@bp.renesas.com/
>
> V4: https://lore.kernel.org/all/20261001075742.21961-1-biju.das.jz@bp.renesas.com/T/#t
FYI, Just attaching b4 diff equivalent between the 2 versions
biju@biju:~/linux-next-upstream-b4$ git range-diff master..b4/b4-canfd_rzg3l_v4 master..b4/canfd_rzg3l
1: b0f7cbbdc009 = 1: 49d37ce91cae dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC
2: 89fadc83f0ba = 2: 5b845af145c4 can: rcar_canfd: Fix typos in macro names
3: d50639abd4ad = 3: 489d1144599f can: rcar_canfd: Allow the CAN FD clock to be sourced from fck
4: e95baeb6b106 = 4: 748ae017c40b can: rcar_canfd: Do not set registers selecting the CAN mode
5: 8e9a5b56fc82 = 5: 326f8dd1b40c can: rcar_canfd: Add support for Renesas RZ/G3S
6: 967dc8e78108 = 6: ef2fff76f761 dt-bindings: can: renesas,rcar-canfd: Restrict resets in top-level
7: 2a8901b450a9 < -: ------------ Add support for Renesas RZ/G3L CANFD.
-: ------------ > 7: 7a1167fb59af Add support for Renesas RZ/G3L CANFD
-: ------------ > 8: 0577b28d55c0 dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
-: ------------ > 9: a7643a14339f can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode
8: 3b72a5072b77 ! 10: 0e5f2c6ff23c dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC
@@ Commit message
and 2 CANFD channels on RZ/G3S. RZ/G3L has 288 buffers in total
compared to 192 buffers in RZ/G3S.
- Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
- Link: https://patch.msgid.link/20261001075742.21961-2-biju.das.jz@bp.renesas.com
+ Like RZ/G3S, RZ/G3L supports only CAN-FD mode, so renesas,no-can-fd is
+ disallowed for it, and the description of that property is updated to
+ exclude RZ/G3L.
+
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
+ v4->v5:
+ * Dropped the tags as there are new changes.
+ * Updated the description for renesas,no-can-fd to document RZ/G3L has no
+ Classical CAN mode.
+ * Restored maxItems on interrupts and interrupt-names.
+ * Added resets/reset-names required property for RZ/G3L.
v3->v4:
* Dropped maxItems from interrupts,interrupt-names and resets.
* Collected tag.
@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: properties:
- renesas,r9a09g047-canfd # RZ/G3E
- renesas,r9a09g077-canfd # RZ/T2H
+@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: properties:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ The controller can operate in either CAN-FD mode (default) or FD-Only
+- mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
+- Specify this property to put the controller in Classical CAN mode.
++ mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3L
++ and RZ/G3S). Specify this property to put the controller in Classical CAN
++ mode.
+
+ renesas,fd-only:
+ $ref: /schemas/types.yaml#/definitions/flag
@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
patternProperties:
"^channel[6-7]$": false
@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
+ properties:
+ interrupts:
+ minItems: 11
++ maxItems: 11
+
+ interrupt-names:
+ minItems: 11
++ maxItems: 11
+
+ resets:
+ minItems: 2
@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
- if:
properties:
compatible:
+@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
+ contains:
+ enum:
+ - renesas,r9a08g045-canfd
++ - renesas,r9a08g046-canfd
+ - renesas,r9a09g047-canfd
+ - renesas,rzg2l-canfd
+ then:
@@ Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml: allOf:
properties:
compatible:
9: 5481bef4417d < -: ------------ can: rcar_canfd: Derive max_channels from the device tree
10: bef7311050db < -: ------------ can: rcar_canfd: Add support for Renesas RZ/G3L
-: ------------ > 11: b756a10a565a can: rcar_canfd: Add support for Renesas RZ/G3L
Cheers,
Biju
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
@ 2026-10-20 16:48 ` Rob Herring
2026-10-20 17:17 ` Biju Das
0 siblings, 1 reply; 11+ messages in thread
From: Rob Herring @ 2026-10-20 16:48 UTC (permalink / raw)
To: Biju
Cc: Marc Kleine-Budde, Vincent Mailhol, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, Magnus Damm, Biju Das,
Fabrizio Castro, linux-can, devicetree, linux-renesas-soc,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On Mon, Oct 19, 2026 at 01:02:13PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> The description of the property that selects Classical CAN mode implies
> that every supported SoC can operate in that mode. This is not true for
> RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
>
> Update the description to say that Classical CAN mode is not available on
> RZ/G3S, so the property is not mistakenly used for that SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v5:
> * New patch.
> ---
> .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 1a7a9ce45e97..7d3330f8fc1a 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -146,8 +146,8 @@ properties:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> The controller can operate in either CAN-FD mode (default) or FD-Only
> - mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
> - property to put the controller in Classical CAN mode.
> + mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
> + Specify this property to put the controller in Classical CAN mode.
Can't this be expressed as a schema?
>
> renesas,fd-only:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode
2026-10-20 16:48 ` Rob Herring
@ 2026-10-20 17:17 ` Biju Das
0 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2026-10-20 17:17 UTC (permalink / raw)
To: Rob Herring, biju.das.au
Cc: Marc Kleine-Budde, Vincent Mailhol, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, magnus.damm, Fabrizio Castro,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, Chris Paterson,
Prabhakar Mahadev Lad
Hi Rob,
Thanks for the feedback.
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 20 October 2026 17:49
> Subject: Re: [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN
> mode
>
> On Mon, Oct 19, 2026 at 01:02:13PM +0100, Biju wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > The description of the property that selects Classical CAN mode
> > implies that every supported SoC can operate in that mode. This is not
> > true for RZ/G3S, whose CAN-FD controller supports only CAN-FD mode.
> >
> > Update the description to say that Classical CAN mode is not available
> > on RZ/G3S, so the property is not mistakenly used for that SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v5:
> > * New patch.
> > ---
> > .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > index 1a7a9ce45e97..7d3330f8fc1a 100644
> > ---
> > a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yam
> > +++ l
> > @@ -146,8 +146,8 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/flag
> > description:
> > The controller can operate in either CAN-FD mode (default) or FD-Only
> > - mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this
> > - property to put the controller in Classical CAN mode.
> > + mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode(except RZ/G3S}.
> > + Specify this property to put the controller in Classical CAN mode.
>
> Can't this be expressed as a schema?
OK. I'll express this in the schema with an if/then that disallows renesas,no-can-fd for renesas,r9a08g045-canfd, and Will update the description as "Specify this property to put the controller in Classical CAN mode"
and will remove the unwanted description "The controller can operate in either CAN-FD mode (default) or FD-Only mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode."
- if:
properties:
compatible:
contains:
const: renesas,r9a08g045-canfd
then:
properties:
renesas,no-can-fd: false
Cheers,
Biju
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-20 17:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-19 12:02 [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Biju
2026-10-19 12:02 ` [PATCH v5 1/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S has no Classical CAN mode Biju
2026-10-20 16:48 ` Rob Herring
2026-10-20 17:17 ` Biju Das
2026-10-19 12:02 ` [PATCH v5 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC Biju
2026-10-20 8:13 ` [PATCH v5 0/4] Add support for Renesas RZ/G3L CANFD Krzysztof Kozlowski
2026-10-20 8:20 ` Biju Das
2026-10-20 8:21 ` Marc Kleine-Budde
2026-10-20 8:30 ` Biju Das
2026-10-20 12:33 ` Biju Das
2026-10-20 14:58 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox