[PATCH] ASoC: dt-bindings: an7581-afe: add support for reset and secondary IRQ conf

[PATCH] ASoC: dt-bindings: an7581-afe: add support for reset and secondary IRQ conf

[Christian Marangi]

Driver got support for configuring the secondary IRQ configuration to
support full-duplex mode (playback and capture at the same time) and also
to reset via the dedicated SoC reset line.

Add the property to support it and make update the example accordingly for
a more specific register mapping.

Also add the missing #sound-dai-cells property required for the generic
sound node structure.

Previous register node definition doesn't prevent normal execution of the
AFE driver as the additional IRQ register is placed at the end of all the
previous AFE configurations.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../bindings/sound/airoha,an7581-afe.yaml     | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
index 80d9e87f1470..86d006559436 100644
--- a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
+++ b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
@@ -14,15 +14,25 @@ properties:
     const: airoha,an7581-afe
 
   reg:
-    maxItems: 1
+    items:
+      - description: base AFE register
+      - description: secondary IRQ option register
 
   interrupts:
     maxItems: 1
 
+  resets:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    const: 0
+
 required:
   - compatible
   - reg
   - interrupts
+  - resets
+  - '#sound-dai-cells'
 
 additionalProperties: false
 
@@ -30,12 +40,17 @@ examples:
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/reset/airoha,en7581-reset.h>
 
     afe@1fbe2200 {
         compatible = "airoha,an7581-afe";
-        reg = <0x1fbe2200 0x9000>;
+        reg = <0x1fbe2200 0x100>,
+              <0x1fbe2f00 0x100>;
 
         interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+        resets = <&scuclk EN7581_I2S_RST>;
+
+        #sound-dai-cells = <0>;
     };
 
 ...
-- 
2.55.0

Re: [PATCH] ASoC: dt-bindings: an7581-afe: add support for reset and secondary IRQ conf

[Krzysztof Kozlowski]

On Mon, Oct 26, 2026 at 11:10:24AM +0100, Christian Marangi wrote:
> Driver got support for configuring the secondary IRQ configuration to

This is confusing wording, I see no commit adding support which is
implied by "got support". "Got" meaning it never had one but at some
point it "got" it. When?

> support full-duplex mode (playback and capture at the same time) and also
> to reset via the dedicated SoC reset line.
> 
> Add the property to support it and make update the example accordingly for
> a more specific register mapping.
> 
> Also add the missing #sound-dai-cells property required for the generic
> sound node structure.
> 
> Previous register node definition doesn't prevent normal execution of the
> AFE driver as the additional IRQ register is placed at the end of all the
> previous AFE configurations.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  .../bindings/sound/airoha,an7581-afe.yaml     | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> index 80d9e87f1470..86d006559436 100644
> --- a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> +++ b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> @@ -14,15 +14,25 @@ properties:
>      const: airoha,an7581-afe
>  
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: base AFE register
> +      - description: secondary IRQ option register

That's ABI break but maybe just original commit adding the binding was
incorrect.

>  
>    interrupts:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
> +  - resets

Another ABI break. Please explain in the commit msg what is happening.

Best regards,
Krzysztof