Re: [PATCH 2/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC

[Jacky Huang <jackyhuang@nvidia.com>]

On Thu, Oct 29, 2026 at 05:13:56AM +0000, sashiko-bot@kernel.org wrote:
> Similarly, further down in this file, the pca6408@20 expanders on
> &i2c_mcio_c0_south0 and &i2c_mcio_c1_south0 define identical "GPU1_*"
> gpio-line-names, and the pca6408@20 expanders on &i2c_mcio_c0c1_north3 and
> &i2c_mcio_c0c1_north6 define identical "E1S_*" gpio-line-names. Should those
> line names be disambiguated (for example with C1/C2 prefixes) so that
> consumers can address both instances by name?

These are alternative placements for different configurations. I'll
drop the C1 ones in v2, so the DTS only describes the C2 board and the
names become unique.

[ ... ]

> [Severity: High]
> Should i2c-mux@70, i2c-mux@71, and i2c-mux@75 on &i2c4 include the
> i2c-mux-idle-disconnect property (like the pca9546 muxes on &i2c6 and &i2c9)?

The muxes on i2c4 intentionally don't use i2c-mux-idle-disconnect.
Each of them carries MCTP-over-I2C channels, and MCTP endpoints send
their responses back to the BMC as separate transfers through the
selected channel. With idle-disconnect the channel is closed right
after the request, so responses can get lost. So I'd like to keep
them as is.

Thanks,
Jacky