[PATCH 0/2] Add rockchip-timer for RK356X

[PATCH 0/2] Add rockchip-timer for RK356X

[Chris Morgan]

From: Chris Morgan <macromorgan@hotmail.com>

Add the rockchip-timer to the RK356x SoC. The timer for the RK356x is
register compatible with the rk3288. Address range taken from BSP
device tree and confirmed with rk3568 technical reference manual.

Chris Morgan (2):
  dt-bindings: timer: rockchip: Add rk3568 compatible
  arm64: dts: rockchip: Add timer node for rk356x

 .../devicetree/bindings/timer/rockchip,rk-timer.yaml      | 1 +
 arch/arm64/boot/dts/rockchip/rk356x-base.dtsi             | 8 ++++++++
 2 files changed, 9 insertions(+)

-- 
2.53.0

[PATCH 1/2] dt-bindings: timer: rockchip: Add rk3568 compatible

[Chris Morgan]

From: Chris Morgan <macromorgan@hotmail.com>

Add compatible string for Rockchip RK3568 timer.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml
index 6d0eb0014eee..b245a3051d66 100644
--- a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml
+++ b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml
@@ -24,6 +24,7 @@ properties:
               - rockchip,rk3228-timer
               - rockchip,rk3229-timer
               - rockchip,rk3368-timer
+              - rockchip,rk3568-timer
               - rockchip,rk3576-timer
               - rockchip,rk3588-timer
               - rockchip,px30-timer
-- 
2.53.0

[PATCH 2/2] arm64: dts: rockchip: Add timer node for rk356x

[Chris Morgan]

From: Chris Morgan <macromorgan@hotmail.com>

Add the timer node for the rk356x. The timer is present at the SoC
level and is register compatible with the rk3288 timer.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
index 1a4562df20ee..cc3faeb9a86d 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
@@ -1373,6 +1373,14 @@ i2c5: i2c@fe5e0000 {
 		status = "disabled";
 	};
 
+	timer0: timer@fe5f0000 {
+		compatible = "rockchip,rk3568-timer", "rockchip,rk3288-timer";
+		reg = <0x0 0xfe5f0000 0x0 0x1000>;
+		interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru PCLK_TIMER>, <&cru CLK_TIMER0>;
+		clock-names = "pclk", "timer";
+	};
+
 	wdt: watchdog@fe600000 {
 		compatible = "rockchip,rk3568-wdt", "snps,dw-wdt";
 		reg = <0x0 0xfe600000 0x0 0x100>;
-- 
2.53.0

Re: [PATCH 1/2] dt-bindings: timer: rockchip: Add rk3568 compatible

[Heiko Stübner]

Hi Chris,

Am Dienstag, 3. November 2026, 16:31:43 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add compatible string for Rockchip RK3568 timer.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 +

Please make sure to check get_maintainers to catch all needed recipients.

# scripts/get_maintainer.pl -f Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml

you're especially missing the clocksource maintainers:
    Daniel Lezcano <daniel.lezcano@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS,in file)
    Thomas Gleixner <tglx@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS)

and some additional lists:
    linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOCKEVENT DRIVERS)
    linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)

the clocksource part does not seem to have a dedicated list, so
linux-kernel should be included.


Heiko

Re: [PATCH 1/2] dt-bindings: timer: rockchip: Add rk3568 compatible

[Chris Morgan]

On Tue, Nov 03, 2026 at 06:01:37PM +0100, Heiko Stübner wrote:
> Hi Chris,
> 
> Am Dienstag, 3. November 2026, 16:31:43 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add compatible string for Rockchip RK3568 timer.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 +
> 
> Please make sure to check get_maintainers to catch all needed recipients.
> 
> # scripts/get_maintainer.pl -f Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml
> 
> you're especially missing the clocksource maintainers:
>     Daniel Lezcano <daniel.lezcano@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS,in file)
>     Thomas Gleixner <tglx@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS)
> 
> and some additional lists:
>     linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOCKEVENT DRIVERS)
>     linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
> 
> the clocksource part does not seem to have a dedicated list, so
> linux-kernel should be included.
> 
> 
> Heiko
> 
> 

I apologize, sorry about that. I assumed since I was only modifying the
device-tree and bindings I didn't need to copy the rest of the teams.

Should I resubmit with the additional names?

Thank you,
Chris

Re: [PATCH 1/2] dt-bindings: timer: rockchip: Add rk3568 compatible

[Heiko Stübner]

Am Dienstag, 3. November 2026, 19:07:19 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> On Tue, Nov 03, 2026 at 06:01:37PM +0100, Heiko Stübner wrote:
> > Hi Chris,
> > 
> > Am Dienstag, 3. November 2026, 16:31:43 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> > > From: Chris Morgan <macromorgan@hotmail.com>
> > > 
> > > Add compatible string for Rockchip RK3568 timer.
> > > 
> > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml | 1 +
> > 
> > Please make sure to check get_maintainers to catch all needed recipients.
> > 
> > # scripts/get_maintainer.pl -f Documentation/devicetree/bindings/timer/rockchip,rk-timer.yaml
> > 
> > you're especially missing the clocksource maintainers:
> >     Daniel Lezcano <daniel.lezcano@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS,in file)
> >     Thomas Gleixner <tglx@kernel.org> (maintainer:CLOCKSOURCE, CLOCKEVENT DRIVERS)
> > 
> > and some additional lists:
> >     linux-kernel@vger.kernel.org (open list:CLOCKSOURCE, CLOCKEVENT DRIVERS)
> >     linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
> > 
> > the clocksource part does not seem to have a dedicated list, so
> > linux-kernel should be included.
> > 
> > 
> > Heiko
> > 
> > 
> 
> I apologize, sorry about that. I assumed since I was only modifying the
> device-tree and bindings I didn't need to copy the rest of the teams.
> 
> Should I resubmit with the additional names?

very likely ... i.e. the binding is generally going through the driver-tree
here the tree holding the clocksource drivers.

For me to apply the binding, I'd definitly need an Ack from the clocksource
people.


Heiko

[PATCH 2/2] arm64: dts: rockchip: Add timer node for rk356x

[Chris Morgan]

From: Chris Morgan <macromorgan@hotmail.com>

Add the timer node for the rk356x. The timer is present at the SoC
level and is register compatible with the rk3288 timer.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
index 1a4562df20ee..cc3faeb9a86d 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
@@ -1373,6 +1373,14 @@ i2c5: i2c@fe5e0000 {
 		status = "disabled";
 	};
 
+	timer0: timer@fe5f0000 {
+		compatible = "rockchip,rk3568-timer", "rockchip,rk3288-timer";
+		reg = <0x0 0xfe5f0000 0x0 0x1000>;
+		interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru PCLK_TIMER>, <&cru CLK_TIMER0>;
+		clock-names = "pclk", "timer";
+	};
+
 	wdt: watchdog@fe600000 {
 		compatible = "rockchip,rk3568-wdt", "snps,dw-wdt";
 		reg = <0x0 0xfe600000 0x0 0x100>;
-- 
2.53.0