Re: [PATCH 2/4] dt-bindings: iio: light: sharp,gp2ap020a00f: Add GP2AP030A00F

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 08 Nov 2026 00:31:34 +0100
Linus Walleij <linusw@kernel.org> wrote:

> The GP2AP030A00F uses the same register address layout and interrupt
> interface as the GP2AP020A00F, but returns raw clear and infrared counts
> instead of providing automatic illuminance calculation. Describe it in
> the existing binding with its own compatible.
> 
> Keep the core and I/O pull-up supplies optional so boards with hardwired
> power do not have to describe them.

If they are needed for the chip to function we tend to require them
anyway.  That's not to say the driver enforces it, but just that
the binding indicates they should be there.  DT files can just
spin up a fixed regulator if it is always on.

The extra bit of led power description perhaps would be better
in the previous patch given it isn't related to the new part introduction
in a direct way.

> 
> Datasheet: https://global.sharp/products/device/lineup/data/pdf/datasheet/gp2ap030a00f_e.pdf
> Datasheet: https://jp.sharp/products/device/doc/opto/gp2ap030a00f_appl_e.pdf
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  .../devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml  | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml
> index d4bcca0f2d0a..45f1b53d6d7b 100644
> --- a/Documentation/devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml
> @@ -4,17 +4,22 @@
>  $id: http://devicetree.org/schemas/iio/light/sharp,gp2ap020a00f.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Sharp GP2AP020A00F I2C Proximity/ALS sensor
> +title: Sharp GP2AP020A00F and GP2AP030A00F proximity and ambient light sensors
>  
>  maintainers:
>    - Kyungmin Park <kyungmin.park@samsung.com>
>  
>  description: |
> -  The proximity detector sensor requires power supply for its built-in led.
> +  The sensors provide digital clear, infrared and proximity measurements.
> +  The GP2AP020A00F can also calculate illuminance internally, while the
> +  GP2AP030A00F exposes raw clear and infrared photodiode counts.
> +  The proximity detector requires a power supply for its built-in LED.
>  
>  properties:
>    compatible:
> -    const: sharp,gp2ap020a00f
> +    enum:
> +      - sharp,gp2ap020a00f
> +      - sharp,gp2ap030a00f
>  
>    reg:
>      maxItems: 1
> @@ -28,7 +33,8 @@ properties:
>    vio-supply:
>      description: Supply for the I2C and interrupt pull-up resistors.
>  
> -  vled-supply: true
> +  vled-supply:
> +    description: Infrared LED anode power supply (LEDA).
Not related to rest of the patch.

Does explain the mention of the vled in the previous description though!
Now I understand you were referring to what was already supported
rather than what the patch did.

>  
>  additionalProperties: false
>  
>