Re: [PATCH 3/4] iio: light: gp2ap020a00f: Enable the core and I/O supplies

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 08 Nov 2026 00:31:35 +0100
Linus Walleij <linusw@kernel.org> wrote:

> Enable the optional vdd and vio supplies before accessing the device.
> Use managed helpers so both supplies are disabled on probe failure and
> removal. Continue probing when an optional supply is absent, while
> propagating other errors, including deferred probe.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  drivers/iio/light/gp2ap020a00f.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
> index b435dc5e8706..62c4beb20cce 100644
> --- a/drivers/iio/light/gp2ap020a00f.c
> +++ b/drivers/iio/light/gp2ap020a00f.c
> @@ -1414,6 +1414,14 @@ static int gp2ap020a00f_probe(struct i2c_client *client)
>  
>  	data = iio_priv(indio_dev);
>  
> +	err = devm_regulator_get_enable_optional(dev, "vdd");
> +	if (err && err != -ENODEV)
> +		return dev_err_probe(dev, err, "Failed to enable core supply\n");
> +
> +	err = devm_regulator_get_enable_optional(dev, "vio");
> +	if (err && err != -ENODEV)
> +		return dev_err_probe(dev, err, "Failed to enable I/O supply\n");

Just use devm_regulator_get_enable() and the regulator
framework should supply stub regulators if they aren't
specified.  The optional bit here is for when we do
something different if they aren't wired (usually for IIO that
means using an internal reference rather than an external one).

Jonathan

> +
>  	data->vled_reg = devm_regulator_get(dev, "vled");
>  	if (IS_ERR(data->vled_reg))
>  		return PTR_ERR(data->vled_reg);
>