Devicetree
 help / color / mirror / Atom feed
From: Amir Hanip <killdeath104@gmail.com>
To: barnabas.czeman@mainlining.org
Cc: a39skl@gmail.com, abelvesa@kernel.org, andersson@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	konrad.dybcio@oss.qualcomm.com, konradybcio@kernel.org,
	krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: sm6115-xiaomi-lemon: Split out a common dtsi
Date: Thu, 12 Nov 2026 03:03:49 +0700	[thread overview]
Message-ID: <20261111200349.6588-1-killdeath104@gmail.com> (raw)
In-Reply-To: <daea291c5b5d3b1ff87bbeaac4b08083@mainlining.org>

On 2026-11-07 19:26, Barnabas Czeman wrote:
> You should not override rpm_request node here, you can use the labels
> from the common to change the ranges like:
> &pm6125_s7 {
>     regulator-min-microvolt = <1280000>;
>     regulator-max-microvolt = <2080000>;
> };
> [...]
> Please add the missing regulators.

Hi Barnabas,

Thanks, understood. In v4 the common dtsi will define all the PM6125
regulators with their labels, and lemon and citrus will only change
the ranges that differ through those labels, without overriding
rpm_requests. I assume that by the missing regulators you mean the
ones that lemon.dts still defines (s7, l5, l7, l11, l17, l18, l22 and
l24). Is that right?

About your previous mail: thanks for the dumps. In v4 I will move the
ADSP and GPU carve-outs to the common dtsi with the values from your
MIUI dump (ADSP 0x53800000/0x2200000, GPU 0x55a15000/0x2000), as a
separate patch from the pure split, so it can be reviewed on its own.
It changes lemon's compiled DT: the ADSP region shrinks by 4 MiB and
the GPU region moves away from 0xfa400000.

I can only test citrus. Would you, or Adam, be able to test the lemon
patches in v4? A Tested-by would help a lot.

Sashiko points out that WiFi bypasses the wcn3950-pmu regulators.
WiFi works on citrus as is, but I will route its supplies through
vreg_pmu_xo/rf/ch0 like qrb2210-rb1 does and test it before v4.

Thanks,
Amir

  reply	other threads:[~2026-11-11 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 14:14 [PATCH v3 0/3] arm64: dts: qcom: Add Xiaomi Poco M3 (citrus) Amir Hanip
2026-11-07 14:14 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Document Xiaomi Poco M3 Amir Hanip
2026-11-07 14:14 ` [PATCH v3 2/3] arm64: dts: qcom: sm6115-xiaomi-lemon: Split out a common dtsi Amir Hanip
2026-11-07 17:49   ` Barnabás Czémán
2026-11-07 18:26   ` Barnabás Czémán
2026-11-11 20:03     ` Amir Hanip [this message]
2026-11-07 14:14 ` [PATCH v3 3/3] arm64: dts: qcom: Add Xiaomi Poco M3 Amir Hanip
2026-11-07 14:34   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111200349.6588-1-killdeath104@gmail.com \
    --to=killdeath104@gmail.com \
    --cc=a39skl@gmail.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox