Re: [PATCH v3 3/3] arm64: dts: qcom: Add Xiaomi Poco M3

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: citrus: wifi node bypasses wcn3950-pmu
  regulators
--

commit 143f785de163a225c81347bf706860097515c0a4
Author: Amir Hanip <killdeath104@gmail.com>

arm64: dts: qcom: Add Xiaomi Poco M3

This commit adds the initial device tree for the SM6115-based Xiaomi Poco
M3 (citrus).

> diff --git a/arch/arm64/boot/dts/qcom/sm6115-xiaomi-citrus.dts b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-citrus.dts
> new file mode 100644
> index 0000000000000..03544f28f06cd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-citrus.dts
> @@ -0,0 +1,237 @@
[ ... ]
> +	wcn3950-pmu {
> +		compatible = "qcom,wcn3950-pmu";
> +
> +		pinctrl-0 = <&sw_ctrl_default>;
> +		pinctrl-names = "default";
> +
> +		vddio-supply = <&pm6125_l9>;
> +		vddxo-supply = <&pm6125_l16>;
> +		vddrf-supply = <&pm6125_l17>;
> +		vddch0-supply = <&pm6125_l23>;
> +
> +		swctrl-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>;
> +
> +		regulators {
> +			vreg_pmu_io: ldo0 {
> +				regulator-name = "vreg_pmu_io";
> +			};
> +
> +			vreg_pmu_xo: ldo1 {
> +				regulator-name = "vreg_pmu_xo";
> +			};
> +
> +			vreg_pmu_rf: ldo2 {
> +				regulator-name = "vreg_pmu_rf";
> +			};
> +
> +			vreg_pmu_ch0: ldo3 {
> +				regulator-name = "vreg_pmu_ch0";
> +			};
> +
> +			vreg_pmu_ch1: ldo4 {
> +				regulator-name = "vreg_pmu_ch1";
> +			};
> +		};
> +	};
> +};
[ ... ]
> +&wifi {
> +	vdd-0.8-cx-mx-supply = <&pm6125_l4>;
> +	vdd-1.8-xo-supply = <&pm6125_l16>;
> +	vdd-1.3-rfa-supply = <&pm6125_l17>;
> +	vdd-3.3-ch0-supply = <&pm6125_l23>;
> +	vdd-3.3-ch1-supply = <&pm6125_l24>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Should the wifi node consume the wcn3950-pmu regulator outputs
(vreg_pmu_xo, vreg_pmu_rf, vreg_pmu_ch0) instead of referencing the
pm6125_l* regulators directly?

pwrseq_qcom_wcn3990_match() matches the WiFi device by checking whether
vdd-1.8-xo-supply is a child regulator of wcn3950-pmu.  Because
vdd-1.8-xo-supply points to pm6125_l16 under rpm-requests,
devm_pwrseq_get(&pdev->dev, "wlan") in ath10k_snoc_probe() fails to match
and falls back to ar_snoc->pwrseq = NULL.  This bypasses the WCN3950
power sequence and never votes for wcn3950-pmu's vddio-supply
(pm6125_l9), leaving vddio unpowered when Bluetooth is off or disabling
it when Bluetooth powers down while WiFi is active.

In addition, vdd-3.3-ch1-supply is wired to pm6125_l24 (the UFS vcc
supply in sm6115-xiaomi-lime-common.dtsi) while wcn3950-pmu defines
vreg_pmu_ch1 without a vddch1-supply input, and vdd-0.8-cx-mx-supply
points to pm6125_l4 (the 0.9V USB/UFS PHY supply) rather than pm6125_l8.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107141432.39099-1-killdeath104@gmail.com?part=3