Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Jisheng Zhang <jszhang@kernel.org>,
	Fei Xie <fei.xie@horizon.auto>, Pratyush Yadav <p.yadav@ti.com>,
	Parshuram Thombare <pthombar@cadence.com>,
	Konrad Kociolek <konrad@cadence.com>,
	Mark Brown <broonie@kernel.org>,
	Jayshri Pawar <jpawar@cadence.com>
Subject: Re: [PATCH v2 6/8] spi: dt-bindings: cdns,xspi: add ADI SC846 compatible
Date: Thu, 12 Nov 2026 18:09:36 +0000	[thread overview]
Message-ID: <20261112-sincerity-snuff-9451330d3ed5@spud> (raw)
In-Reply-To: <avWJrWwHe5ApSUbT@nsa>

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

On Thu, Nov 12, 2026 at 09:41:17AM +0000, Nuno Sá wrote:
> On Thu, Nov 12, 2026 at 09:32:36AM +0000, Nuno Sá wrote:
> > On Wed, Nov 11, 2026 at 05:58:09PM +0000, Conor Dooley wrote:
> > > On Wed, Nov 11, 2026 at 01:23:07PM +0000, Nuno Sá wrote:
> > > > The Analog Devices ADSP-SC846 SoC integrates the Cadence xSPI controller
> > > > with its own PHY timing configuration and with the support needed for
> > > > the auto command (ACMD) mode with the internal DMA, so it cannot be
> > > > described by the generic "cdns,xspi-nor" compatible. Add a SoC specific
> > > > compatible for it.
> > > 
> > > I assume it's the phy timing that means the cdns,xspi-nor compatible
> > > cannot be used as a fallback?
> > 
> > Exactly. Without proper phy settings we cannot probe the memory chips.
> > There are some works being done to support phy tuning but even when
> > that lands, not sure how generic it could be supported.
> > 
> > Hmm, I guess you want the above mentioned in the commit right? 
> 
> Nevermind, it's already in there.

ye I just wanted to clarify, because it wasn't entirely clear that this
made it incompatible since I'm not a domain expert.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-12 18:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 13:23 [PATCH v2 0/8] spi: cadence-xspi: add ACMD mode and ADSP SC846 integration Nuno Sá
2026-11-11 13:23 ` [PATCH v2 1/8] spi: cadence-xspi: fail on command errors without a known cause Nuno Sá
2026-11-11 13:23 ` [PATCH v2 2/8] spi: cadence-xspi: wait for the controller initialization on resume Nuno Sá
2026-11-11 14:16   ` sashiko-bot
2026-11-11 13:23 ` [PATCH v2 3/8] spi: dt-bindings: cdns,xspi: add clocks and resets Nuno Sá
2026-11-11 17:57   ` Conor Dooley
2026-11-11 13:23 ` [PATCH v2 4/8] spi: cadence-xspi: support " Nuno Sá
2026-11-11 13:23 ` [PATCH v2 5/8] spi: cadence-xspi: move platform specifics into driver data Nuno Sá
2026-11-11 13:23 ` [PATCH v2 6/8] spi: dt-bindings: cdns,xspi: add ADI SC846 compatible Nuno Sá
2026-11-11 17:58   ` Conor Dooley
2026-11-12  9:32     ` Nuno Sá
2026-11-12  9:41       ` Nuno Sá
2026-11-12 18:09         ` Conor Dooley [this message]
2026-11-11 13:23 ` [PATCH v2 7/8] spi: cadence-xspi: add ADI SC846 platform support Nuno Sá
2026-11-11 13:23 ` [PATCH v2 8/8] spi: cadence-xspi: add ACMD mode support Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112-sincerity-snuff-9451330d3ed5@spud \
    --to=conor@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fei.xie@horizon.auto \
    --cc=jpawar@cadence.com \
    --cc=jszhang@kernel.org \
    --cc=konrad@cadence.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=p.yadav@ti.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pthombar@cadence.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox