Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Lee Jones <lee@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	mfd@lists.linux.dev, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: abx500: Convert to DT schema
Date: Thu, 12 Nov 2026 08:05:11 -0600	[thread overview]
Message-ID: <20261112140511.GA360436-robh@kernel.org> (raw)
In-Reply-To: <20261110-ux500-pinctrl-bindings-v1-1-a9f0e9d12d19@kernel.org>

On Tue, Nov 10, 2026 at 10:58:33AM +0100, Linus Walleij wrote:
> Describe the ABx500 GPIO and pin controller in DT schema, including
> the nested mux and configuration groups used by existing boards.
> Reference this schema from the AB8500 MFD instead of rejecting all
> pin configuration children. Found with CHECK_DTBS=1.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  .../devicetree/bindings/mfd/stericsson,ab8500.yaml |  16 +-
>  .../devicetree/bindings/pinctrl/ste,abx500.txt     | 318 ---------------------
>  .../bindings/pinctrl/stericsson,abx500.yaml        |  68 +++++
>  3 files changed, 69 insertions(+), 333 deletions(-)

[...]

> diff --git a/Documentation/devicetree/bindings/pinctrl/stericsson,abx500.yaml b/Documentation/devicetree/bindings/pinctrl/stericsson,abx500.yaml
> new file mode 100644
> index 000000000000..59ca14992427
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/stericsson,abx500.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/stericsson,abx500.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST-Ericsson AB8500 and AB8505 GPIO and pin controller
> +
> +maintainers:
> +  - Linus Walleij <linusw@kernel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - stericsson,ab8500-gpio
> +      - stericsson,ab8505-gpio
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-line-names:
> +    minItems: 1
> +    maxItems: 53
> +
> +patternProperties:
> +  '^(?!phandle$|compatible$|gpio-controller$|gpio-line-names$|pinctrl-[0-9]+$|pinctrl-names$)[a-zA-Z0-9_-]+$':

Yuck! Looks like you want just any name which can be expressed as:

additionalProperties:
  $ref: '#/$defs/config-node'


> +    $ref: '#/$defs/config-node'
> +
> +required:
> +  - compatible
> +  - gpio-controller
> +  - '#gpio-cells'
> +
> +additionalProperties: false
> +
> +$defs:
> +  config-node:
> +    type: object
> +    allOf:
> +      - $ref: pincfg-node.yaml#
> +      - $ref: pinmux-node.yaml#
> +    patternProperties:
> +      '^(?!phandle$|pins$|groups$|function$|bias-.*$|drive-.*$|input-.*$|output-.*$|power-source$|slew-rate$|low-power-.*$|persist-state$|skew-delay$)[a-zA-Z0-9_-]+$':
> +        $ref: '#/$defs/config-node'
> +    unevaluatedProperties: false

       unevaluatedProperties:
         $ref: '#/$defs/config-node'

Rob

  reply	other threads:[~2026-11-12 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  9:58 [PATCH 0/2] dt-bindings: pinctrl: Convert ABx500 and Nomadik bindings to schema Linus Walleij
2026-11-10  9:58 ` [PATCH 1/2] dt-bindings: pinctrl: abx500: Convert to DT schema Linus Walleij
2026-11-12 14:05   ` Rob Herring [this message]
2026-11-10  9:58 ` [PATCH 2/2] dt-bindings: pinctrl: nomadik: " Linus Walleij
2026-11-10 10:16   ` sashiko-bot
2026-11-12 14:06   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112140511.GA360436-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox