Devicetree
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	"Nagarjuna Kristam" <nkristam@nvidia.com>,
	JC Kuo <jckuo@nvidia.com>,
	Mathias Nyman <mathias.nyman@intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	Wayne Chang <waynec@nvidia.com>,
	Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH v2 08/12] usb: gadget: tegra-xudc: Preserve runtime PM across system suspend
Date: Mon, 16 Nov 2026 15:24:05 +0000	[thread overview]
Message-ID: <20261116-tegra-usb-v2-8-42efc03a9700@nvidia.com> (raw)
In-Reply-To: <20261116-tegra-usb-v2-0-42efc03a9700@nvidia.com>

The system suspend callback leaves an already runtime-suspended
controller alone, but the system resume callback unconditionally
activates it. This enables clocks and regulators while runtime PM still
considers the device suspended. A subsequent runtime resume activates
the controller again, unbalancing the clock and regulator enable counts.

Only activate the controller during system resume if it is not runtime
suspended. Enable runtime PM before scheduling USB role work so that the
worker can resume the controller when entering device mode.

Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mode controller")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/usb/gadget/udc/tegra-xudc.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index b2af5107747c..43a1940ed88a 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -4039,9 +4039,13 @@ static int __maybe_unused tegra_xudc_resume(struct device *dev)
 	unsigned long flags;
 	int err;
 
-	err = tegra_xudc_unpowergate(xudc);
-	if (err < 0)
-		return err;
+	if (!pm_runtime_status_suspended(dev)) {
+		err = tegra_xudc_unpowergate(xudc);
+		if (err < 0)
+			return err;
+	}
+
+	pm_runtime_enable(dev);
 
 	spin_lock_irqsave(&xudc->lock, flags);
 	xudc->suspended = false;
@@ -4049,8 +4053,6 @@ static int __maybe_unused tegra_xudc_resume(struct device *dev)
 		schedule_work(&xudc->usb_role_sw_work);
 	spin_unlock_irqrestore(&xudc->lock, flags);
 
-	pm_runtime_enable(dev);
-
 	return 0;
 }
 

-- 
2.43.0


  parent reply	other threads:[~2026-11-16 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 15:23 [PATCH v2 00/12] usb: Add support for Tegra238 and device support for Tegra264 Jon Hunter
2026-11-16 15:23 ` [PATCH v2 01/12] dt-bindings: usb: tegra234-xusb: Add required properties Jon Hunter
2026-11-16 15:23 ` [PATCH v2 02/12] dt-bindings: usb: Add Tegra238 XUSB host controller support Jon Hunter
2026-11-16 15:38   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 03/12] dt-bindings: usb: tegra-xudc: Add Tegra238 XUDC support Jon Hunter
2026-11-16 15:24 ` [PATCH v2 04/12] dt-bindings: usb: tegra-xudc: Add Tegra264 " Jon Hunter
2026-11-16 15:24 ` [PATCH v2 05/12] usb: xhci: tegra: Fix missing semi-colon Jon Hunter
2026-11-16 15:24 ` [PATCH v2 06/12] usb: xhci: tegra: Add support for Tegra238 Jon Hunter
2026-11-16 15:24 ` [PATCH v2 07/12] usb: gadget: tegra-xudc: Fix CNT65 configuration Jon Hunter
2026-11-16 15:24 ` Jon Hunter [this message]
2026-11-16 15:24 ` [PATCH v2 09/12] usb: gadget: tegra-xudc: Add support for Tegra238 Jon Hunter
2026-11-16 15:54   ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 10/12] usb: gadget: tegra-xudc: Add SSPX register offset to SoC data Jon Hunter
2026-11-16 15:24 ` [PATCH v2 11/12] usb: gadget: tegra-xudc: Add default settings " Jon Hunter
2026-11-16 15:24 ` [PATCH v2 12/12] usb: gadget: tegra-xudc: Add support for Tegra264 Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116-tegra-usb-v2-8-42efc03a9700@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jckuo@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=nkristam@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thierry.reding@kernel.org \
    --cc=treding@nvidia.com \
    --cc=waynec@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox