From: sashiko-bot@kernel.org
To: "Jon Hunter" <jonathanh@nvidia.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 02/12] dt-bindings: usb: Add Tegra238 XUSB host controller support
Date: Mon, 16 Nov 2026 15:38:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-217310@kernel.org> (raw)
In-Reply-To: <20261116-tegra-usb-v2-2-42efc03a9700@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: usb: unwieldy per-compatible conditionals for
tegra238-xusb
--
commit 68b69d5e79cc5b22a7419c3753f57282df3a1a08
Author: Jon Hunter <jonathanh@nvidia.com>
dt-bindings: usb: Add Tegra238 XUSB host controller support
This commit adds Device Tree binding support for the Tegra238 XUSB host
controller to nvidia,tegra234-xusb.yaml, constraining its PHYs and
interrupts and requiring direct resets instead of power domains.
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
> index 4e4d7fc352f15..989cce0bb52c1 100644
> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
[ ... ]
> @@ -162,11 +173,44 @@ required:
> - nvidia,xusb-padctl
> - phys
> - phy-names
> - - power-domains
> - - power-domain-names
>
> allOf:
> - $ref: usb-xhci.yaml
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nvidia,tegra238-xusb
> + then:
> + properties:
> + interrupts:
> + maxItems: 8
> + iommus:
> + maxItems: 1
> + power-domains: false
> + power-domain-names: false
> + phys:
> + maxItems: 6
> + phy-names:
> + maxItems: 6
> + items:
> + enum:
> + - usb2-0
> + - usb2-1
> + - usb2-2
> + - usb3-0
> + - usb3-1
> + - usb3-2
> + required:
> + - resets
> + - reset-names
> + else:
> + properties:
> + resets: false
> + reset-names: false
> + required:
> + - power-domains
> + - power-domain-names
[Severity: Low]
This isn't a bug, but would nvidia,tegra238-xusb be cleaner as a separate
binding schema document rather than adding another large conditional block to
nvidia,tegra234-xusb.yaml?
Tegra238 differs substantially from Tegra234 and Tegra264: it uses resets and
reset-names instead of power-domains and power-domain-names, supports 6 PHYs
instead of 8, and has different interrupts and iommus limits. Fitting it into
this schema moves power-domains out of the top-level required list and adds
an if/then/else block that overrides most of the properties alongside the
existing per-SoC conditionals.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-tegra-usb-v2-0-42efc03a9700@nvidia.com?part=2
next prev parent reply other threads:[~2026-11-16 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:23 [PATCH v2 00/12] usb: Add support for Tegra238 and device support for Tegra264 Jon Hunter
2026-11-16 15:23 ` [PATCH v2 01/12] dt-bindings: usb: tegra234-xusb: Add required properties Jon Hunter
2026-11-16 15:23 ` [PATCH v2 02/12] dt-bindings: usb: Add Tegra238 XUSB host controller support Jon Hunter
2026-11-16 15:38 ` sashiko-bot [this message]
2026-11-16 15:24 ` [PATCH v2 03/12] dt-bindings: usb: tegra-xudc: Add Tegra238 XUDC support Jon Hunter
2026-11-16 15:24 ` [PATCH v2 04/12] dt-bindings: usb: tegra-xudc: Add Tegra264 " Jon Hunter
2026-11-16 15:24 ` [PATCH v2 05/12] usb: xhci: tegra: Fix missing semi-colon Jon Hunter
2026-11-16 15:24 ` [PATCH v2 06/12] usb: xhci: tegra: Add support for Tegra238 Jon Hunter
2026-11-16 15:24 ` [PATCH v2 07/12] usb: gadget: tegra-xudc: Fix CNT65 configuration Jon Hunter
2026-11-16 15:24 ` [PATCH v2 08/12] usb: gadget: tegra-xudc: Preserve runtime PM across system suspend Jon Hunter
2026-11-16 15:24 ` [PATCH v2 09/12] usb: gadget: tegra-xudc: Add support for Tegra238 Jon Hunter
2026-11-16 15:54 ` sashiko-bot
2026-11-16 15:24 ` [PATCH v2 10/12] usb: gadget: tegra-xudc: Add SSPX register offset to SoC data Jon Hunter
2026-11-16 15:24 ` [PATCH v2 11/12] usb: gadget: tegra-xudc: Add default settings " Jon Hunter
2026-11-16 15:24 ` [PATCH v2 12/12] usb: gadget: tegra-xudc: Add support for Tegra264 Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217310@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox