* [PATCH net-next v2 1/4] net: phy: dap8211r: fix kernel-doc comments for extended register helpers
2026-11-17 11:44 [PATCH net-next v2 0/4] net: phy: dap8211r: add LED control support Artem Shimko
@ 2026-11-17 11:44 ` Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 2/4] dt-bindings: net: dptel,dap8211r: add LED nodes Artem Shimko
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Artem Shimko @ 2026-11-17 11:44 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, maxime.chevallier, pavel
Cc: Artem Shimko, linux-kernel, devicetree, linux-leds, netdev
The kernel-doc comments for dap8211r_read_ext() and dap8211r_modify_ext()
incorrectly state that the caller must hold the MDIO bus lock.
Remove the misleading sentence from both comments since the functions
lock MDIO internally by themselves.
Fixes: d90265e75584d ("net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver")
Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
---
drivers/net/phy/dap8211r.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/phy/dap8211r.c b/drivers/net/phy/dap8211r.c
index 0bf770f8ebbb..1fe20efd394d 100644
--- a/drivers/net/phy/dap8211r.c
+++ b/drivers/net/phy/dap8211r.c
@@ -69,7 +69,6 @@ static const int dap8211r_internal_delay[] = {0, 150, 300, 450, 600, 750, 900,
* @reg: Extended register address
*
* Reads a PHY extended register using the indirect access method.
- * The caller must hold the MDIO bus lock.
*
* Return: Register value on success, or negative error code
*/
@@ -97,7 +96,6 @@ static int dap8211r_read_ext(struct phy_device *phydev, u16 reg)
*
* Modifies a PHY extended register using the indirect access method.
* New value = (old value & ~mask) | set.
- * The caller must hold the MDIO bus lock.
*
* Return: 0 on success, or negative error code
*/
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next v2 2/4] dt-bindings: net: dptel,dap8211r: add LED nodes
2026-11-17 11:44 [PATCH net-next v2 0/4] net: phy: dap8211r: add LED control support Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 1/4] net: phy: dap8211r: fix kernel-doc comments for extended register helpers Artem Shimko
@ 2026-11-17 11:44 ` Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 3/4] net: phy: dap8211r: add extended register write helper Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support Artem Shimko
3 siblings, 0 replies; 5+ messages in thread
From: Artem Shimko @ 2026-11-17 11:44 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, maxime.chevallier, pavel
Cc: Artem Shimko, linux-kernel, devicetree, linux-leds, netdev
Document the optional "leds" node supported by the DAP8211R PHY.
The PHY exposes three configurable LED outputs, each of which can be
assigned a color, a function and a default trigger.
Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
---
.../bindings/net/dptel,dap8211r.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
index 4cd0f9730d95..772329feda05 100644
--- a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
+++ b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
@@ -20,6 +20,7 @@ description: |
- IEEE 802.3az-2010 Energy Efficient Ethernet
- IEEE 1588 SyncE support
- Internal packet generator and checker for link diagnostics
+ - Three configurable LEDs (link, speed, duplex, TX/RX activity)
allOf:
- $ref: ethernet-phy.yaml#
@@ -45,10 +46,40 @@ properties:
maximum: 2250
default: 1950
+ leds:
+ type: object
+
+ description:
+ Optional node describing the three configurable LEDs of the PHY.
+ Each LED can be assigned a color, function and default trigger
+ (e.g. "netdev" for link/activity indication).
+
+ properties:
+ '#address-cells':
+ const: 1
+ '#size-cells':
+ const: 0
+
+ patternProperties:
+ '^led@[0-2]$':
+ type: object
+
+ $ref: /schemas/leds/common.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ reg:
+ items:
+ maximum: 2
+
+ additionalProperties: false
+
unevaluatedProperties: false
examples:
- |
+ #include <dt-bindings/leds/common.h>
+
mdio {
#address-cells = <1>;
#size-cells = <0>;
@@ -58,5 +89,24 @@ examples:
reg = <1>;
rx-internal-delay-ps = <1950>;
tx-internal-delay-ps = <1950>;
+
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_LAN;
+ linux,default-trigger = "netdev";
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_AMBER>;
+ function = LED_FUNCTION_LAN;
+ linux,default-trigger = "netdev";
+ };
+ };
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next v2 3/4] net: phy: dap8211r: add extended register write helper
2026-11-17 11:44 [PATCH net-next v2 0/4] net: phy: dap8211r: add LED control support Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 1/4] net: phy: dap8211r: fix kernel-doc comments for extended register helpers Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 2/4] dt-bindings: net: dptel,dap8211r: add LED nodes Artem Shimko
@ 2026-11-17 11:44 ` Artem Shimko
2026-11-17 11:44 ` [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support Artem Shimko
3 siblings, 0 replies; 5+ messages in thread
From: Artem Shimko @ 2026-11-17 11:44 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, maxime.chevallier, pavel
Cc: Artem Shimko, linux-kernel, devicetree, linux-leds, netdev
Add dap8211r_write_ext() to write extended registers via the indirect
access registers of the PHY.
This will be used to write extended registers of the DAP8211R.
Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
---
drivers/net/phy/dap8211r.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/net/phy/dap8211r.c b/drivers/net/phy/dap8211r.c
index 1fe20efd394d..f626b43fdee1 100644
--- a/drivers/net/phy/dap8211r.c
+++ b/drivers/net/phy/dap8211r.c
@@ -87,6 +87,31 @@ static int dap8211r_read_ext(struct phy_device *phydev, u16 reg)
return ret;
}
+/**
+ * dap8211r_write_ext() - Write extended register
+ * @phydev: PHY device structure
+ * @reg: Extended register address
+ * @data: Data to write
+ *
+ * Writes a PHY extended register using the indirect access method.
+ *
+ * Return: 0 on success, or negative error code
+ */
+static int dap8211r_write_ext(struct phy_device *phydev, u16 reg, u16 data)
+{
+ int ret;
+
+ phy_lock_mdio_bus(phydev);
+ ret = __phy_write(phydev, DAP8211R_EXT_ADD, reg);
+ if (ret < 0)
+ goto out;
+
+ ret = __phy_write(phydev, DAP8211R_EXT_DATA, data);
+out:
+ phy_unlock_mdio_bus(phydev);
+ return ret;
+}
+
/**
* dap8211r_modify_ext() - Modify extended register bits
* @phydev: PHY device structure
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support
2026-11-17 11:44 [PATCH net-next v2 0/4] net: phy: dap8211r: add LED control support Artem Shimko
` (2 preceding siblings ...)
2026-11-17 11:44 ` [PATCH net-next v2 3/4] net: phy: dap8211r: add extended register write helper Artem Shimko
@ 2026-11-17 11:44 ` Artem Shimko
3 siblings, 0 replies; 5+ messages in thread
From: Artem Shimko @ 2026-11-17 11:44 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, robh,
krzk+dt, conor+dt, maxime.chevallier, pavel
Cc: Artem Shimko, linux-kernel, devicetree, linux-leds, netdev
Add support for hardware-controlled LEDs and brightness on the DAP8211R
PHY. The chip exposes three LEDs that can be programmed to react to link,
speed, duplex, and TX/RX activity or be driven via the force mode.
Implement callbacks for led_brightness_set(), led_hw_is_supported(),
led_hw_control_set(), led_hw_control_get().
Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
---
drivers/net/phy/dap8211r.c | 216 +++++++++++++++++++++++++++++++++++++
1 file changed, 216 insertions(+)
diff --git a/drivers/net/phy/dap8211r.c b/drivers/net/phy/dap8211r.c
index f626b43fdee1..8e93a9a62746 100644
--- a/drivers/net/phy/dap8211r.c
+++ b/drivers/net/phy/dap8211r.c
@@ -12,6 +12,7 @@
*/
#include <linux/bitfield.h>
+#include <linux/bitops.h>
#include <linux/errno.h>
#include <linux/ethtool.h>
#include <linux/kernel.h>
@@ -57,6 +58,50 @@
*/
#define DAP8211R_DEFAULT_DEL_SEL 0xD
+#define DAP8211R_LED_ID_0 0
+#define DAP8211R_LED_ID_1 1
+#define DAP8211R_LED_ID_2 2
+
+/*
+ * LED_COMCON force mode bits:
+ * bit 2 - FORCE_EN (enable force mode for this LED)
+ * bit 1:0 - FORCE_MODE (00 = OFF, 01 = ON, 10/11 = blink mode1/mode2)
+ *
+ * Only ON/OFF is supported.
+ */
+#define DAP8211R_LED_COMCON 0xA00B
+#define DAP8211R_LED_FORCE_EN_BIT BIT(2)
+#define DAP8211R_LED_FORCE_ON_BIT BIT(0)
+
+#define DAP8211R_LED_FORCE_EN(idx) (DAP8211R_LED_FORCE_EN_BIT << 3 * (idx))
+#define DAP8211R_LED_FORCE_ON(idx) (DAP8211R_LED_FORCE_ON_BIT << 3 * (idx))
+
+#define DAP8211R_LED_FORCE_MODE GENMASK(1, 0)
+#define DAP8211R_LED_FORCE_MASK(idx) (DAP8211R_LED_FORCE_MODE << 3 * (idx))
+
+#define DAP8211R_LED_0_CON 0xA00C
+#define DAP8211R_LED_ACT_BLINK BIT(13)
+#define DAP8211R_LED_FULL_DUPLEX BIT(12)
+#define DAP8211R_LED_HALF_DUPLEX BIT(11)
+#define DAP8211R_LED_TX BIT(10)
+#define DAP8211R_LED_RX BIT(9)
+#define DAP8211R_LED_LINK_1000 BIT(6)
+#define DAP8211R_LED_LINK_100 BIT(5)
+#define DAP8211R_LED_LINK_10 BIT(4)
+
+#define DAP8211R_LED_LINK (DAP8211R_LED_LINK_10 | \
+ DAP8211R_LED_LINK_100 | \
+ DAP8211R_LED_LINK_1000)
+
+#define DAP8211R_LED_SUPPORTED_TRG (BIT(TRIGGER_NETDEV_LINK) | \
+ BIT(TRIGGER_NETDEV_LINK_10) | \
+ BIT(TRIGGER_NETDEV_LINK_100) | \
+ BIT(TRIGGER_NETDEV_LINK_1000) | \
+ BIT(TRIGGER_NETDEV_TX) | \
+ BIT(TRIGGER_NETDEV_RX) | \
+ BIT(TRIGGER_NETDEV_HALF_DUPLEX) | \
+ BIT(TRIGGER_NETDEV_FULL_DUPLEX))
+
static const int dap8211r_internal_delay[] = {0, 150, 300, 450, 600, 750, 900,
1050, 1200, 1350, 1500, 1650, 1800,
1950, 2100, 2250};
@@ -139,6 +184,173 @@ static int dap8211r_modify_ext(struct phy_device *phydev, u16 reg, u16 mask, u16
return ret;
}
+/**
+ * dap8211r_led_brightness_set() - Modify the LEDs common control register
+ * @phydev: PHY device structure
+ * @index: LED index
+ * @value: ON/OFF value for force mode of the LED
+ *
+ * Enables force mode and sets the LED to ON/OFF state.
+ * It will be disabled when hardware LED control is requested.
+ *
+ * Return: 0 on success, -EINVAL for an invalid LED index, or a negative error code
+ */
+static int dap8211r_led_brightness_set(struct phy_device *phydev, u8 index,
+ enum led_brightness value)
+{
+ u16 set, mask;
+
+ switch (index) {
+ case DAP8211R_LED_ID_0 ... DAP8211R_LED_ID_2:
+ mask = DAP8211R_LED_FORCE_MASK(index);
+ set = DAP8211R_LED_FORCE_EN(index);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ if (value != LED_OFF)
+ set |= DAP8211R_LED_FORCE_ON(index);
+
+ return dap8211r_modify_ext(phydev, DAP8211R_LED_COMCON, mask, set);
+}
+
+/**
+ * dap8211r_led_hw_is_supported() - Check if the requested LED rules are supported
+ * @phydev: PHY device structure
+ * @index: LED index
+ * @rules: Bitmask of requested netdev trigger rules
+ *
+ * Validates the requested combination of rules which can be represented in the
+ * hardware register.
+ *
+ * Return: 0 on success, -EINVAL for an invalid LED index,
+ * or -EOPNOTSUPP if any requested rule is not supported by the PHY
+ */
+static int dap8211r_led_hw_is_supported(struct phy_device *phydev, u8 index, unsigned long rules)
+{
+ switch (index) {
+ case DAP8211R_LED_ID_0 ... DAP8211R_LED_ID_2:
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return (rules & ~DAP8211R_LED_SUPPORTED_TRG) ? -EOPNOTSUPP : 0;
+}
+
+/**
+ * dap8211r_led_hw_control_set() - Write the LED control register
+ * @phydev: PHY device structure
+ * @index: LED index
+ * @rules: Bitmask of requested netdev trigger rules
+ *
+ * Disables force mode and translates the requested trigger rules into
+ * the corresponding bit positions of the LED control register and writes
+ * the resulting value to the PHY.
+ *
+ * Note that the ACT_BLINK bit (13) must be set together with TX/RX rules,
+ * otherwise the LED will not blink on traffic if no other rule (such as
+ * link or duplex) is active.
+ *
+ * Return: 0 on success, -EINVAL for an invalid LED index, or a negative error code
+ */
+static int dap8211r_led_hw_control_set(struct phy_device *phydev, u8 index, unsigned long rules)
+{
+ u16 led_mode = 0, led_reg;
+ int ret;
+
+ switch (index) {
+ case DAP8211R_LED_ID_0 ... DAP8211R_LED_ID_2:
+ led_reg = DAP8211R_LED_0_CON + index;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ ret = dap8211r_modify_ext(phydev, DAP8211R_LED_COMCON, DAP8211R_LED_FORCE_EN(index), 0);
+ if (ret)
+ return ret;
+
+ if (test_bit(TRIGGER_NETDEV_LINK, &rules))
+ led_mode |= DAP8211R_LED_LINK;
+
+ if (test_bit(TRIGGER_NETDEV_LINK_10, &rules))
+ led_mode |= DAP8211R_LED_LINK_10;
+
+ if (test_bit(TRIGGER_NETDEV_LINK_100, &rules))
+ led_mode |= DAP8211R_LED_LINK_100;
+
+ if (test_bit(TRIGGER_NETDEV_LINK_1000, &rules))
+ led_mode |= DAP8211R_LED_LINK_1000;
+
+ if (test_bit(TRIGGER_NETDEV_RX, &rules))
+ led_mode |= DAP8211R_LED_RX | DAP8211R_LED_ACT_BLINK;
+
+ if (test_bit(TRIGGER_NETDEV_TX, &rules))
+ led_mode |= DAP8211R_LED_TX | DAP8211R_LED_ACT_BLINK;
+
+ if (test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &rules))
+ led_mode |= DAP8211R_LED_HALF_DUPLEX;
+
+ if (test_bit(TRIGGER_NETDEV_FULL_DUPLEX, &rules))
+ led_mode |= DAP8211R_LED_FULL_DUPLEX;
+
+ return dap8211r_write_ext(phydev, led_reg, led_mode);
+}
+
+/**
+ * dap8211r_led_hw_control_get() - Read the current LED configuration
+ * @phydev: PHY device structure
+ * @index: LED index
+ * @rules: Pointer to a bitmask where the current rules will be stored
+ *
+ * Reads the LED control register and translates the hardware bit
+ * positions back into the corresponding netdev trigger rules bitmask.
+ *
+ * Return: 0 on success, -EINVAL for an invalid LED index, or a negative error code
+ */
+static int dap8211r_led_hw_control_get(struct phy_device *phydev, u8 index, unsigned long *rules)
+{
+ u16 led_reg;
+ int led_mode = 0;
+
+ switch (index) {
+ case DAP8211R_LED_ID_0 ... DAP8211R_LED_ID_2:
+ led_reg = DAP8211R_LED_0_CON + index;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ led_mode = dap8211r_read_ext(phydev, led_reg);
+ if (led_mode < 0)
+ return led_mode;
+
+ if (led_mode & DAP8211R_LED_LINK_10)
+ __set_bit(TRIGGER_NETDEV_LINK_10, rules);
+
+ if (led_mode & DAP8211R_LED_LINK_100)
+ __set_bit(TRIGGER_NETDEV_LINK_100, rules);
+
+ if (led_mode & DAP8211R_LED_LINK_1000)
+ __set_bit(TRIGGER_NETDEV_LINK_1000, rules);
+
+ if (led_mode & DAP8211R_LED_RX)
+ __set_bit(TRIGGER_NETDEV_RX, rules);
+
+ if (led_mode & DAP8211R_LED_TX)
+ __set_bit(TRIGGER_NETDEV_TX, rules);
+
+ if (led_mode & DAP8211R_LED_HALF_DUPLEX)
+ __set_bit(TRIGGER_NETDEV_HALF_DUPLEX, rules);
+
+ if (led_mode & DAP8211R_LED_FULL_DUPLEX)
+ __set_bit(TRIGGER_NETDEV_FULL_DUPLEX, rules);
+
+ return 0;
+}
+
/**
* dap8211r_config_init() - Initialize PHY
* @phydev: PHY device structure
@@ -227,6 +439,10 @@ static struct phy_driver dap8211r_driver[] = {
.config_aneg = genphy_config_aneg,
.suspend = genphy_suspend,
.resume = genphy_resume,
+ .led_brightness_set = dap8211r_led_brightness_set,
+ .led_hw_is_supported = dap8211r_led_hw_is_supported,
+ .led_hw_control_set = dap8211r_led_hw_control_set,
+ .led_hw_control_get = dap8211r_led_hw_control_get,
},
};
module_phy_driver(dap8211r_driver);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread