Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: John Crispin <john@phrozen.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Ahmed Naseef <naseefkm@gmail.com>,
	Benjamin Larsson <benjamin.larsson@genexis.eu>,
	Christian Marangi <ansuelsmth@gmail.com>,
	devicetree@vger.kernel.org, lei.dong@airoha.com,
	Linqi.zhang@airoha.com, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	mfd@lists.linux.dev,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Rajeev.kumar@airoha.com, upstream@airoha.com,
	Weifeng.xu@airoha.com, zhengping.zhang@airoha.com
Subject: Re: [PATCH v3 6/9] dt-bindings: pinctrl: airoha: add AN7589
Date: Wed, 18 Nov 2026 18:17:03 +0000	[thread overview]
Message-ID: <20261118-refried-storm-d43378dd6a28@spud> (raw)
In-Reply-To: <20261116174854.342912-7-john@phrozen.org>

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

On Mon, Nov 16, 2026 at 06:48:51PM +0100, John Crispin wrote:
> Document the AN7589 pin controller. It lives under the GPIO system
> controller and selects functions through a separate IOMUX syscon,
> referenced by the airoha,iomux phandle. Every pin is a GPIO in mode 0.
> 
> The AN7589 has no chip SCU dependency and the vendor SDK carries no pull
> or drive registers for it. Groups follow the SDK naming without its _grp
> suffix. As in the other Airoha pin controller bindings, a function names
> a block type, such as uart or i2c, and the group selects the instance. A
> node selects one group, except for pcm_spi and pcie, whose groups carry
> different signals of one device. The PON groups keep the working mode
> only: the SDK encodes the driver reset sequence as extra pinctrl states,
> which belongs in the consumer driver.
> 
> The pwm function routes a PWM channel to one of GPIO0 to GPIO15, with
> one group per pin. The pin also needs its GPIO output enabled, so conf
> nodes allow the GPIO direction and output level. Pull and drive
> properties are not allowed, as no registers for them are known.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
> Changes in v3:
> - Move the IOMUX syscon compatible and the GPIO system controller to
>   patches of their own (Lee, Conor).
> - Allow one group per node, except for pcm_spi and pcie, whose groups
>   carry different signals of one device (Conor).
> - Fix the uart5 example, which listed uart5 and uart5_full together.

As discussed elsewhere, 
pw-bot: changes-requested

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-11-18 18:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:48 [PATCH v3 0/9] pinctrl: airoha: add AN7589 support John Crispin
2026-11-16 17:48 ` [PATCH v3 1/9] pinctrl: airoha: make gpio register layout per SoC John Crispin
2026-11-16 17:48 ` [PATCH v3 2/9] pinctrl: airoha: add per pin mode field mux John Crispin
2026-11-16 17:48 ` [PATCH v3 3/9] pinctrl: airoha: make the chip SCU optional John Crispin
2026-11-16 17:48 ` [PATCH v3 4/9] pinctrl: airoha: mux a requested GPIO through the IOMUX John Crispin
2026-11-16 17:48 ` [PATCH v3 5/9] dt-bindings: mfd: syscon: add airoha,an7589-iomux John Crispin
2026-11-18 18:16   ` Conor Dooley
2026-11-16 17:48 ` [PATCH v3 6/9] dt-bindings: pinctrl: airoha: add AN7589 John Crispin
2026-11-18 18:17   ` Conor Dooley [this message]
2026-11-16 17:48 ` [PATCH v3 7/9] dt-bindings: mfd: airoha: add AN7589 GPIO system controller John Crispin
2026-11-18 18:16   ` Conor Dooley
2026-11-16 17:48 ` [PATCH v3 8/9] pinctrl: airoha: move the GPIO register offsets to the common header John Crispin
2026-11-16 17:48 ` [PATCH v3 9/9] pinctrl: airoha: add support of an7589 SoC John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118-refried-storm-d43378dd6a28@spud \
    --to=conor@kernel.org \
    --cc=Linqi.zhang@airoha.com \
    --cc=Rajeev.kumar@airoha.com \
    --cc=Weifeng.xu@airoha.com \
    --cc=ansuelsmth@gmail.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lei.dong@airoha.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=naseefkm@gmail.com \
    --cc=robh@kernel.org \
    --cc=upstream@airoha.com \
    --cc=zhengping.zhang@airoha.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox