Devicetree
 help / color / mirror / Atom feed
* [PATCH v3 0/3] iommu/arm-smmu-v3: Keep the clock of the RK3588 PCIe SMMU running
@ 2026-11-13  8:45 Arun Iyengar via B4 Relay
  2026-11-13  8:45 ` [PATCH v3 1/3] dt-bindings: iommu: arm,smmu-v3: Allow a clock and a reset Arun Iyengar via B4 Relay
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Arun Iyengar via B4 Relay @ 2026-11-13  8:45 UTC (permalink / raw)
  To: Will Deacon, Robin Murphy, Joerg Roedel (AMD), Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Niklas Cassel
  Cc: Pranjal Shrivastava, linux-arm-kernel, iommu, linux-kernel,
	devicetree, linux-rockchip, Sebastian Reichel, Shawn Lin,
	Simon Xue, Finley Xiao, Arun Iyengar

On RK3588 boards without an enabled PCIe controller, ACLK_MMU_PCIE is
gated as unused while arm-smmu-v3 is bound to the PCIe SMMU, and reboot
hangs in arm_smmu_device_shutdown() until the watchdog fires.

Patches 1-2 are for the iommu tree, patch 3 for the Rockchip tree.

Pranjal Shrivastava's "iommu/arm-smmu-v3: Implement Runtime/System
Sleep ops" v11 (not merged) has no clock handling; the clock can move
into its runtime PM callbacks once it lands. mmu600_php is disabled in
rk3588-base.dtsi and is not changed here.

Tested as v2 (same code, 7.3 kernel) on an Orange Pi 5 with the M.2
slot in SATA mode and the root filesystem on SATA: three reboots reach
the boot loader 0.59 s after "reboot: Restarting system" (was ~89 s,
via the watchdog), and aclk_mmu_pcie stays enabled. The resets property
is not used by the driver and was not tested.

Developed with Claude (Anthropic), which wrote the code and the commit
messages. I reviewed every change.

Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
---
Changes in v3:
- Shortened the commit messages and the cover letter, and dropped the
  "on SoCs where ..." part of the binding's clock description
  (Sebastian Reichel).
- Squashed the DTS reset patch into the clock patch (Sebastian Reichel).
  His Reviewed-by of the clock patch is kept.
- Dropped the description of the binding's resets property.
- No code changes.
- Link to v2: https://patch.msgid.link/20261112-smmu-v3-pcie-pd-v2-0-3a77bbb6b2c4@gmail.com

Changes in v2:
- Moved the fix for the Tegra CMDQV reference leak on a bad
  #iommu-cells (Sashiko AI review) to a separate patch.
- Dropped the power-domain patches: the TRM puts MMU600_PCIE in PD_PHP,
  which Linux does not control (Sebastian Reichel, Shawn Lin).
- Binding: one clock instead of up to four (Sashiko, Sebastian Reichel).
- Driver: one optional clock, got before the firmware probe so a failure
  cannot leak the CMDQV reference (Sashiko); shorter comment (Sebastian
  Reichel).
- Added the reset to the binding and the DTS (Sebastian Reichel).
- Link to v1: https://patch.msgid.link/20261110-smmu-v3-pcie-pd-v1-0-628819ca44b9@gmail.com

---
Arun Iyengar (3):
      dt-bindings: iommu: arm,smmu-v3: Allow a clock and a reset
      iommu/arm-smmu-v3: Enable an optional clock
      arm64: dts: rockchip: Add the clock and reset of the RK3588 PCIe SMMU

 Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml |  8 ++++++++
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi            |  2 ++
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c              | 11 +++++++++++
 3 files changed, 21 insertions(+)
---
base-commit: 2cf4be57b301ed2d7af82e70cff5dfd96894d8de
change-id: 20261110-smmu-v3-pcie-pd-a2f127b81d8f

Best regards,
--  
Arun Iyengar <aiyengar1990@gmail.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-18 21:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13  8:45 [PATCH v3 0/3] iommu/arm-smmu-v3: Keep the clock of the RK3588 PCIe SMMU running Arun Iyengar via B4 Relay
2026-11-13  8:45 ` [PATCH v3 1/3] dt-bindings: iommu: arm,smmu-v3: Allow a clock and a reset Arun Iyengar via B4 Relay
2026-11-18 20:32   ` Rob Herring (Arm)
2026-11-13  8:45 ` [PATCH v3 2/3] iommu/arm-smmu-v3: Enable an optional clock Arun Iyengar via B4 Relay
2026-11-18 20:32   ` Rob Herring
2026-11-18 21:00     ` Sebastian Reichel
2026-11-13  8:45 ` [PATCH v3 3/3] arm64: dts: rockchip: Add the clock and reset of the RK3588 PCIe SMMU Arun Iyengar via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox