Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: lee@kernel.org, maz@kernel.org, andy@kernel.org,
	dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	mfd@lists.linux.dev, linux-iio@vger.kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, crofts@kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order
Date: Sat, 21 Nov 2026 23:17:26 +0000	[thread overview]
Message-ID: <20261121231726.71aa1aba@jic23-hlaptop> (raw)
In-Reply-To: <20261119134041.16611-1-festevam@gmail.com>

On Thu, 19 Nov 2026 10:40:38 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> The interrupt descriptions added during the conversion to YAML do not
> match the ICOLL source numbers used by the existing DTS files.
> 
> For i.MX23, Table 5-1 of the reference manual maps source 36 to touch
> detection and sources 37 through 44 to channels 0 through 7. The DTS
> lists these sources in that order.
> 
> For i.MX28, Table 5-1 maps source 10 to touch detection, sources 14 and
> 15 to the threshold interrupts, sources 16 through 23 to channels 0
> through 7, and sources 24 and 25 to buttons 0 and 1. The DTS also lists
> these sources in that order.
> 
> Reorder the schema descriptions to match the hardware documentation and
> the existing DT ABI.
> 
> This change was prepared with assistance from OpenAI Codex, which was
> used to compare the binding with the reference manuals, existing DTS,
> and driver ordering.

This bit belongs below the --- with the change log.
I'll fix up if you don't have to do a v6 for other reasons.


> 
> Fixes: 009528b5aa13 ("dt-bindings: mfd: convert mxs-lradc bindings to json-schema")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> Changes since v4:
> - None.
> 
>  Documentation/devicetree/bindings/mfd/mxs-lradc.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/mxs-lradc.yaml b/Documentation/devicetree/bindings/mfd/mxs-lradc.yaml
> index 782b2f4005a0..755029880677 100644
> --- a/Documentation/devicetree/bindings/mfd/mxs-lradc.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mxs-lradc.yaml
> @@ -87,13 +87,13 @@ then:
>    properties:
>      interrupts:
>        items:
> +        - description: touchscreen
>          - description: channel 0
>          - description: channel 1
>          - description: channel 2
>          - description: channel 3
>          - description: channel 4
>          - description: channel 5
> -        - description: touchscreen
>          - description: channel 6
>          - description: channel 7
>      fsl,lradc-touchscreen-wires:
> @@ -102,6 +102,7 @@ else:
>    properties:
>      interrupts:
>        items:
> +        - description: touchscreen
>          - description: threshold 0
>          - description: threshold 1
>          - description: channel 0
> @@ -110,11 +111,10 @@ else:
>          - description: channel 3
>          - description: channel 4
>          - description: channel 5
> -        - description: button 0
> -        - description: button 1
> -        - description: touchscreen
>          - description: channel 6
>          - description: channel 7
> +        - description: button 0
> +        - description: button 1
>  
>  additionalProperties: false
>  


      parent reply	other threads:[~2026-11-21 23:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:40 [PATCH v5 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order Fabio Estevam
2026-11-19 13:40 ` [PATCH v5 2/4] iio: adc: mxs-lradc: Fix trigger use-after-free on removal Fabio Estevam
2026-11-19 16:08   ` Frank Li
2026-11-21 23:20     ` Jonathan Cameron
2026-11-19 13:40 ` [PATCH v5 3/4] mfd: mxs-lradc: Pass parent IRQs to child drivers Fabio Estevam
2026-11-19 16:14   ` Frank Li
2026-11-19 13:40 ` [PATCH v5 4/4] mfd: mxs-lradc: Convert to devm_clk_get_enabled() Fabio Estevam
2026-11-19 16:15   ` Frank Li
2026-11-19 20:53     ` Andy Shevchenko
2026-11-21 23:25       ` Jonathan Cameron
2026-11-21 23:26   ` Jonathan Cameron
2026-11-19 16:07 ` [PATCH v5 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order Frank Li
2026-11-21 23:17 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121231726.71aa1aba@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crofts@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=lee@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox