Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Frank Li <Frank.li@oss.nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	lee@kernel.org, maz@kernel.org, andy@kernel.org,
	dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	mfd@lists.linux.dev, linux-iio@vger.kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, crofts@kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH v5 4/4] mfd: mxs-lradc: Convert to devm_clk_get_enabled()
Date: Sat, 21 Nov 2026 23:25:22 +0000	[thread overview]
Message-ID: <20261121232522.6e8a631b@jic23-hlaptop> (raw)
In-Reply-To: <av9h2jvAwBPXdNmX@ashevche-desk.local>

On Thu, 19 Nov 2026 22:53:46 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Nov 19, 2026 at 10:15:57AM -0600, Frank Li wrote:
> > On Thu, Nov 19, 2026 at 10:40:41AM -0300, Fabio Estevam wrote:  
> 
> ...
> 
> > >  			dev_err(&pdev->dev,
> > >  				"Unsupported number of touchscreen wires (%d)\n"
> > >  				, ts_wires);
> > > -			ret = -EINVAL;
> > > -			goto err_clk;
> > > +			return -EINVAL;  
> 
> ^^^
> 
> > >  	if (ret) {
> > >  		dev_err(dev, "Failed to add subdevices\n");
> > > -		goto err_clk;
> > > +		return ret;  
> > 
> > If need respin, return dev_err_probe()  
> 
> And above and who knows how many more. That's why I haven't commented on this,
> if ever we do this, it most likely should be a separate change for the whole
> driver.

I agreed there are more but give the code is being touched, if there
is a new version I agree with Frank that cleaning the specific cases
up here is a nice to have (all of them though, not just the one!)

The whole
return dev_err_probe() pattern is only possible because of changes here
so feels like it fits in this patch even if a following one is needed
for any other cases.

Jonathan


> 


  reply	other threads:[~2026-11-21 23:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:40 [PATCH v5 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order Fabio Estevam
2026-11-19 13:40 ` [PATCH v5 2/4] iio: adc: mxs-lradc: Fix trigger use-after-free on removal Fabio Estevam
2026-11-19 16:08   ` Frank Li
2026-11-21 23:20     ` Jonathan Cameron
2026-11-19 13:40 ` [PATCH v5 3/4] mfd: mxs-lradc: Pass parent IRQs to child drivers Fabio Estevam
2026-11-19 16:14   ` Frank Li
2026-11-19 13:40 ` [PATCH v5 4/4] mfd: mxs-lradc: Convert to devm_clk_get_enabled() Fabio Estevam
2026-11-19 16:15   ` Frank Li
2026-11-19 20:53     ` Andy Shevchenko
2026-11-21 23:25       ` Jonathan Cameron [this message]
2026-11-21 23:26   ` Jonathan Cameron
2026-11-19 16:07 ` [PATCH v5 1/4] dt-bindings: mfd: mxs-lradc: Fix interrupt order Frank Li
2026-11-21 23:17 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121232522.6e8a631b@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Frank.li@oss.nxp.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crofts@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox