Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gerard Marull-Paretas <gerard@teslabs.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Frank Li" <Frank.li@nxp.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply
Date: Sun, 22 Nov 2026 20:52:11 +0000	[thread overview]
Message-ID: <20261122205211.6c46f3cc@jic23-hlaptop> (raw)
In-Reply-To: <20261122190836.66111-3-gerard@teslabs.com>

On Sun, 22 Nov 2026 20:08:35 +0100
Gerard Marull-Paretas <gerard@teslabs.com> wrote:

> Boards may switch the supply of the sensor, so get and enable it before
> initialising the chip, and wait the 5 ms both parts need after VDD is
> valid before they can be operated.
> 
> Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
> ---
>  drivers/iio/magnetometer/mmc5633.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/magnetometer/mmc5633.c b/drivers/iio/magnetometer/mmc5633.c
> index b651f01e1b5d..79015c7984de 100644
> --- a/drivers/iio/magnetometer/mmc5633.c
> +++ b/drivers/iio/magnetometer/mmc5633.c
> @@ -27,6 +27,7 @@
>  #include <linux/mutex.h>
>  #include <linux/pm.h>
>  #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
>  #include <linux/time.h>
>  #include <linux/types.h>
>  #include <linux/unaligned.h>
> @@ -64,6 +65,7 @@
>  #define MMC5633_CTRL1_BW_MASK		GENMASK(1, 0)
>  
>  #define MMC5633_WAIT_SET_RESET_US	(1 * USEC_PER_MSEC)
> +#define MMC5633_POWER_ON_US		(5 * USEC_PER_MSEC)

Obviously the line above isn't great on this, but is there a spec reference
we can make for this timing?

>  
>  #define MMC5633_HDR_CTRL0_MEAS_M	0x01
>  #define MMC5633_HDR_CTRL0_MEAS_T	0x03
> @@ -472,6 +474,12 @@ static int mmc5633_common_probe(struct regmap *regmap, char *name,
>  	if (ret)
>  		return ret;
>  
> +	ret = devm_regulator_get_enable(dev, "vdd");
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Failed to enable VDD regulator\n");
> +
> +	fsleep(MMC5633_POWER_ON_US);
> +
>  	indio_dev->info = &mmc5633_info;
>  	indio_dev->name = name;
>  	indio_dev->channels = mmc5633_channels;


  reply	other threads:[~2026-11-22 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 19:08 [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633 Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply Gerard Marull-Paretas
2026-11-22 20:52   ` Jonathan Cameron [this message]
2026-11-22 19:08 ` [PATCH v2 3/3] iio: magnetometer: mmc5633: Add mount matrix support Gerard Marull-Paretas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122205211.6c46f3cc@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gerard@teslabs.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox