From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com,
bhelgaas@google.com
Subject: Re: [PATCH v2 1/2] Documentation: DT: bindings: Add Broadcom STB PCIe bindings
Date: Mon, 09 May 2016 15:12:12 +0200 [thread overview]
Message-ID: <20692845.Ts1cTL7t9V@wuerfel> (raw)
In-Reply-To: <572BBF2E.5010606@broadcom.com>
On Thursday 05 May 2016 14:46:22 Florian Fainelli wrote:
>
> >
> >> +- brcm,gen: integer that indicates desired forced generation of link: 1 => 2.5
> >> + Gbps, 2 => 5.0 Gbps, 3 => 8.0 Gbps. Will override the auto-negotation if
> >> + specified.
> >
> > to repeat my earlier comment from v1:
> >
> > Shouldn't the link generation be probed automatically?
>
> It is, but if the property is present, we can foce the link negotiation,
> We have had cases where this was desired and helpful.
>
Right, I missed that this is listed as 'optional', so that seems
perfectly fine.
Thanks,
Arnd
next prev parent reply other threads:[~2016-05-09 13:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 19:14 [PATCH v2 0/2] pci: host: Broadcom STB PCIE RC controller support Florian Fainelli
2016-05-05 19:14 ` [PATCH v2 1/2] Documentation: DT: bindings: Add Broadcom STB PCIe bindings Florian Fainelli
2016-05-05 21:15 ` Arnd Bergmann
2016-05-05 21:46 ` Florian Fainelli
2016-05-09 13:12 ` Arnd Bergmann [this message]
2016-05-10 17:00 ` Florian Fainelli
2016-05-10 19:51 ` Arnd Bergmann
2016-05-09 19:26 ` Rob Herring
2016-05-09 23:15 ` Florian Fainelli
2016-05-09 23:15 ` Florian Fainelli
2016-05-11 14:45 ` Bharat Kumar Gogada
2016-05-17 1:52 ` Florian Fainelli
2016-05-05 19:15 ` [PATCH v2 2/2] pci: host: Add Broadcom STB PCIE RC controller Florian Fainelli
2016-05-11 14:47 ` Bharat Kumar Gogada
2016-05-17 1:50 ` Florian Fainelli
2016-06-09 22:31 ` [PATCH v2 0/2] pci: host: Broadcom STB PCIE RC controller support Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20692845.Ts1cTL7t9V@wuerfel \
--to=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox