From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, maddy@linux.ibm.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
ritesh.list@gmail.com, sshegde@linux.ibm.com,
sashiko-bot@kernel.org
Subject: Re: [PATCH v3] powerpc/dts: Add Device Tree for WatchGuard Firebox T30
Date: Wed, 28 Oct 2026 15:58:20 +0100 [thread overview]
Message-ID: <20a5a90e-ee8e-41c2-83e9-5ff03bd0edab@kernel.org> (raw)
In-Reply-To: <20261028143421.145290-1-lefteris.koutrakis@gmail.com>
On 28/10/2026 15:34, Lefteris Koutrakis wrote:
> Add initial support for the WatchGuard Firebox T30 board based on the
> PowerPC architecture, updating the fsl Makefile and adding the new DTS file.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Missing DCO. Please read carefully submitting patches.
> ---
> arch/powerpc/boot/dts/fsl/Makefile | 2 +
> arch/powerpc/boot/dts/fsl/firebox-t30.dts | 398 ++++++++++++++++++++++
> 2 files changed, 400 insertions(+)
> create mode 100644 arch/powerpc/boot/dts/fsl/firebox-t30.dts
>
> diff --git a/arch/powerpc/boot/dts/fsl/Makefile b/arch/powerpc/boot/dts/fsl/Makefile
> index d2cc8e1f0..0a5c8b596 100644
> --- a/arch/powerpc/boot/dts/fsl/Makefile
> +++ b/arch/powerpc/boot/dts/fsl/Makefile
> @@ -3,6 +3,7 @@
> dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(src)/%.dts,%.dtb, $(wildcard $(src)/*.dts))
>
> # MPC85xx platforms
> +dtb-$(CONFIG_MPC85xx_RDB) += firebox-t30.dtb
> dtb-$(CONFIG_BSC9131_RDB) += bsc9131rdb.dtb
> dtb-$(CONFIG_BSC9132_QDS) += bsc9132qds.dtb
> dtb-$(CONFIG_C293_PCIE) += c293pcie.dtb
> @@ -44,3 +45,4 @@ dtb-$(CONFIG_GEF_SBC310) += gef_sbc310.dtb
> dtb-$(CONFIG_GEF_SBC610) += gef_sbc610.dtb
> dtb-$(CONFIG_GEF_PPC9A) += gef_ppc9a.dtb
> dtb-$(CONFIG_MVME7100) += mvme7100.dtb
> +dtb-$(CONFIG_MPC85xx_RDB) += firebox-t30.dtb
> diff --git a/arch/powerpc/boot/dts/fsl/firebox-t30.dts b/arch/powerpc/boot/dts/fsl/firebox-t30.dts
> new file mode 100644
> index 000000000..6e9ec7f90
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/fsl/firebox-t30.dts
> @@ -0,0 +1,398 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +
> +/include/ "p1020si-pre.dtsi"
> +
> +/ {
> + model = "Watchguard Firebox T30";
> + compatible = "watchguard,firebox-t30", "fsl,P1020RDB";
Missing bindings, but not sure if it matters for PowerPC at all.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-10-28 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 14:34 [PATCH v3] powerpc/dts: Add Device Tree for WatchGuard Firebox T30 Lefteris Koutrakis
2026-10-28 14:47 ` sashiko-bot
2026-10-28 14:58 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a5a90e-ee8e-41c2-83e9-5ff03bd0edab@kernel.org \
--to=krzk@kernel.org \
--cc=chleroy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lefteris.koutrakis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox