From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards
Date: Thu, 16 Apr 2015 11:44:49 +0200 [thread overview]
Message-ID: <2204571.AOVr95oO32@wuerfel> (raw)
In-Reply-To: <1429170038-16757-4-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
On Thursday 16 April 2015 16:40:37 Masahiro Yamada wrote:
> +
> +/ {
> + model = "UniPhier PH1-LD4 Reference Board";
> + compatible = "socionext,ph1-ld4-ref", "socionext,ph1-ld4";
> +
> + memory {
> + device_type = "memory";
> + reg = <0x80000000 0x20000000>;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,115200 earlyprintk";
> + };
I would remove the 'earlyprintk' option here. You don't add any options
for the platform in Kconfig.debug, and I hope that we can eventually
start using earlycon. Please add an appropriate stdio-path property
here, but note that we are still lacking the fixmap patches to make
earlycon work.
Otherwise looks good.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-16 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 7:40 [PATCH 0/4] ARM: SoC: add a new platform, UniPhier (arch/arm/mach-uniphier) Masahiro Yamada
2015-04-16 7:40 ` [PATCH 1/4] ARM: UniPhier: add basic support for UniPhier architecture Masahiro Yamada
[not found] ` <1429170038-16757-2-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-04-16 9:41 ` Arnd Bergmann
2015-04-17 16:12 ` Masahiro Yamada
2015-04-16 9:56 ` Russell King - ARM Linux
[not found] ` <20150416095631.GY12732-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-04-17 16:01 ` Masahiro Yamada
2015-04-16 7:40 ` [PATCH 2/4] ARM: multi_v7_defconfig: enable UniPhier SoC family Masahiro Yamada
[not found] ` <1429170038-16757-3-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-04-16 9:42 ` Arnd Bergmann
2015-04-17 16:00 ` Masahiro Yamada
[not found] ` <CAK7LNAQ7rX7+YQHNmuXvRH7TKcVpNUdDRr5qUS6PYxPa=NYP0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-17 16:04 ` Arnd Bergmann
2015-04-16 7:40 ` [PATCH 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards Masahiro Yamada
[not found] ` <1429170038-16757-4-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-04-16 9:44 ` Arnd Bergmann [this message]
2015-04-17 16:16 ` Masahiro Yamada
2015-04-16 12:31 ` Andrew Lunn
2015-04-16 7:40 ` [PATCH 4/4] MAINTAINERS: add myself as ARM/UniPhier maintainer Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2204571.AOVr95oO32@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox