From: Arnd Bergmann <arnd@arndb.de>
To: Rameshwar Sahu <rsahu@apm.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
ddutile@redhat.com, jcm@redhat.com, patches@apm.com,
Loc Ho <lho@apm.com>
Subject: Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver
Date: Wed, 14 Jan 2015 12:54:25 +0100 [thread overview]
Message-ID: <2355599.PaLfD1Yyf4@wuerfel> (raw)
In-Reply-To: <CAFd313zMoW86ZcXURrk2K+E6129L+BruOp4E0A=w0PQEcMr-Yw@mail.gmail.com>
On Wednesday 14 January 2015 14:56:33 Rameshwar Sahu wrote:
>
> > Also add the correct dma-ranges property in the parent, or else this will
> > fail in the future once we add proper checks to dma_set_mask.
>
> I see arch/arm64 kernel doesn't use dma range value parsed from
> dma-range property currently, I will check it more.
> It doesn't use dma_pfn_offset value calculated by the dma-ranges in
> dma mapping API.
> dma-ranges value should test properly before adding.
> Is there any use to add this dma-ranges properly if arch code doesn't support ??
Of course: the dt needs to describe the hardware correctly. This is
just a bug in the current arm64 code and it will soon be fixed.
Arnd
next prev parent reply other threads:[~2015-01-14 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 11:09 [PATCH v2 0/3] dmaengine: APM X-Gene SoC DMA engine driver support Rameshwar Prasad Sahu
2015-01-07 11:09 ` [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver Rameshwar Prasad Sahu
2015-01-12 9:10 ` Rameshwar Sahu
2015-01-12 18:55 ` Arnd Bergmann
2015-01-14 9:26 ` Rameshwar Sahu
2015-01-14 11:54 ` Arnd Bergmann [this message]
[not found] ` <1420628981-22774-1-git-send-email-rsahu-qTEPVZfXA3Y@public.gmane.org>
2015-01-07 11:09 ` [PATCH v2 2/3] arm64: dts: Add APM X-Gene DMA device and DMA clock DTS nodes Rameshwar Prasad Sahu
2015-01-07 11:09 ` [PATCH v2 3/3] Documentation: dma: Add APM X-Gene SoC DMA engine driver documentation Rameshwar Prasad Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2355599.PaLfD1Yyf4@wuerfel \
--to=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=rsahu@apm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox