From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Grant Likely <grant.likely@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Mathieu Olivari <mathieu@codeaurora.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC
Date: Fri, 22 May 2015 21:26:14 +0200 [thread overview]
Message-ID: <2504338.ikNh5XCYe2@wuerfel> (raw)
In-Reply-To: <555F73FC.1030102@codeaurora.org>
On Friday 22 May 2015 11:22:52 Stephen Boyd wrote:
> > diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> > index 2256cd1..9cfebee 100644
> > --- a/arch/arm/mach-qcom/Kconfig
> > +++ b/arch/arm/mach-qcom/Kconfig
> > @@ -22,4 +22,11 @@ config ARCH_MSM8974
> > bool "Enable support for MSM8974"
> > select HAVE_ARM_ARCH_TIMER
> >
> > +config ARCH_APQ8084
> > + bool "Enable support for APQ8084"
> > + select HAVE_ARM_ARCH_TIMER
> > + select MIGHT_HAVE_PCI
> > + select PCI_DOMAINS if PCI
> > + select PCI_MSI if PCI
> > +
> >
>
> Can we move these PCI selects up to ARCH_QCOM directly? Let's try to
> avoid adding more SoC specific options under ARCH_QCOM.
I thought we already select 'MIGHT_HAVE_PCI' and 'PCI_DOMAINS' for
all ARMv7 platforms. If not, we probably should.
For PCI_MSI, I would leave that as user-selectable, there is no
need to enforce that as far as I can tell. If the driver needs
PCI_MSI support at compile-time, a dependency for that driver
would make sense.
Arnd
prev parent reply other threads:[~2015-05-22 19:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 12:42 [PATCH v2 0/5] Qualcomm PCIe and PCIe/PHY drivers Stanimir Varbanov
[not found] ` <1430743338-10441-1-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2015-05-04 12:42 ` [PATCH v2 1/5] DT: phy: qcom: Add PCIe PHY devicetree bindings Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY Stanimir Varbanov
2015-05-04 14:35 ` Kishon Vijay Abraham I
2015-05-04 15:24 ` Stanimir Varbanov
2015-05-19 22:41 ` Bjorn Helgaas
2015-05-20 13:08 ` Kishon Vijay Abraham I
2015-05-20 13:23 ` Bjorn Helgaas
2015-05-22 16:25 ` Stanimir Varbanov
2015-05-22 18:06 ` Bjorn Helgaas
2015-05-04 12:42 ` [PATCH v2 3/5] DT: PCI: qcom: Document PCIe devicetree bindings Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 4/5] PCI: qcom: Add Qualcomm PCIe controller driver Stanimir Varbanov
2015-11-06 20:50 ` Bjorn Andersson
2015-11-09 16:56 ` Stanimir Varbanov
2015-05-04 12:42 ` [PATCH v2 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC Stanimir Varbanov
2015-05-22 18:22 ` Stephen Boyd
2015-05-22 19:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2504338.ikNh5XCYe2@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mathieu@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox