public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc
@ 2026-04-08 15:09 guoweix
  2026-04-27 11:41 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: guoweix @ 2026-04-08 15:09 UTC (permalink / raw)
  To: heiko
  Cc: robh, krzk+dt, conor+dt, f.kardame, pgwipeout, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, guoweix

The RK809 PMIC interrupt pin on the Firefly ROC-RK3566-PC (Station M2)
is physically connected to GPIO0_A3 (RK_PA3) according to the board's
schematic.

Currently, the PMIC node incorrectly specifies RK_PA7 for the interrupt,
which prevents the PMIC from correctly signaling interrupts. (Note that
the pinctrl node 'pmic_int' correctly configures RK_PA3).

Fix this by updating the interrupts property to use RK_PA3.

Fixes: 30ac9b4e25d8 ("arm64: dts: rockchip: add dts for Firefly Station M2 rk3566")

Signed-off-by: guoweix <2298701336@qq.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
index 7e499064e035..985770e3a5e2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
@@ -245,7 +245,7 @@ rk809: pmic@20 {
 		compatible = "rockchip,rk809";
 		reg = <0x20>;
 		interrupt-parent = <&gpio0>;
-		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
+		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
 		clock-output-names = "rk808-clkout1", "rk808-clkout2";
 		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
 		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc
  2026-04-08 15:09 [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc guoweix
@ 2026-04-27 11:41 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2026-04-27 11:41 UTC (permalink / raw)
  To: guoweix
  Cc: robh, krzk+dt, conor+dt, f.kardame, pgwipeout, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, guoweix

Hi,

Am Mittwoch, 8. April 2026, 17:09:44 Mitteleuropäische Sommerzeit schrieb guoweix:
> The RK809 PMIC interrupt pin on the Firefly ROC-RK3566-PC (Station M2)
> is physically connected to GPIO0_A3 (RK_PA3) according to the board's
> schematic.
> 
> Currently, the PMIC node incorrectly specifies RK_PA7 for the interrupt,
> which prevents the PMIC from correctly signaling interrupts. (Note that
> the pinctrl node 'pmic_int' correctly configures RK_PA3).
> 
> Fix this by updating the interrupts property to use RK_PA3.
> 
> Fixes: 30ac9b4e25d8 ("arm64: dts: rockchip: add dts for Firefly Station M2 rk3566")
> 
> Signed-off-by: guoweix <2298701336@qq.com>

Could you use the more standard naming of "given name + surname" please?
For example with:
	git commit --amend --author="givenname surname <2298701336@qq.com>"

Or setting user.name in your .gitconfig.

Patch otherwise looks good.


Thanks a lot
Heiko


> ---
>  arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> index 7e499064e035..985770e3a5e2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> @@ -245,7 +245,7 @@ rk809: pmic@20 {
>  		compatible = "rockchip,rk809";
>  		reg = <0x20>;
>  		interrupt-parent = <&gpio0>;
> -		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
>  		clock-output-names = "rk808-clkout1", "rk808-clkout2";
>  		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
>  		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
> 





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-27 11:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08 15:09 [PATCH] arm64: dts: rockchip: fix rk809 interrupt pin on rk3566-roc-pc guoweix
2026-04-27 11:41 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox