[PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Bjorn Andersson]

The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
Add a node for these.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 arch/arm/boot/dts/qcom-pm8941.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
index cdd2bdb77b32..7881a071b372 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -144,6 +144,15 @@ pm8941_1: pm8941@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pm8941_lpg: lpg {
+			compatible = "qcom,pm8941-lpg";
+
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			status = "disabled";
+		};
+
 		pm8941_wled: wled@d800 {
 			compatible = "qcom,pm8941-wled";
 			reg = <0xd800>;
-- 
2.35.1

[PATCH 2/2] ARM: dts: qcom: msm8974-sony: Enable LPG

[Bjorn Andersson]

Both Castor and Honami has RGB LEDs driven by the PM8941 LPG, define
these.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../dts/qcom-msm8974-sony-xperia-rhine.dtsi   | 30 +++++++++++++++++++
 ...-msm8974pro-sony-xperia-shinano-castor.dts | 30 +++++++++++++++++++
 2 files changed, 60 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
index 1d21de46f85c..9891d0d40945 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
@@ -3,6 +3,7 @@
 #include "qcom-pm8841.dtsi"
 #include "qcom-pm8941.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 
 / {
@@ -172,6 +173,35 @@ gpio_keys_pin_a: gpio-keys-active {
 	};
 };
 
+&pm8941_lpg {
+	status = "okay";
+
+	qcom,power-source = <1>;
+
+	rgb-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <7>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <6>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <5>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &pm8941_wled {
 	status = "okay";
 
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 9bd8faea61a5..da1593192306 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -3,6 +3,7 @@
 #include "qcom-pm8841.dtsi"
 #include "qcom-pm8941.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 
 / {
@@ -288,6 +289,35 @@ lcd_dcdc_en_pin_a: lcd-dcdc-en-active {
 
 };
 
+&pm8941_lpg {
+	status = "okay";
+
+	qcom,power-source = <1>;
+
+	rgb-led {
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@1 {
+			reg = <7>;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@2 {
+			reg = <6>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		led@3 {
+			reg = <5>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+	};
+};
+
 &rpm_requests {
 	pm8941-regulators {
 		compatible = "qcom,rpm-pm8941-regulators";
-- 
2.35.1

Re: [PATCH 2/2] ARM: dts: qcom: msm8974-sony: Enable LPG

[Konrad Dybcio]

On 4.05.2022 22:54, Bjorn Andersson wrote:
> Both Castor and Honami has RGB LEDs driven by the PM8941 LPG, define
> these.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  .../dts/qcom-msm8974-sony-xperia-rhine.dtsi   | 30 +++++++++++++++++++
>  ...-msm8974pro-sony-xperia-shinano-castor.dts | 30 +++++++++++++++++++
>  2 files changed, 60 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index 1d21de46f85c..9891d0d40945 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -3,6 +3,7 @@
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
>  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  
>  / {
> @@ -172,6 +173,35 @@ gpio_keys_pin_a: gpio-keys-active {
>  	};
>  };
>  
> +&pm8941_lpg {
> +	status = "okay";
> +
> +	qcom,power-source = <1>;
> +
> +	rgb-led {
> +		color = <LED_COLOR_ID_RGB>;
> +		function = LED_FUNCTION_STATUS;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@1 {
> +			reg = <7>;
Hi,

please sync regs and unit addresses (and sort them while at it).

Konrad
> +			color = <LED_COLOR_ID_RED>;
> +		};
> +
> +		led@2 {
> +			reg = <6>;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		led@3 {
> +			reg = <5>;
> +			color = <LED_COLOR_ID_BLUE>;
> +		};
> +	};
> +};
> +
>  &pm8941_wled {
>  	status = "okay";
>  
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 9bd8faea61a5..da1593192306 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -3,6 +3,7 @@
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
>  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  
>  / {
> @@ -288,6 +289,35 @@ lcd_dcdc_en_pin_a: lcd-dcdc-en-active {
>  
>  };
>  
> +&pm8941_lpg {
> +	status = "okay";
> +
> +	qcom,power-source = <1>;
> +
> +	rgb-led {
> +		color = <LED_COLOR_ID_RGB>;
> +		function = LED_FUNCTION_STATUS;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@1 {
> +			reg = <7>;
> +			color = <LED_COLOR_ID_RED>;
> +		};
> +
> +		led@2 {
> +			reg = <6>;
> +			color = <LED_COLOR_ID_GREEN>;
> +		};
> +
> +		led@3 {
> +			reg = <5>;
> +			color = <LED_COLOR_ID_BLUE>;
> +		};
> +	};
> +};
> +
>  &rpm_requests {
>  	pm8941-regulators {
>  		compatible = "qcom,rpm-pm8941-regulators";
> 

Re: [PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Luca Weiss]

Hi Bjorn,

On Mittwoch, 4. Mai 2022 22:54:10 CEST Bjorn Andersson wrote:
> The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> Add a node for these.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi
> b/arch/arm/boot/dts/qcom-pm8941.dtsi index cdd2bdb77b32..7881a071b372
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -144,6 +144,15 @@ pm8941_1: pm8941@1 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> 
> +		pm8941_lpg: lpg {
> +			compatible = "qcom,pm8941-lpg";
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;

Just curious, why doesn't pm8941 have #pwm-cells = <2>; like the other lpg 
nodes in [0]?
Other than that, the node works fine on pm8941. Will send a patch for enabling 
notification LED on msm8974-FP2 soon.

Regards
Luca

[0] https://lore.kernel.org/linux-arm-msm/20220505022706.1692554-2-bjorn.andersson@linaro.org/


> +
> +			status = "disabled";
> +		};
> +
>  		pm8941_wled: wled@d800 {
>  			compatible = "qcom,pm8941-wled";
>  			reg = <0xd800>;

Re: [PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Bjorn Andersson]

On Thu 05 May 03:01 CDT 2022, Luca Weiss wrote:

> Hi Bjorn,
> 
> On Mittwoch, 4. Mai 2022 22:54:10 CEST Bjorn Andersson wrote:
> > The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> > Add a node for these.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  arch/arm/boot/dts/qcom-pm8941.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > b/arch/arm/boot/dts/qcom-pm8941.dtsi index cdd2bdb77b32..7881a071b372
> > 100644
> > --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> > @@ -144,6 +144,15 @@ pm8941_1: pm8941@1 {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> > 
> > +		pm8941_lpg: lpg {
> > +			compatible = "qcom,pm8941-lpg";
> > +
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> 
> Just curious, why doesn't pm8941 have #pwm-cells = <2>; like the other lpg 
> nodes in [0]?

I guess I didn't have a need for the lpg to be a pwm-chip on this pmic,
yet. This could be added now, or at a later point when someone has a
usecase for the pwm-chip.

> Other than that, the node works fine on pm8941. Will send a patch for enabling 
> notification LED on msm8974-FP2 soon.
> 

If you turn that into a Tested-by, and preferably a Reviewed-by, I would
have what I need to merge the two changes.

Looking forward to the FP2 patch.

Thanks,
Bjorn

> Regards
> Luca
> 
> [0] https://lore.kernel.org/linux-arm-msm/20220505022706.1692554-2-bjorn.andersson@linaro.org/
> 
> 
> > +
> > +			status = "disabled";
> > +		};
> > +
> >  		pm8941_wled: wled@d800 {
> >  			compatible = "qcom,pm8941-wled";
> >  			reg = <0xd800>;
> 
> 
> 
> 

Re: [PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Luca Weiss]

Hi Bjorn,

On Freitag, 6. Mai 2022 05:49:34 CEST Bjorn Andersson wrote:
> On Thu 05 May 03:01 CDT 2022, Luca Weiss wrote:
> > Hi Bjorn,
> > 
> > On Mittwoch, 4. Mai 2022 22:54:10 CEST Bjorn Andersson wrote:
> > > The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> > > Add a node for these.
> > > 
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > ---
> > > 
> > >  arch/arm/boot/dts/qcom-pm8941.dtsi | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > > b/arch/arm/boot/dts/qcom-pm8941.dtsi index cdd2bdb77b32..7881a071b372
> > > 100644
> > > --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> > > @@ -144,6 +144,15 @@ pm8941_1: pm8941@1 {
> > > 
> > >  		#address-cells = <1>;
> > >  		#size-cells = <0>;
> > > 
> > > +		pm8941_lpg: lpg {
> > > +			compatible = "qcom,pm8941-lpg";
> > > +
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > 
> > Just curious, why doesn't pm8941 have #pwm-cells = <2>; like the other lpg
> > nodes in [0]?
> 
> I guess I didn't have a need for the lpg to be a pwm-chip on this pmic,
> yet. This could be added now, or at a later point when someone has a
> usecase for the pwm-chip.

While I don't know the use case for using the lpg as pwm on consumer hardware, 
it's maybe a good idea to add now?

> 
> > Other than that, the node works fine on pm8941. Will send a patch for
> > enabling notification LED on msm8974-FP2 soon.
> 
> If you turn that into a Tested-by, and preferably a Reviewed-by, I would
> have what I need to merge the two changes.

In any case:

Tested-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

Regards
Luca

> 
> Looking forward to the FP2 patch.
> 
> Thanks,
> Bjorn
> 
> > Regards
> > Luca
> > 
> > [0]
> > https://lore.kernel.org/linux-arm-msm/20220505022706.1692554-2-bjorn.ande
> > rsson@linaro.org/> 
> > > +
> > > +			status = "disabled";
> > > +		};
> > > +
> > > 
> > >  		pm8941_wled: wled@d800 {
> > >  		
> > >  			compatible = "qcom,pm8941-wled";
> > >  			reg = <0xd800>;

Re: [PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Bjorn Andersson]

On Wed, 4 May 2022 13:54:10 -0700, Bjorn Andersson wrote:
> The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> Add a node for these.
> 
> 

Applied, thanks!

[1/2] ARM: dts: qcom: Add LPG node to pm8941
      commit: 5edd7d3e15a46c8549440a0b596c69be7e2c49fc
[2/2] ARM: dts: qcom: msm8974-sony: Enable LPG
      commit: 27f5947894c596fcfd6da20c061c582e7191e9e1

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>