Devicetree
 help / color / mirror / Atom feed
* [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply
@ 2026-11-19 12:51 pjh456
  2026-11-19 13:18 ` Krzysztof Kozlowski
  2026-11-19 13:20 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: pjh456 @ 2026-11-19 12:51 UTC (permalink / raw)
  To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-rtc, devicetree, linux-kernel

VDD is the HYM8563's main supply pin.  Describe it so boards can
express the regulator feeding the RTC; the property is optional
because many boards hardwire VDD to an always-on rail.  A side effect
of describing it is that fw_devlink orders the RTC probe after its
supply.  The Purple Pi OH board DTS (posted separately) relies on
that ordering.

AI assistance: the supply description was cross-checked against the
vendor schematic with Gemini 4 Hydrogen (Google AI Studio); the binding
change and this changelog were drafted with assistance from the
Qwen3.8 Flash Next and DeepSeek V4.1 Flash language models, driven
through the OpenCode coding agent, using the HYM8563 datasheet as
input; the submitter reviewed every line, validated the result with
dt_binding_check and on the affected board, and takes full
responsibility for it.

Link: https://lore.kernel.org/all/tencent_B11DE1495C3C54CE186ED508E2CE5CE41106@qq.com/
Link: https://lore.kernel.org/all/tencent_9B1CC4BF39DFA325C2B5384EA8B0319BAA07@qq.com/
Signed-off-by: pjh456 <pengjunhao409@gmail.com>
---
v3: use the generic "vdd-supply: true" form and show the supply in the
    example; reword the rationale around the hardware instead of the
    fw_devlink ordering; replace the non-standard "Assisted-by:"
    trailers with a disclosure paragraph in the commit message.
v2: rename vcc-supply to vdd-supply, matching the datasheet pin name
    (Sashiko review).

 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
index 0b9f39ef0edc..ce9712e2c406 100644
--- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
+++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
@@ -29,6 +29,8 @@ properties:
   wakeup-source:
     description: Enables wake up of host system on alarm.
 
+  vdd-supply: true
+
 allOf:
   - $ref: rtc.yaml
 
@@ -52,5 +54,6 @@ examples:
             reg = <0x51>;
             interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
             #clock-cells = <0>;
+            vdd-supply = <&rtc_vdd>;
         };
     };

base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply
  2026-11-19 12:51 [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply pjh456
@ 2026-11-19 13:18 ` Krzysztof Kozlowski
  2026-11-19 13:20 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-19 13:18 UTC (permalink / raw)
  To: pjh456, Alexandre Belloni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-rtc, devicetree, linux-kernel

On 19/11/2026 13:51, pjh456 wrote:
> VDD is the HYM8563's main supply pin.  Describe it so boards can
> express the regulator feeding the RTC; the property is optional
> because many boards hardwire VDD to an always-on rail.  A side effect
> of describing it is that fw_devlink orders the RTC probe after its
> supply.  The Purple Pi OH board DTS (posted separately) relies on
> that ordering.
> 
> AI assistance: the supply description was cross-checked against the
> vendor schematic with Gemini 4 Hydrogen (Google AI Studio); the binding
> change and this changelog were drafted with assistance from the
> Qwen3.8 Flash Next and DeepSeek V4.1 Flash language models, driven
> through the OpenCode coding agent, using the HYM8563 datasheet as
> input; the submitter reviewed every line, validated the result with
> dt_binding_check and on the affected board, and takes full
> responsibility for it.

Nothing in this paragraph is relevant to commit msg. That's changelog.

> 
> Link: https://lore.kernel.org/all/tencent_B11DE1495C3C54CE186ED508E2CE5CE41106@qq.com/
> Link: https://lore.kernel.org/all/tencent_9B1CC4BF39DFA325C2B5384EA8B0319BAA07@qq.com/

Not relevant, drop.

> Signed-off-by: pjh456 <pengjunhao409@gmail.com>

Nothing improved - still incomplete DCO. You MUST FINALLY read
submitting patches, not send us LLM output.

You were asked for that already. Read the output of LLM tool which you
are using. What does it ask you? What did the LLM tell you? Why are you
ignoring that parts?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply
  2026-11-19 12:51 [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply pjh456
  2026-11-19 13:18 ` Krzysztof Kozlowski
@ 2026-11-19 13:20 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-19 13:20 UTC (permalink / raw)
  To: pjh456, Alexandre Belloni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-rtc, devicetree, linux-kernel

On 19/11/2026 13:51, pjh456 wrote:
> the submitter reviewed every line, validated the result with
> dt_binding_check and on the affected board, and takes full
> responsibility for it.
>

"The submitter"? So LLM wrote it for the "submitter" and you just
blindly send it :/

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19 13:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 12:51 [PATCH v3] dt-bindings: rtc: haoyu,hym8563: document vdd-supply pjh456
2026-11-19 13:18 ` Krzysztof Kozlowski
2026-11-19 13:20 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox