[PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

[PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

[Abel Vesa]

The GCC USB3 primary PHY pipe clock is sourced by the USB3 pipe output of
the USB/DP QMP PHY. The corresponding GCC clock input was left as an
empty clock specifier when the USB nodes were added.

Connect the QMP PHY USB3 output to GCC so the USB3 PHY pipe clock can
propagate to the USB controller.

Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 66ea4aaafd73..2e0fbbfcc47d 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -655,7 +655,7 @@ gcc: clock-controller@100000 {
 				 <&ufs_mem_phy 0>,
 				 <&ufs_mem_phy 1>,
 				 <&ufs_mem_phy 2>,
-				 <0>;
+				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PHY>;
 
 			power-domains = <&rpmhpd RPMHPD_CX>;
 

---
base-commit: 4b18edbd8e70f7e6860d56370f13244896d0f95c
change-id: 20260825-dts-qcom-eliza-add-missing-usb-dp-phy-clk-to-gcc-9602a79db396

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect macro used for a clock specifier in devicetree (PHY ID used instead of clock ID).
--

--- Patch [1]: [PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC ---
commit d454bba6f2028b4ff89f276f88a76156819977d9
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

This commit connects the QMP PHY USB3 output to the GCC clock controller
so the USB3 PHY pipe clock can propagate to the USB controller.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index 66ea4aaafd73a..2e0fbbfcc47d3 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
> @@ -655,7 +655,7 @@ gcc: clock-controller@100000 {
>  				 <&ufs_mem_phy 0>,
>  				 <&ufs_mem_phy 1>,
>  				 <&ufs_mem_phy 2>,
> -				 <0>;
> +				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PHY>;

[Severity: Low]
Does this use the correct macro for a clock specifier?

It looks like the PHY ID macro QMP_USB43DP_USB3_PHY is being used here
instead of the clock ID macro QMP_USB43DP_USB3_PIPE_CLK. While both macros
currently evaluate to 0 and might not cause functional issues right now,
using a PHY ID for a clock reference makes the device tree fragile to
future macro changes and violates the expected bindings.

>  
>  			power-domains = <&rpmhpd RPMHPD_CX>;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-dts-qcom-eliza-add-missing-usb-dp-phy-clk-to-gcc-v1-1-f0d3719f798c@oss.qualcomm.com?part=1

Re: [PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

[Abel Vesa]

On 26-08-25 10:07:22, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Incorrect macro used for a clock specifier in devicetree (PHY ID used instead of clock ID).
> --
> 
> --- Patch [1]: [PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC ---
> commit d454bba6f2028b4ff89f276f88a76156819977d9
> Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
> 
> arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC
> 
> This commit connects the QMP PHY USB3 output to the GCC clock controller
> so the USB3 PHY pipe clock can propagate to the USB controller.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> > index 66ea4aaafd73a..2e0fbbfcc47d3 100644
> > --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
> > @@ -655,7 +655,7 @@ gcc: clock-controller@100000 {
> >  				 <&ufs_mem_phy 0>,
> >  				 <&ufs_mem_phy 1>,
> >  				 <&ufs_mem_phy 2>,
> > -				 <0>;
> > +				 <&usb_dp_qmpphy QMP_USB43DP_USB3_PHY>;
> 
> [Severity: Low]
> Does this use the correct macro for a clock specifier?
> 
> It looks like the PHY ID macro QMP_USB43DP_USB3_PHY is being used here
> instead of the clock ID macro QMP_USB43DP_USB3_PIPE_CLK. While both macros
> currently evaluate to 0 and might not cause functional issues right now,
> using a PHY ID for a clock reference makes the device tree fragile to
> future macro changes and violates the expected bindings.

Good catch. Will fix in v2.

Re: [PATCH] arm64: dts: qcom: eliza: Connect USB3 PHY pipe clock to GCC

[Konrad Dybcio]

On 8/25/26 11:58 AM, Abel Vesa wrote:
> The GCC USB3 primary PHY pipe clock is sourced by the USB3 pipe output of
> the USB/DP QMP PHY. The corresponding GCC clock input was left as an
> empty clock specifier when the USB nodes were added.
> 
> Connect the QMP PHY USB3 output to GCC so the USB3 PHY pipe clock can
> propagate to the USB controller.
> 
> Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad