* [PATCH v2 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override'
@ 2026-04-21 12:07 IRRatium
2026-04-21 12:08 ` [PATCH v2 2/2] dt-bindings: sound: " IRRatium
2026-04-21 12:17 ` [PATCH v2 1/2] ASoC: " Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: IRRatium @ 2026-04-21 12:07 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
Fix typo in property name 'cirrus,classh-bst-overide'.
Add support for the corrected 'cirrus,classh-bst-override'
while keeping backward compatibility with the old name.
Signed-off-by: Sergey Shatkov <majnkraftiigry7@gmail.com>
---
sound/soc/codecs/cs35l35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 7a01b1d9f..XXXXXXX 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1311,7 +1311,8 @@ static int cs35l35_handle_of_data(struct
i2c_client *i2c_client,
if (classh_config->classh_algo_enable) {
classh_config->classh_bst_override =
- of_property_read_bool(np, "cirrus,classh-bst-overide");
+ of_property_read_bool(np, "cirrus,classh-bst-override") ||
+ of_property_read_bool(np, "cirrus,classh-bst-overide");
ret = of_property_read_u32(classh,
"cirrus,classh-bst-max-limit",
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] dt-bindings: sound: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 12:07 [PATCH v2 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
@ 2026-04-21 12:08 ` IRRatium
2026-04-21 12:17 ` [PATCH v2 1/2] ASoC: " Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: IRRatium @ 2026-04-21 12:08 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
Fix typo in property name, should be 'cirrus,classh-bst-override'.
The driver now accepts both spellings for backward compatibility.
Signed-off-by: Sergey Shatkov <majnkraftiigry7@gmail.com>
---
Documentation/devicetree/bindings/sound/cs35l35.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/cs35l35.txt
b/Documentation/devicetree/bindings/sound/cs35l35.txt
index e84f30c5c..1d364b3d3 100644
--- a/Documentation/devicetree/bindings/sound/cs35l35.txt
+++ b/Documentation/devicetree/bindings/sound/cs35l35.txt
@@ -82,7 +82,7 @@ Optional H/G Algorithm sub-node:
Optional properties for the "cirrus,classh-internal-algo" Sub-node
Section 7.29 Class H Control
- - cirrus,classh-bst-overide : Boolean
+ - cirrus,classh-bst-override : Boolean
- cirrus,classh-bst-max-limit
- cirrus,classh-mem-depth
@@ -155,7 +155,7 @@ cs35l35: cs35l35@20 {
cirrus,shared-boost;
cirrus,classh-internal-algo {
- cirrus,classh-bst-overide;
+ cirrus,classh-bst-override;
cirrus,classh-bst-max-limit = <0x01>;
cirrus,classh-mem-depth = <0x01>;
cirrus,classh-release-rate = <0x08>;
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override'
2026-04-21 12:07 [PATCH v2 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
2026-04-21 12:08 ` [PATCH v2 2/2] dt-bindings: sound: " IRRatium
@ 2026-04-21 12:17 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-21 12:17 UTC (permalink / raw)
To: IRRatium, broonie
Cc: lgirdwood, robh, krzk+dt, conor+dt, david.rhodes, rf, linux-sound,
devicetree, linux-kernel, patches
On 21/04/2026 14:07, IRRatium wrote:
> Fix typo in property name 'cirrus,classh-bst-overide'.
> Add support for the corrected 'cirrus,classh-bst-override'
> while keeping backward compatibility with the old name.
>
> Signed-off-by: Sergey Shatkov <majnkraftiigry7@gmail.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Please provide changelog in the future, describing what changed.
From does not match SoB.
This solves the ABI breakage but I see little value in this change. The
typo is part of ABI and it does not really matter if the ABI has such
typo or not. Maintaining two ABIs matters more.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-21 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-21 12:07 [PATCH v2 1/2] ASoC: cs35l35: fix typo 'overide' -> 'override' IRRatium
2026-04-21 12:08 ` [PATCH v2 2/2] dt-bindings: sound: " IRRatium
2026-04-21 12:17 ` [PATCH v2 1/2] ASoC: " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox