Devicetree
 help / color / mirror / Atom feed
From: Lachlan Michael <Lachlan.Michael@sony.com>
To: Rob Herring <robh@kernel.org>, sashiko-reviews@lists.linux.dev
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, media-ci@linuxtv.org
Subject: Re: [PATCH v2 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor
Date: Wed, 19 Aug 2026 18:22:07 +0900	[thread overview]
Message-ID: <2a91eee6-c5d5-47ac-b0d1-9d50374be46d@sony.com> (raw)
In-Reply-To: <20260812021623.GA548637-robh@kernel.org>

Dear Rob,

Thanks for confirming Sashiko's review.

On 8/12/2026 11:16 AM, Rob Herring wrote:
> On Thu, Aug 06, 2026 at 07:20:54AM +0000, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>> - [Medium] Missing reference to standard video interface devices schema forbids common camera properties.
> 
> Yes.

Added

allOf:
   - $ref: /schemas/media/video-interface-devices.yaml#

>> - [Low] The `port` node does not explicitly require an `endpoint` child node.
> 
> No.
> 
>> - [Low] The fixed I2C address is not properly constrained to 0x1A.
> 
> Yes.

This was my mistake in the description. The IMX908 supports multiple I2C 
target addresses selected through the SLAMODE0 and SLAMODE1 pins, so the 
address is not fixed.

I changed the last line of the description to :

"The I2C target address is selected by the SLAMODE0 and SLAMODE1 pins."

and kept the existing reg definition.

Best Regards,

Lachlan




  reply	other threads:[~2026-08-19  9:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  7:09 [PATCH v2 0/2] Add bindings and driver for Sony IMX908 Lachlan Michael
2026-08-06  7:09 ` [PATCH v2 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor Lachlan Michael
2026-08-06  7:20   ` sashiko-bot
2026-08-12  2:16     ` Rob Herring
2026-08-19  9:22       ` Lachlan Michael [this message]
2026-08-06  7:09 ` [PATCH v2 2/2] media: i2c: Add Sony IMX908 image sensor driver Lachlan Michael
2026-08-06  7:26   ` sashiko-bot
2026-08-06 16:50   ` Dave Stevenson
2026-08-17  9:21     ` Lachlan.Michael
2026-08-07  6:53   ` Jai Luthra
2026-08-19  5:06     ` Lachlan Michael
2026-08-19  9:34     ` Jacopo Mondi
2026-08-14 12:38   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a91eee6-c5d5-47ac-b0d1-9d50374be46d@sony.com \
    --to=lachlan.michael@sony.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox