From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harini.katakam@amd.com>
Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, vladimir.oltean@nxp.com,
wsa+renesas@sang-engineering.com,
krzysztof.kozlowski+dt@linaro.org, simon.horman@corigine.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com,
michal.simek@amd.com, radhey.shyam.pandey@amd.com
Subject: Re: [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning
Date: Wed, 26 Apr 2023 15:48:24 +0200 [thread overview]
Message-ID: <2bbbe874-2879-4b1a-bf79-2d5c1a7a35f4@lunn.ch> (raw)
In-Reply-To: <20230426104313.28950-4-harini.katakam@amd.com>
On Wed, Apr 26, 2023 at 04:13:13PM +0530, Harini Katakam wrote:
> From: Harini Katakam <harini.katakam@xilinx.com>
>
> Add support for VSC8531_02 (Rev 2) device.
> Add support for optional RGMII RX and TX delay tuning via devicetree.
> The hierarchy is:
> - Retain the defaul 0.2ns delay when RGMII tuning is not set.
> - Retain the default 2ns delay when RGMII tuning is set and DT delay
> property is NOT specified.
tuning is probably the wrong word here. I normally consider tuning as
small changes from 0ns/2ns. The course setting of 0ns or 2ns is not
tuning. I normally use RGMII internal delays to refer to that.
However, i'm not sure there is consistency among drivers.
Andrew
next prev parent reply other threads:[~2023-04-26 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 10:43 [PATCH net-next v2 0/3] Add support for VSC8531_02 PHY and DT RGMII tuning Harini Katakam
2023-04-26 10:43 ` [PATCH net-next v2 1/3] phy: mscc: Use PHY_ID_MATCH_VENDOR to minimize PHY ID table Harini Katakam
2023-04-26 13:39 ` Andrew Lunn
2023-04-26 17:27 ` Katakam, Harini
2023-04-26 10:43 ` [PATCH net-next v2 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning Harini Katakam
2023-04-26 11:10 ` Vladimir Oltean
2023-04-26 13:42 ` Andrew Lunn
2023-04-26 10:43 ` [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning Harini Katakam
2023-04-26 11:18 ` Vladimir Oltean
2023-04-26 12:21 ` Katakam, Harini
2023-04-26 14:18 ` Vladimir Oltean
2023-04-26 17:39 ` Katakam, Harini
2023-04-26 13:48 ` Andrew Lunn [this message]
2023-04-26 17:30 ` Katakam, Harini
2023-04-26 15:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bbbe874-2879-4b1a-bf79-2d5c1a7a35f4@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=harini.katakam@amd.com \
--cc=harinikatakamlinux@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox