From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org,
Christian Kahr <christian.kahr@sie.at>
Subject: Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
Date: Tue, 2 Sep 2025 17:45:16 +0200 [thread overview]
Message-ID: <2c649ee4-5b2a-4f8e-b61e-8847885e877b@kernel.org> (raw)
In-Reply-To: <c37bf116-9250-46fa-9a6c-24cb9b3af661@roeck-us.net>
On 02/09/2025 15:48, Guenter Roeck wrote:
> On 9/2/25 01:39, Krzysztof Kozlowski wrote:
>> On Mon, Sep 01, 2025 at 02:56:48PM -0700, Guenter Roeck wrote:
>>> Add a compatible string for INA700. The chip is register compatible with
>>> INA780 but implements different ADC ranges and thus needs a separate
>>> compatible entry.
>>>
>>> Cc: Christian Kahr <christian.kahr@sie.at>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Please mention in commit msg where is any user of that.
>>
>
> You lost me a bit on that one. Christian had submitted a driver, but missed
And how do I know that there was such driver? commit msg should tell
that one way or another.
> the devicetree documentation. That is what this patch is for. I frankly don't
> know how to mention a user as requested; I don't easily find an example
> in other devicetree patches. Typically the commit message is just "add <chip>
> to <bindings>". Please give me an example of what you are looking for.
"Document existing compatible string for INA700. ....."
This is an easy way to explain that it already is used.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-02 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 21:56 [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700 Guenter Roeck
2025-09-02 8:39 ` Krzysztof Kozlowski
2025-09-02 13:48 ` Guenter Roeck
2025-09-02 15:45 ` Krzysztof Kozlowski [this message]
2025-09-02 16:11 ` Guenter Roeck
2025-09-02 19:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c649ee4-5b2a-4f8e-b61e-8847885e877b@kernel.org \
--to=krzk@kernel.org \
--cc=christian.kahr@sie.at \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox