* [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
@ 2025-09-01 21:56 Guenter Roeck
2025-09-02 8:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2025-09-01 21:56 UTC (permalink / raw)
To: devicetree
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-hwmon,
Guenter Roeck, Christian Kahr
Add a compatible string for INA700. The chip is register compatible with
INA780 but implements different ADC ranges and thus needs a separate
compatible entry.
Cc: Christian Kahr <christian.kahr@sie.at>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 8b491be9c49d..d3cde8936686 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -32,6 +32,7 @@ properties:
- ti,ina237
- ti,ina238
- ti,ina260
+ - ti,ina700
- ti,ina780
reg:
@@ -115,6 +116,7 @@ allOf:
- ti,ina237
- ti,ina238
- ti,ina260
+ - ti,ina700
- ti,ina780
then:
properties:
@@ -133,6 +135,7 @@ allOf:
- ti,ina230
- ti,ina231
- ti,ina260
+ - ti,ina700
- ti,ina780
then:
properties:
@@ -143,6 +146,7 @@ allOf:
compatible:
contains:
enum:
+ - ti,ina700
- ti,ina780
then:
properties:
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
2025-09-01 21:56 [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700 Guenter Roeck
@ 2025-09-02 8:39 ` Krzysztof Kozlowski
2025-09-02 13:48 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-02 8:39 UTC (permalink / raw)
To: Guenter Roeck
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, Christian Kahr
On Mon, Sep 01, 2025 at 02:56:48PM -0700, Guenter Roeck wrote:
> Add a compatible string for INA700. The chip is register compatible with
> INA780 but implements different ADC ranges and thus needs a separate
> compatible entry.
>
> Cc: Christian Kahr <christian.kahr@sie.at>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Please mention in commit msg where is any user of that.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
2025-09-02 8:39 ` Krzysztof Kozlowski
@ 2025-09-02 13:48 ` Guenter Roeck
2025-09-02 15:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2025-09-02 13:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, Christian Kahr
On 9/2/25 01:39, Krzysztof Kozlowski wrote:
> On Mon, Sep 01, 2025 at 02:56:48PM -0700, Guenter Roeck wrote:
>> Add a compatible string for INA700. The chip is register compatible with
>> INA780 but implements different ADC ranges and thus needs a separate
>> compatible entry.
>>
>> Cc: Christian Kahr <christian.kahr@sie.at>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Please mention in commit msg where is any user of that.
>
You lost me a bit on that one. Christian had submitted a driver, but missed
the devicetree documentation. That is what this patch is for. I frankly don't
know how to mention a user as requested; I don't easily find an example
in other devicetree patches. Typically the commit message is just "add <chip>
to <bindings>". Please give me an example of what you are looking for.
Thanks,
Guenter
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
2025-09-02 13:48 ` Guenter Roeck
@ 2025-09-02 15:45 ` Krzysztof Kozlowski
2025-09-02 16:11 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-02 15:45 UTC (permalink / raw)
To: Guenter Roeck
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, Christian Kahr
On 02/09/2025 15:48, Guenter Roeck wrote:
> On 9/2/25 01:39, Krzysztof Kozlowski wrote:
>> On Mon, Sep 01, 2025 at 02:56:48PM -0700, Guenter Roeck wrote:
>>> Add a compatible string for INA700. The chip is register compatible with
>>> INA780 but implements different ADC ranges and thus needs a separate
>>> compatible entry.
>>>
>>> Cc: Christian Kahr <christian.kahr@sie.at>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Please mention in commit msg where is any user of that.
>>
>
> You lost me a bit on that one. Christian had submitted a driver, but missed
And how do I know that there was such driver? commit msg should tell
that one way or another.
> the devicetree documentation. That is what this patch is for. I frankly don't
> know how to mention a user as requested; I don't easily find an example
> in other devicetree patches. Typically the commit message is just "add <chip>
> to <bindings>". Please give me an example of what you are looking for.
"Document existing compatible string for INA700. ....."
This is an easy way to explain that it already is used.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
2025-09-02 15:45 ` Krzysztof Kozlowski
@ 2025-09-02 16:11 ` Guenter Roeck
2025-09-02 19:35 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2025-09-02 16:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, Christian Kahr
On 9/2/25 08:45, Krzysztof Kozlowski wrote:
> On 02/09/2025 15:48, Guenter Roeck wrote:
>> On 9/2/25 01:39, Krzysztof Kozlowski wrote:
>>> On Mon, Sep 01, 2025 at 02:56:48PM -0700, Guenter Roeck wrote:
>>>> Add a compatible string for INA700. The chip is register compatible with
>>>> INA780 but implements different ADC ranges and thus needs a separate
>>>> compatible entry.
>>>>
>>>> Cc: Christian Kahr <christian.kahr@sie.at>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> Please mention in commit msg where is any user of that.
>>>
>>
>> You lost me a bit on that one. Christian had submitted a driver, but missed
>
> And how do I know that there was such driver? commit msg should tell
> that one way or another.
>
>> the devicetree documentation. That is what this patch is for. I frankly don't
>> know how to mention a user as requested; I don't easily find an example
>> in other devicetree patches. Typically the commit message is just "add <chip>
>> to <bindings>". Please give me an example of what you are looking for.
>
> "Document existing compatible string for INA700. ....."
>
> This is an easy way to explain that it already is used.
>
Upcoming would be more appropriate. NP, I'll resubmit with the actual driver
patch series once it is ready and keep that in mind for the future.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700
2025-09-02 16:11 ` Guenter Roeck
@ 2025-09-02 19:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-02 19:35 UTC (permalink / raw)
To: Guenter Roeck
Cc: devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-hwmon, Christian Kahr
On 02/09/2025 18:11, Guenter Roeck wrote:
>>
>>> the devicetree documentation. That is what this patch is for. I frankly don't
>>> know how to mention a user as requested; I don't easily find an example
>>> in other devicetree patches. Typically the commit message is just "add <chip>
>>> to <bindings>". Please give me an example of what you are looking for.
>>
>> "Document existing compatible string for INA700. ....."
>>
>> This is an easy way to explain that it already is used.
>>
> Upcoming would be more appropriate. NP, I'll resubmit with the actual driver
> patch series once it is ready and keep that in mind for the future.
Ah, sorry, I did not get it, it is a driver on the lists? I thought you
are documenting something which you already merged.
Well, then the solution could be lore link in patch changelog. Resending
as one patchset is also fine.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-02 19:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 21:56 [PATCH] dt-bindings: hwmon: ti,ina2xx: Add INA700 Guenter Roeck
2025-09-02 8:39 ` Krzysztof Kozlowski
2025-09-02 13:48 ` Guenter Roeck
2025-09-02 15:45 ` Krzysztof Kozlowski
2025-09-02 16:11 ` Guenter Roeck
2025-09-02 19:35 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox