Re: [PATCH 1/3] dt-bindings: dma: qcom: bam-dma: Add support for kaanapali BAM v2.0.0

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/04/2026 10:34, Kuldeep Singh wrote:
> On 25-04-2026 15:53, Krzysztof Kozlowski wrote:
>> On Fri, Apr 24, 2026 at 05:04:15PM +0530, Kuldeep Singh wrote:
>>> Kaanapali support newer BAM v2.0.0 version.
>>> Document the compatible string and update example along with it.
>>
>> And why v2.0.0 is not compatible with v1.7.0? Or what is not compatible?
> 
> Kindly check patch 2/3 of series to understand register level 
> differences in v1.7.0 to v2.0.0.

This patch commit should explain WHY you are doing this patch.


> 
>>
>>>
>>> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
>>> ---
>>>   .../devicetree/bindings/dma/qcom,bam-dma.yaml       | 21 +++++++++++++++++++++
>>>   1 file changed, 21 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> index 6493a6968bb4..0923fb189ada 100644
>>> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
>>> @@ -23,6 +23,8 @@ properties:
>>>             - qcom,bam-v1.4.0
>>>             # MSM8916, SDM630
>>>             - qcom,bam-v1.7.0
>>> +          # Kaanapali
>>> +          - qcom,bam-v2.0.0
>>>         - items:
>>>             - enum:
>>>                 # SDM845, SM6115, SM8150, SM8250 and QCM2290
>>> @@ -118,4 +120,23 @@ examples:
>>>           #dma-cells = <1>;
>>>           qcom,ee = <0>;
>>>       };
>>> +  - |
>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>
>> Drop the example, no need for difference in compatible.
> The current example captures an old instance and doesn't give complete 
> picture.
> Example, doesn't specify iommus, qcom,controlled-remotely etc. whereas 
> recent ones don't specify clocks and reg address/size cells are 2 not 1.

That's fine then and should be mentioned in the commit msg.

Best regards,
Krzysztof